From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Steven Allen Newsgroups: gmane.emacs.bugs Subject: bug#63731: [PATCH] Support Emoji Variation Sequence 16 (FE0F) where appropriate Date: Fri, 26 May 2023 08:06:11 -0700 Message-ID: <87lehbrv30.fsf@stebalien.com> References: <87a5xrzsph.fsf@stebalien.com> <83pm6nlhll.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12787"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63731@debbugs.gnu.org To: Eli Zaretskii , Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 26 17:07:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2Z2M-00037H-0d for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 May 2023 17:07:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2Z20-0006cC-3A; Fri, 26 May 2023 11:07:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2Z1y-0006bi-Ed for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 11:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q2Z1y-0006x1-6l for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 11:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q2Z1x-0004HX-NB for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 11:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Steven Allen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 May 2023 15:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63731-submit@debbugs.gnu.org id=B63731.168511358116401 (code B ref 63731); Fri, 26 May 2023 15:07:01 +0000 Original-Received: (at 63731) by debbugs.gnu.org; 26 May 2023 15:06:21 +0000 Original-Received: from localhost ([127.0.0.1]:50548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2Z1J-0004GT-3a for submit@debbugs.gnu.org; Fri, 26 May 2023 11:06:21 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36883) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2Z1H-0004GE-Fp for 63731@debbugs.gnu.org; Fri, 26 May 2023 11:06:19 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 6D9115C00FD; Fri, 26 May 2023 11:06:14 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 26 May 2023 11:06:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1685113574; x= 1685199974; bh=LyLYOPL4AT490ZcSa8wUFwc+l/XtxLibrgFGY1k8hL0=; b=K EMedvAEp16gOCmkZuMDNwKryNR1t3OounAI3A5wd8e4cNyZ5clxKIGc8p136EaG9 K0K1LygGiFjKtcGdWQETD8XiT61KzFHrcEmGVpEFOV5jQ3ZN0UNaA/iUvtTZT3NT pvq4uOjLu/Dr7pyqNSu3m741O7keaXPU8ykAvPHVYOhHfbyoWrZeLxieB0JYyKfa wMZn+HPQNCz7V03Wry6QjdDlHQGcf3/c1WUdO3C5GjQ1crF9ncipW5Vos0anSzfr mGXwwLEAUBiZBn6GOjMQ+AiQhu6+pYMpFG5wBjlLz3HB99tV9xz9K21tKMWhirLd u/GOeEngpv/jp4+dpIPVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1685113574; x=1685199974; bh=LyLYOPL4AT490 ZcSa8wUFwc+l/XtxLibrgFGY1k8hL0=; b=VweSduGIJl/NT9bLv1x8oEOCZKMRs /lwqRCFAJ/9Ojij+VtY0erYEeJnCQveDOhZDQ4AFmFaTxl+9Eyn0uCMw7X9HoaK0 PQRN3Wr7IUwlSrh6TksQ1vcIJ3eRvZ5PVifHSKuIuHoQ3eeIm1jVJvMuC5mJupzF DhI+ozx1At/xlwzx92cput5C/a+iMvPyLiEx83vHUvjsdrbgbUUnKlibogQPSKyK qxZxGjxrWKSOPBEGemtjkOjWhriSD865w4/I+6i4JDyFHPgRp3h9vzPAaYllVdbH IT9x9iPlir++xQGQO+hkGTd+jLSJV/JMyiblXt+5/q3SKq/lm4NWGUqTg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejledgkeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkgggtsehttdertddttddtnecuhfhrohhmpefuthgvvhgv nhcutehllhgvnhcuoehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomheqnecuggftrf grthhtvghrnhepjefffeduvdeifeegveekgefgleehhfffgeelteffteeutdetgfegffeh ueefkedtnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepshhtvghvvghnsehsthgvsggrlhhivghnrdgt ohhm X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 26 May 2023 11:06:13 -0400 (EDT) In-Reply-To: <83pm6nlhll.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262437 Archived-At: Eli Zaretskii writes: > AFAIU, this change will populate composition-function-table for many > "normal" characters, including ASCII digits and symbol/punctuation > characters from the 0x2xxx blocks. E.g., after you build Emacs with > this patch, what do the following evaluations yield: > > M-: (aref composition-function-table ?0) RET > M-: (aref composition-function-table #x2122) RET > > If they yield non-nil values, it could mean dramatic slowdown of > redisplay with these characters. Both of these yield nil with this patch applied (and I haven't noticed any performance regressions). But it looks like you and Robert have a better patch so I'll leave you to it. However, I'd like to draw your attention to the existing hard-coded VS-16 table here: https://git.savannah.gnu.org/cgit/emacs.git/tree/admin/unidata/emoji-zwj.awk?h=4b3de748b0b04407d2492500c77905de56de1180#n72 It feels like this should either be the full table (the one in the patch) or it shouldn't exist at all. But again, I'm not the expert here.