From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Sun, 16 Jul 2023 10:38:14 +0000 Message-ID: <87lefggmzt.fsf@localhost> References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <83r0p9b3om.fsf@gnu.org> <83jzv1b152.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30252"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 64596@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 16 12:39:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKz9o-0007eu-DF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jul 2023 12:39:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKz9b-0001o1-FL; Sun, 16 Jul 2023 06:39:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKz9a-0001ns-3J for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 06:39:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKz9Z-0004TL-SU for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 06:39:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKz9Z-0003yw-OP for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 06:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jul 2023 10:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168950389015243 (code B ref 64596); Sun, 16 Jul 2023 10:39:01 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 16 Jul 2023 10:38:10 +0000 Original-Received: from localhost ([127.0.0.1]:46923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKz8j-0003xn-RX for submit@debbugs.gnu.org; Sun, 16 Jul 2023 06:38:10 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:34991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKz8h-0003xK-Oa for 64596@debbugs.gnu.org; Sun, 16 Jul 2023 06:38:08 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 1D657240029 for <64596@debbugs.gnu.org>; Sun, 16 Jul 2023 12:38:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689503882; bh=oRqb/lYW5DRVbwkJmrSXETtRXTID110mYg+uag7vra4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=djY0XaY7lUu0I6879FcRUHG7oiULLSRDEd0E7ZCsDhhexi0koeivnsDNiidZq34Gb zyIDNR2/TPhKdGX4ob4KPFQ8FewfP9SuWe82ndlykeRYSlPJi0TlZluO1JiUvBgZK6 QxPG9m3QM+LTh0+PM5iZW56FNJHjaj0E7yM2J/XC5krtRGDTt9b924AwNJxqSWN5Bp PXNq8p/0eJ6iaD84EMBuSrOI4kPVgahhSvonUbIvfJrJhLGGxrTIR7IobCC83i+13i J2yEskgkmvLfUO3f1qKfrFZ+Ado//lHepOSDgh/JRT82ue3uZBOIT9gbFBLNhgkztU vzds7uPG9a5Tg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R3hWF3406z6txR; Sun, 16 Jul 2023 12:38:01 +0200 (CEST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265314 Archived-At: Stefan Monnier writes: > -/* Non-zero if we should redraw the mode lines on the next redisplay. > +/* Non-zero if we should redraw the mode line*s* on the next redisplay. > Usually set to a unique small integer so we can track the main causes of > - full redisplays in `redisplay--mode-lines-cause'. */ > + full redisplays in `redisplay--mode-lines-cause'. > + Here "mode lines" includes also header-lines and frame names, and > + apparently also menu-bars. The link with header-lines is clear, > + but a bit less so for frame names and the menu-bar. */ It would be even better if *-mode-lines functions were renamed to something more explicit. It is very disorienting that "mode-line" may mean actual mode-line, but sometimes more than that. A clarifying comment is an improvement, but does not make the code in other places more readable. Maybe use a term like "info-lines" to avoid confusion of using the same term for multiple different meanings? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at