From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Should `indirect-function' be preferred over `fboundp'? Date: Fri, 21 Jul 2023 06:07:54 +0000 Message-ID: <87lef994qt.fsf@localhost> References: <87h6pzxdof.fsf@localhost> <87cz0mul4j.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18998"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 21 08:08:55 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qMjJu-0004fH-IP for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Jul 2023 08:08:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMjJB-0001Hn-1M; Fri, 21 Jul 2023 02:08:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMjJ3-0001EX-Oo for emacs-devel@gnu.org; Fri, 21 Jul 2023 02:08:03 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMjIp-0001za-Oe for emacs-devel@gnu.org; Fri, 21 Jul 2023 02:08:01 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 6529D240103 for ; Fri, 21 Jul 2023 08:07:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689919662; bh=wRaa+4h/Hw1mC8sXtRe2j7vY0PfWwlheGGT4OOTrv1s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=VnDgk3aqWr/UWaEAqFNVZa1jrTV4dhWwJit6N6Z9769Mu7R9pr6D+B7TFedDWmp92 bm1RGycZ4o0M73M/X02O8giGKpci1P9OdeCf4g8GcZfkzjHw+V0+DyB3SI9BAwwzo1 uRDIEA8WCLD6wSWx9GAhL5RZ26BSA8viO2edsiyD2NwsY+VAjiR8nZBUbu4BH2e9HO JPZaaAUQqLpBqQlpV7bmkk7cIORcA+4d+Y8KlN1ZiKz/DGtpK+RZg/IKnUM2aqRety zoQIYGrhtRQD2MZ5F2BeW8w17TdhHCRpj3Ke9GJxdDUqO3R9nbfWMfpm0HeJA1sW2W 6M9tzcERkNCGw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R6fH15wbSz9s0w; Fri, 21 Jul 2023 08:07:41 +0200 (CEST) In-Reply-To: <87cz0mul4j.fsf@web.de> Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307993 Archived-At: Michael Heerdegen writes: > An alias is a definition. In most cases the definition as an alias is > intentional. If an alias points to an undefined function, I guess that, > in the majority of cases, this hints at some kind of problem so it's > better to have an error rather than to circumvent the problem by using > `indirect-function'. Fair point. > Are aliases to undefined functions something to expect often? The > compiler warns in the case when the DEFINITION is the name of an unknown > function. It should be the responsibility of the alias creating code to > ensure that the alias is not broken. In my case, it was ob-lilypond.el aliasing a function in optional dependency, although that is not a good style (I fixed that already). Another possible scenarios is `define-obsolete-function-alias' when the function is not loaded for some reason (like when it is defined in a different file). We have plenty of these in org-compat.el. Finally, user aliases defined in the user config, where accidentally not loading some package is not unseen (especially with `use-package' and friends that make it more forgiving to not have some packages installed). I think that part of the problem _for me_ is that (defalias 'yant/foo 'yant/bar) (fboundp 'yant/foo) ; => t (funcall 'yant/foo) ; => ERROR: Symbol function definition is void: yant/foo only shows an error for `yant/foo', which is somewhat confusing. `yant/bar' is where function definition is truly void. That's what took me some extra time to figure out what is wrong. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at