From: Michael Albinus <michael.albinus@gmx.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Mattias Engdegård" <mattias.engdegard@gmail.com>, emacs-devel@gnu.org
Subject: Re: master bb9133f09da: * lisp/emacs-lisp/ert.el (ert-run-tests-batch-and-exit): Inhibit interaction
Date: Mon, 14 Aug 2023 17:01:16 +0200 [thread overview]
Message-ID: <87leedwtvn.fsf@gmx.de> (raw)
In-Reply-To: <jwvpm3pofmf.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 14 Aug 2023 10:39:26 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
Hi Stefan,
> Oh, I think I see: `inhibit-interaction` is probably tested too early,
> e.g. upon entry to `read-event` (which can return without user
> interaction if there's enough `unread-command-events` and friends)
> instead of upon entry to the actual code that waits for user input, so
> it doesn't quite do what I thought it would.
If you want to check yourself, here are the tests which failed due to
the (inhibited-interaction) check on emba:
--8<---------------cut here---------------start------------->8---
FAILED 50/91 tramp-test26-interactive-file-name-completion (0.004941 sec) at lisp/net/tramp-tests.el:4841
FAILED 1/22 abbrev--possibly-save-test (0.004799 sec) at lisp/abbrev-tests.el:308
FAILED 1/7 auto-revert-test00-auto-revert-mode (0.215386 sec) at lisp/autorevert-tests.el:146
FAILED 2/7 auto-revert-test01-auto-revert-several-files (0.385464 sec) at lisp/autorevert-tests.el:191
FAILED 3/7 auto-revert-test03-auto-revert-tail-mode (0.033018 sec) at lisp/autorevert-tests.el:335
FAILED 4/7 auto-revert-test04-auto-revert-mode-dired (0.098083 sec) at lisp/autorevert-tests.el:370
FAILED 6/7 auto-revert-test06-write-file (0.035447 sec) at lisp/autorevert-tests.el:538
FAILED 7/7 auto-revert-test07-auto-revert-several-buffers (0.042405 sec) at lisp/autorevert-tests.el:572
FAILED 2/6 find-func-tests--library-completion (0.001559 sec) at lisp/emacs-lisp/find-func-tests.el:32
FAILED 4/5 viper-test-undo-3 (0.057615 sec) at lisp/emulation/viper-tests.el:118
FAILED 1/5 erc-add-entry-to-list (0.000351 sec) at lisp/erc/erc-match-tests.el:27
FAILED 11/15 erc-nicks-customize-face (0.127834 sec) at lisp/erc/erc-nicks-tests.el:441
FAILED 3/9 erc-sasl--read-password--basic (0.029777 sec) at lisp/erc/erc-sasl-tests.el:35
FAILED 17/17 erc-nickserv-get-password (0.002919 sec) at lisp/erc/erc-services-tests.el:534
FAILED 4/54 erc--check-prompt-input-for-excess-lines (0.000534 sec) at lisp/erc/erc-tests.el:1187
FAILED 13/54 erc--interactive (0.002051 sec) at lisp/erc/erc-tests.el:1829
FAILED 26/54 erc--switch-to-buffer (0.001627 sec) at lisp/erc/erc-tests.el:465
FAILED 46/54 erc-select-read-args (0.000371 sec) at lisp/erc/erc-tests.el:1606
FAILED 50/54 erc-server-select (0.008819 sec) at lisp/erc/erc-tests.el:1865
FAILED 52/54 erc-tls (0.058334 sec) at lisp/erc/erc-tests.el:1713
FAILED 5/18 file-notify-test02-rm-watch (0.045676 sec) at lisp/filenotify-tests.el:396
FAILED 6/18 file-notify-test02-rm-watch-remote (3.690951 sec) at lisp/filenotify-tests.el:1
FAILED 7/18 file-notify-test04-autorevert (2.026364 sec) at lisp/filenotify-tests.el:937
FAILED 8/18 file-notify-test05-file-validity (0.023406 sec) at lisp/filenotify-tests.el:1039
FAILED 9/18 file-notify-test05-file-validity-remote (3.579880 sec) at lisp/filenotify-tests.el:1
FAILED 12/18 file-notify-test07-many-events (0.023911 sec) at lisp/filenotify-tests.el:1220
FAILED 13/18 file-notify-test08-backup (0.009403 sec) at lisp/filenotify-tests.el:1298
FAILED 14/18 file-notify-test08-backup-remote (1.419481 sec) at lisp/filenotify-tests.el:1
FAILED 17/18 file-notify-test11-symlinks (0.011308 sec) at lisp/filenotify-tests.el:1581
FAILED 18/18 file-notify-test11-symlinks-remote (1.899609 sec) at lisp/filenotify-tests.el:1
FAILED 2/13 mule-cmds--test-universal-coding-system-argument (0.000393 sec) at lisp/international/mule-tests.el:45
FAILED 25/44 kmacro-tests-step-edit-edits-macro-with-extended-command (0.001692 sec) at lisp/kmacro-tests.el:800
FAILED 3/25 completion-auto-help-test (0.000958 sec) at lisp/minibuffer-tests.el:346
FAILED 4/25 completion-auto-select-test (0.000783 sec) at lisp/minibuffer-tests.el:374
FAILED 5/25 completion-auto-wrap-test (0.000320 sec) at lisp/minibuffer-tests.el:396
FAILED 24/25 completions-affixation-navigation-test (0.000354 sec) at lisp/minibuffer-tests.el:453
FAILED 25/25 completions-header-format-test (0.000346 sec) at lisp/minibuffer-tests.el:425
FAILED 4/48 eglot-test-basic-completions (0.363706 sec) at lisp/progmodes/eglot-tests.el:540
FAILED 5/48 eglot-test-basic-diagnostics (0.280194 sec) at lisp/progmodes/eglot-tests.el:421
FAILED 12/48 eglot-test-eldoc-after-completions (0.440281 sec) at lisp/progmodes/eglot-tests.el:639
FAILED 14/48 eglot-test-formatting (0.424955 sec) at lisp/progmodes/eglot-tests.el:672
FAILED 19/48 eglot-test-multiline-eldoc (0.334466 sec) at lisp/progmodes/eglot-tests.el:655
FAILED 20/48 eglot-test-non-unique-completions (0.290398 sec) at lisp/progmodes/eglot-tests.el:556
FAILED 19/29 query-replace-search-function-tests (0.009815 sec) at lisp/replace-tests.el:459
FAILED 20/29 query-replace-tests (0.000823 sec) at lisp/replace-tests.el:411
FAILED 2/13 ses-jump-B2-lowcase-keys (0.010933 sec) at lisp/ses-tests.el:213
FAILED 34/48 simple-test-undo-extra-boundary-in-tex (0.078750 sec) at lisp/simple-tests.el:694
FAILED 2/10 whitespace-tests--empty-bob (0.001325 sec) at lisp/whitespace-tests.el:130
FAILED 5/10 whitespace-tests--empty-eob (0.001189 sec) at lisp/whitespace-tests.el:232
FAILED 1/3 xt-mouse-tracking-basic (0.412822 sec) at lisp/xt-mouse-tests.el:60
FAILED 2/3 xt-mouse-tracking-sgr (0.001347 sec) at lisp/xt-mouse-tests.el:101
FAILED 3/3 xt-mouse-tracking-utf-8 (0.001496 sec) at lisp/xt-mouse-tests.el:79
FAILED 1/2 inotify-file-watch-simple (0.008711 sec) at src/inotify-tests.el:52
FAILED 2/2 keyboard-unread-command-events (0.000233 sec) at src/keyboard-tests.el:24
FAILED 27/32 threads-signal-main-thread (0.002614 sec) at src/thread-tests.el:325
FAILED 6/10 xdisp-tests--minibuffer-resizing (0.007032 sec) at src/xdisp-tests.el:35
FAILED 7/10 xdisp-tests--minibuffer-scroll (0.000490 sec) at src/xdisp-tests.el:55
--8<---------------cut here---------------end--------------->8---
> Stefan
Best regards, Michael.
next prev parent reply other threads:[~2023-08-14 15:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <169195451549.1474.16374421496442723026@vcs2.savannah.gnu.org>
[not found] ` <20230813192155.C53CEC295F9@vcs2.savannah.gnu.org>
2023-08-14 7:13 ` master bb9133f09da: * lisp/emacs-lisp/ert.el (ert-run-tests-batch-and-exit): Inhibit interaction Michael Albinus
2023-08-14 8:25 ` Mattias Engdegård
2023-08-14 14:00 ` Stefan Monnier
2023-08-14 14:25 ` Mattias Engdegård
2023-08-14 14:39 ` Stefan Monnier
2023-08-14 15:01 ` Michael Albinus [this message]
2023-08-14 15:05 ` Stefan Monnier
2023-08-14 19:30 ` Jens Schmidt
2023-08-14 20:19 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leedwtvn.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=mattias.engdegard@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.