From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Preferred approach to inclusion of data in ELPA package Date: Sun, 20 Aug 2023 20:42:55 +0000 Message-ID: <87lee5sawg.fsf@posteo.net> References: <28956ffc-6cc0-1f39-a26b-1453b48d61b1@hugot.nl> <878ra91ie7.fsf@posteo.net> <87bkf3vxm3.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5776"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Hugo Thunnissen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 20 22:43:59 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXpHC-0001IM-Mk for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Aug 2023 22:43:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXpGR-0003sW-25; Sun, 20 Aug 2023 16:43:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXpGN-0003s8-UK for emacs-devel@gnu.org; Sun, 20 Aug 2023 16:43:07 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXpGK-0007bV-Jl for emacs-devel@gnu.org; Sun, 20 Aug 2023 16:43:07 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 70C5324002B for ; Sun, 20 Aug 2023 22:43:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692564182; bh=XUDhAraP5RxxXAOMTSPb/grh9FYeJJUilgM7kYXjAuE=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=MF+JSqj8xUuZpT9QcrQtmk2JAo/RjxREnuTg7HU6v5J0nc9PZbCO4B9sD6AiXNUDI s0hHWcZb1hcGdP1Ws41cXJYWHVuBVEIrEqsiV7Qi4VkySefFaJgfROmJNsXgRVpJLa eeiLgL2/DSIFhxyuJAtJPXHiQXQLof2jTopAS2m/u18sh4iSe6+AyotPJ/RtdNYdZQ Od6b71fUfxOOIJ30FW5xPV/YjS/FQOu62Kq0D8xaLoay2fCSonN4bDFnYTwj31avvx oPM+rk72d1IKkg5KNSFDYzOpyFHYEMMP6lp96WeynNe45h2a2DU9NrDdDmtZFWoAnh tDz5jGCOvAL7g== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RTSH570Gjz6ty0; Sun, 20 Aug 2023 22:42:57 +0200 (CEST) In-Reply-To: (Hugo Thunnissen's message of "Sun, 20 Aug 2023 21:24:26 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309000 Archived-At: Hugo Thunnissen writes: > On 8/19/23 17:51, Philip Kaludercic wrote: >> Hugo Thunnissen writes: >> >>> On 8/17/23 23:14, Philip Kaludercic wrote: >>>> Another idea is to have a Makefile generate the file, like the one you >>>> describe in option 2., that is generate whenever the package is built >>>> and bundled into a tarball for distribution. That way you don't have to >>>> store a binary blob in your repository, and you can avoid burdening the >>>> user with additional computations at either compile or runtime. >>>> >>>> Does the generation require any special functionality/tools/code to be >>>> provided on the device the index is generated on? >>> The php function/class stubs are generated with a php script, but I'm >>> checking the resulting stubs file into git. The index itself can be >>> built with just my package based on the stubs file. >> I saw that, and the commit did not look that nice, but I cannot say that >> I have looked into the issue in sufficient detail to say with certainty >> or not that there is no better solution. >> > There are alternatives or improvements to this approach, which I > mentioned in my response to sbaug > (https://lists.gnu.org/archive/html/emacs-devel/2023-08/msg00748.html) > . I don't think I'll be able to get around having to distribute-, or > having the user download/generate some kind of index though. If PHP were available in the ELPA build environment, do you think that would change anything? >>> Also: If the former is the case, is the reduction in load time that >>> this brings even significant enough to be worth the bother or should I >>> just hold off on this while I look for a more efficient solution? >> I'd say it would be worth it, if the resulting package would be smaller >> and would load quicker. After all, the performance on your laptop might >> not be that significant of a difference, while for someone else with an >> older or slower device, a 30%-speedup is pretty significant. > > You're right, on less performant systems it could make a more > significant difference. And good news, after a few improvements the > load time is now down to ~150ms on my laptop. I also chose to load the > data when the mode is first initialized, so simply loading my package > won't cause the index to be loaded with it. The dumping of the index > is done automatically when it is not present, so it would technically > be fine to just distribute the PHP stubs with the package instead of > the .eld index file. This would just make the user wait a little > longer the first time they use the mode. Would it be possible to load the information when it is required (e.g. necessary for completion)?