From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs,gmane.emacs.orgmode Subject: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Date: Wed, 06 Sep 2023 08:30:36 +0000 Message-ID: <87ledju2j7.fsf@localhost> References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13867"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65734@debbugs.gnu.org, emacs-orgmode@gnu.org, iota@whxvd.name To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 06 10:30:33 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdnvk-0003Qs-AB for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Sep 2023 10:30:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdnvR-0004zi-06; Wed, 06 Sep 2023 04:30:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdnvF-0004y4-ND for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 04:30:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdnvF-0004uv-Dr for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 04:30:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdnvG-0004oh-3p for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 04:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Sep 2023 08:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65734 X-GNU-PR-Package: emacs Original-Received: via spool by 65734-submit@debbugs.gnu.org id=B65734.169398899618473 (code B ref 65734); Wed, 06 Sep 2023 08:30:02 +0000 Original-Received: (at 65734) by debbugs.gnu.org; 6 Sep 2023 08:29:56 +0000 Original-Received: from localhost ([127.0.0.1]:60753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdnv9-0004nt-GH for submit@debbugs.gnu.org; Wed, 06 Sep 2023 04:29:55 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:54681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdnv6-0004nf-Gi for 65734@debbugs.gnu.org; Wed, 06 Sep 2023 04:29:54 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id E15AF240028 for <65734@debbugs.gnu.org>; Wed, 6 Sep 2023 10:29:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693988985; bh=p5OcqwWSVZV3xyQtHDBgwpktUY+5M1SqLnsTCvK1uG8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=XGg8ANTuxbYaTUEfTr7D8D1mP0FFunqZbQTkVZMY3fxxy7SrPByTIbKYCC5w17AcR e2zG1G7jyx5uJHJpZn5OCRomjVsgmkOFczhoAxeMBIQMi9guhgI9SKKL7EHuLrcvU8 M01Y8pLbAblQKLFKFXt0qOFCFXAE2mG9aaUrK/+S2DANGqdDdIYN0c6ckqiKOWN7s2 9AIJu/D5iaUl1B5y2QupIcJLPxkpPzYt/cbvlQenTgASBHlxRRZNVX5vhqpXjSFTt9 o5NAreKil/fFzAYIvnuoXcsdKYqAJS7iTFrPsywQ+9/d8BXlS1KcHNS86MtnV7dAVz dWtH7ryLSnEcw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RgbCF2vhmz9rxS; Wed, 6 Sep 2023 10:29:45 +0200 (CEST) In-Reply-To: <83h6o84yz1.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269495 gmane.emacs.orgmode:157123 Archived-At: Eli Zaretskii writes: >> It would also make sense to group the two edits together via >> `combine-after-change-calls', although a more universal way to know that >> certain edits are a part of the same known command (even when called >> non-interactively) would be useful. > > The command kills in two parts for a good reason, which is explained > in the comments to the code. So making a single group will not work, > I think, at least not in all situations. I think there is misunderstanding. `combine-after-change-calls' will not affect the two-step modification of the kill ring, if we put it around `kill-whole-line'. Or do I miss something? > ... And relying on after-change > hooks to fix this use case sounds too obscure and fragile to me. Indeed. I did not talk about this particular bug report. What I meant is some way to group change hooks executed by the same function/command. >> In addition, `org-kill-line' acts specially in certain scenarios: >> >> For >> * Heading text :tag1:tag2: >> >> `org-kill-line' will keep and re-align ":tag1:tag2:": >> >> * Heading :tag1:tag2: >> >> It would be nice if we could express such behavior without overriding >> the `kill-line' command. > > This could be handled by a suitable extension to end-of-visible-line. > For example, introduce a new text property which end-of-visible-line > would then handle the same as it currently handles invisible text. I am not sure if I like the idea of text property - marking all the tags in buffer with text property is expensive. What about something like `end-of-visible-line-function'? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 8EPXML44+GRJzgAA9RJhRA:P1 (envelope-from ) for ; Wed, 06 Sep 2023 10:30:54 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 8EPXML44+GRJzgAA9RJhRA (envelope-from ) for ; Wed, 06 Sep 2023 10:30:54 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B1B7036025 for ; Wed, 6 Sep 2023 10:30:54 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=XGg8ANTu; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693989054; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=NUP15CRJABu4pqFo+whJKRyMc2MS5YrhHg5RnzGicpI=; b=p8UpUNABC5L6ugxFWSgLdzr3LYdODc0Ya79eTENmmxGMC0sITIClut1bI0ePWd4hNTefls CQk9GTzbsedBUjMMvit+mvVW3z8OLhbw/eeLjZMKnbsyv7PCO4uhb0+VppCDUzAFueByNM HyYnppoEHwMcaAMAPkQ5WgqDfZXfJ6UnZD7nLH5o4mi7AgtOoE0n6KFrzj0vctOJuENQ/R tG/p7itKBIJb/Thlknukk0PZDVJO76pr6PE74L55vbRTRjizusXY3mnXFajh87ElpICvqi bIlSFZs85OiWkHv7KiOZFoyLp3VvRkvy5fhul9Ka50wywe6DnIY6l6aJFyqQlw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693989054; a=rsa-sha256; cv=none; b=rb4NTO5UPjyIn4zWfK/Akpz3AwsWOcxEgbFhJqP30ucL2AdOEh/UuXD+b2kg/0xLDYKJdz 8Q6CiHtMjIkOh/cBrmXPCsBF0wj+gPP9m3z5NWo7A6JbTGjDzxGM7bwOVon+0N/1Ez6YGN 176K+kJzjn2Bzo3VyuCRrbGA8FU5qJk6UIkeHUgCrX+HTAz4XTe4SJeftRPewBmLlYIK6O kGkucC/Tdg4HE4ogtDKlexXvhPAgnjZqtGMenOoq3rZg9JdK3/9GX+t5ttsPUFEWYlxg8R 2MapCS01vU4xF6U4ZhIEe95R94kpIUOd3LTXF1Mdk/Aut1TsNBFMq3LhXGUZew== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=XGg8ANTu; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdnvF-0004xk-Js; Wed, 06 Sep 2023 04:30:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdnvC-0004ww-H4 for emacs-orgmode@gnu.org; Wed, 06 Sep 2023 04:29:58 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdnv2-0004td-9d for emacs-orgmode@gnu.org; Wed, 06 Sep 2023 04:29:58 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id DC067240104 for ; Wed, 6 Sep 2023 10:29:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693988985; bh=p5OcqwWSVZV3xyQtHDBgwpktUY+5M1SqLnsTCvK1uG8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=XGg8ANTuxbYaTUEfTr7D8D1mP0FFunqZbQTkVZMY3fxxy7SrPByTIbKYCC5w17AcR e2zG1G7jyx5uJHJpZn5OCRomjVsgmkOFczhoAxeMBIQMi9guhgI9SKKL7EHuLrcvU8 M01Y8pLbAblQKLFKFXt0qOFCFXAE2mG9aaUrK/+S2DANGqdDdIYN0c6ckqiKOWN7s2 9AIJu/D5iaUl1B5y2QupIcJLPxkpPzYt/cbvlQenTgASBHlxRRZNVX5vhqpXjSFTt9 o5NAreKil/fFzAYIvnuoXcsdKYqAJS7iTFrPsywQ+9/d8BXlS1KcHNS86MtnV7dAVz dWtH7ryLSnEcw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RgbCF2vhmz9rxS; Wed, 6 Sep 2023 10:29:45 +0200 (CEST) From: Ihor Radchenko To: Eli Zaretskii Cc: iota@whxvd.name, 65734@debbugs.gnu.org, emacs-orgmode@gnu.org Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] In-Reply-To: <83h6o84yz1.fsf@gnu.org> References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@gnu.org> Date: Wed, 06 Sep 2023 08:30:36 +0000 Message-ID: <87ledju2j7.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Spam-Score: -7.88 X-Migadu-Queue-Id: B1B7036025 X-Migadu-Spam-Score: -7.88 X-TUID: CwSjAOKlE2eY Eli Zaretskii writes: >> It would also make sense to group the two edits together via >> `combine-after-change-calls', although a more universal way to know that >> certain edits are a part of the same known command (even when called >> non-interactively) would be useful. > > The command kills in two parts for a good reason, which is explained > in the comments to the code. So making a single group will not work, > I think, at least not in all situations. I think there is misunderstanding. `combine-after-change-calls' will not affect the two-step modification of the kill ring, if we put it around `kill-whole-line'. Or do I miss something? > ... And relying on after-change > hooks to fix this use case sounds too obscure and fragile to me. Indeed. I did not talk about this particular bug report. What I meant is some way to group change hooks executed by the same function/command. >> In addition, `org-kill-line' acts specially in certain scenarios: >> >> For >> * Heading text :tag1:tag2: >> >> `org-kill-line' will keep and re-align ":tag1:tag2:": >> >> * Heading :tag1:tag2: >> >> It would be nice if we could express such behavior without overriding >> the `kill-line' command. > > This could be handled by a suitable extension to end-of-visible-line. > For example, introduce a new text property which end-of-visible-line > would then handle the same as it currently handles invisible text. I am not sure if I like the idea of text property - marking all the tags in buffer with text property is expensive. What about something like `end-of-visible-line-function'? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at