From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Danny Freeman Newsgroups: gmane.emacs.devel Subject: Re: Treesit Regression In ec4d29c4494f32acf0ff7c5632a1d951d957f084 Date: Mon, 11 Sep 2023 23:49:15 -0400 Message-ID: <87ledc2gki.fsf@dfreeman.email> References: <87r0n7dt34.fsf@dfreeman.email> <68CFCC60-F71F-41E3-AF2A-E78E00EB3FD2@gmail.com> <8734zm4qin.fsf@dfreeman.email> <107166BF-6EC2-4D13-9BA4-A6C0DE1CA565@gmail.com> <945F818F-AA9B-402B-BCC7-53286EAD2C05@gmail.com> <87o7i898af.fsf@dfreeman.email> <6182FD48-B83E-4C5D-85A5-946DB5408DC7@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13005"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 12 05:54:11 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfuTa-0003BA-BV for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Sep 2023 05:54:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfuSl-00051U-9o; Mon, 11 Sep 2023 23:53:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfuSi-00051F-9E for emacs-devel@gnu.org; Mon, 11 Sep 2023 23:53:17 -0400 Original-Received: from out-221.mta1.migadu.com ([95.215.58.221]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfuSd-0004Ij-QZ for emacs-devel@gnu.org; Mon, 11 Sep 2023 23:53:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dfreeman.email; s=key1; t=1694490787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DeTvPvrjL21kNqLa941qxHyOU8+oJ985B6hq4lAZhE8=; b=K74cA1xAYqZSoqdMrVRRb0heJr71jDrVfJUldj29MWefNixaWyexRBnr9Mc9qDFOjF5Mhu gL0IOc1ZNLyLFLO9tn2/PjNy7yQSDIJT7vAZJ3359E9AHBxrZxL5vpp/RgvuXB6q4Qlj0X 6EwfC/skXu9yHIcqOwLCohGR048OsuU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <6182FD48-B83E-4C5D-85A5-946DB5408DC7@gmail.com> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=95.215.58.221; envelope-from=danny@dfreeman.email; helo=out-221.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310498 Archived-At: Yuan Fu writes: > Duh, I can=E2=80=99t believe I completely forgot about this. Yes, this is= exactly it, thank you for binging > it up. Before tree-sitter can fix treesit_cursor_first_child_for_byte, I= =E2=80=99ll just replicate the > workaround and we should be golden. I=E2=80=99ve pushed a fix to emacs-29= . Once master pulls from emacs-29, > the problem should go away. It took me a minute to connect the dots there, but that did seem to be the cause. I just tried it against Emacs 30 with the commit in question cherry picked and it works perfectly. Thank you for fixing it. > BTW, I should=E2=80=99ve opened a bug report and move the discussion ther= e. But since we are mostly done here, and there=E2=80=99s another bug repor= t to refer to, there=E2=80=99s no need to do that now. Understood. I probably should have started with a bug report but for some reason sent my initial email to emacs-devel. I'll be better about that next time I run into something in the core. Thanks again for your help, all the best. --=20 Danny Freeman