From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg Newsgroups: gmane.emacs.devel Subject: Re: Emacs Lisp Linter fail to identify function defined in a "use-package" block Date: Fri, 13 Oct 2023 05:33:19 +0200 Message-ID: <87lec76vsw.fsf@dataswamp.org> References: <87il7c8le4.fsf@dataswamp.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36096"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:MMrybV0O/pQE+ofsqs7ngBB+TFI= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 13 07:31:22 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qrAld-0009BJ-1N for ged-emacs-devel@m.gmane-mx.org; Fri, 13 Oct 2023 07:31:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrAks-0002qp-IH; Fri, 13 Oct 2023 01:30:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qr8vd-0001m3-Oy for emacs-devel@gnu.org; Thu, 12 Oct 2023 23:33:33 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qr8va-0000jy-S7 for emacs-devel@gnu.org; Thu, 12 Oct 2023 23:33:33 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qr8vZ-0001Lu-1L for emacs-devel@gnu.org; Fri, 13 Oct 2023 05:33:29 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 13 Oct 2023 01:30:30 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311424 Archived-At: I have now used elint on all my Elisp, totalling 196 files and 10 907 sloc. The problems with elint, using `elint-current-buffer', are: - &rest arguments - `pcase' - `pcase-let' - lexical `let'-closures The problems with vanilla Emacs source files, that are brought to our attention thanks to elint, are: - they do not `provide' (e.g. startup.el) - they provide incorrectly (float-sup.el) - they don't use provide good enough (dired.el) Of these problems, the byte-compiler, which is also a de facto Elisp linter, only has the problem with lexical let-closures. That particular problem can be remedied with `declare-function' - but shouldn't have to be, and that method doesn't work for elint. The problem with vanilla Emacs sources files are not reported by the byte-compiler. -- underground experts united https://dataswamp.org/~incal