From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items Date: Sun, 29 Oct 2023 18:18:16 +0800 Message-ID: <87leblwx3r.fsf@yahoo.com> References: <87zg4d56l8.fsf@ledu-giraud.fr> <87wmvzkjaw.fsf@ledu-giraud.fr> <87wmvzc2qq.fsf@yahoo.com> <87sf6nn4km.fsf@ledu-giraud.fr> <87o7hbn3mo.fsf@ledu-giraud.fr> <87r0lo2s8a.fsf@ledu-giraud.fr> <874jik46cs.fsf@yahoo.com> <87mswc2q70.fsf@ledu-giraud.fr> <87zg0c2pua.fsf@yahoo.com> <87il702nfo.fsf@ledu-giraud.fr> <87v8b02mae.fsf@yahoo.com> <87a5sc2lh4.fsf@ledu-giraud.fr> <87mswc2lb1.fsf@yahoo.com> <875y302km0.fsf@ledu-giraud.fr> <87il702jnk.fsf@yahoo.com> <871qdo2i6j.fsf@ledu-giraud.fr> <87wmv8qyc4.fsf@ledu-giraud.fr> <87o7gkxytr.fsf@yahoo.com> <83ttqce4k6.fsf@gnu.org> <87y1fnwc4j.fsf@yahoo.com> <87sf5tyf5w.fsf@ledu-giraud.fr> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38973"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , stefankangas@gmail.com, 64440-done@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 29 11:19:43 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qx2tT-0009x1-35 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Oct 2023 11:19:43 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qx2tH-0000pa-8i; Sun, 29 Oct 2023 06:19:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qx2tF-0000p4-Qd for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 06:19:29 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qx2tF-0004iD-Ik for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 06:19:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qx2tl-0002tq-Ij for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 06:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Oct 2023 10:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64440-done@debbugs.gnu.org id=D64440.169857475011071 (code D ref 64440); Sun, 29 Oct 2023 10:20:01 +0000 Original-Received: (at 64440-done) by debbugs.gnu.org; 29 Oct 2023 10:19:10 +0000 Original-Received: from localhost ([127.0.0.1]:40403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx2sv-0002sU-RI for submit@debbugs.gnu.org; Sun, 29 Oct 2023 06:19:10 -0400 Original-Received: from sonic303-21.consmr.mail.ne1.yahoo.com ([66.163.188.147]:44535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx2sr-0002rn-8O for 64440-done@debbugs.gnu.org; Sun, 29 Oct 2023 06:19:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1698574706; bh=s9O+ntEYSDf/ruvoOQMZWBIS0CwUyA/hU9nbcWDXfpA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=r0n2DlGSSHvRBUNDKAvxe+1FLH0r03rvO/QhtJosJraYyrhNZg/YTMjwAdDtMrl65oYLIdFcM8aADrxZZNul/VRfdlJUYsUTt4NT2PmAjIyQOzCmHUvivLNEbHH74IjUij+2ajnO/6BSjRklnrFj34HjA0AlbRK1lhLVQmMgVT2GFhHb8MYnyv01V/NCyQkOEkMTjrxi08cZsfWV//oGy6QdlBZXsvUsWByC8LhH8BAelH2LefeUYjFUJLA7NKF98BTxJX45GASY/S+uOB6moQkEgzn3wbsyI8gUKrzQM11QezDSSf0p1wAgPQLheNkWLUgjcUY7Noe2ZvuNO6Hurw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1698574706; bh=PnpcwEKij31hzHd2a7fsiqR66ZbWGRYG3EPFY1J5NZ2=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=IHZB47ryG9ffbx2HeWMwl5SQ0gZaT4ASdEwkDc2rdGY7wLhL/iZT52lD8uhbkYHor48oIP23CATpbd8Ppwmn4D30XbsG4omnFLWKJihO+uw6dPhBNFCWrXmmz2xbqCfG+yDZrR0snY8cEU3HGcrBpWZlb85S2rMRzxaLN7lslslqz0XthVwsUAV9hhUObRHlA4yD1VTKPrnefn0Bif3YDXHZ88If9EAp62Lx8C8X+Y5xnVRbFUEFNFhvBv3Ucdlms6V6p0PPwYdionakwrFz6u9ZMYhOeC2WM7CUtFirXKXNMSqOGfy2Ee+5LH9KeogH4iSKklMQ7/NN/mcFEzGz6A== X-YMail-OSG: FhF57EMVM1lir3vqUtON7rIPwoJJRjTohFBTCxaMK8I_EvH.nGmu0AsuU6oHkCB k.p.MM.136Kiig3Q.LL9RmlifP2rfwiJ2CouBfkNggxAarKxbRc4Z79hLwodr8MbhdV0T_zU6j5m p._BDNFeCkwpf7jrYm6mWG7WIBiZlHmDLRRzEZq.0JqLpFMZ8_BwFgTBktp4cYU18hLeCMPDqaL_ Vv4mwzQwxTOJDUelgHMyrU8rJgbeUunxsqYRLSUFSBsoJZ84mGA.uZ3L6QAy9BrdXaodo3rjLzCS LiefdDrCZpEr1JEQtp0V2EKTqA8czRxQVEkmBK2vSxOfv8dV92M4fHeYs93dubAslhY9E_PVOz4. fNrlAxq9MUXCaM1tuzvXDIz_5PM1P_AmdHRcUXqpbAsgfaVvmaeJei6cqhlIIKQukj2bUsKU4Yw4 b62nhctYgwNetm32qeVlcduIkD5DcYpeO7lB3EeJ0gzAq5qBwK0IVW3nUtQuIQksi3K3QaRGzaqi 8YF2Hm4Z7HJzmTuHj00gjFUUHFRZjLTBN9GCyd9WqiDZp0CcLI5bzo.U7jHH4SQZwYdmtd17vKiR PTUKuMNCEGzcrZvV5ZTc5oWTTfdUFMyxmbTbf5pLMsq.fS6rZyvZZ6RbXjOZI1VB7xLmJmnpfEdI MCYFB6OjUTeSElmwhfx8VNbO_wZYJ73MR48VnircBnct36AYW8nvieb4GqM3v5sw2yASyYfmPt_F a4cvHmSL2AxyOCvNDaGPf4x2jq4a_dBLOdRchX9BqgVBGTJMSkwDGfe162n65lzu1GFd.E3usTTH p0R9u.SE2UDW.e3yaI5e1LuX_f5SN6n5nn2qN_ZZKl X-Sonic-MF: X-Sonic-ID: 98c40ed6-c25d-4fd4-bf35-9e00721ec804 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ne1.yahoo.com with HTTP; Sun, 29 Oct 2023 10:18:26 +0000 Original-Received: by hermes--production-sg3-8696d769c6-gk9xn (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 8ac3f7e941958cb499e1f7efb41fda86; Sun, 29 Oct 2023 10:18:20 +0000 (UTC) In-Reply-To: <87sf5tyf5w.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Sun, 29 Oct 2023 10:02:51 +0100") X-Mailer: WebService/1.1.21890 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273487 Archived-At: Manuel Giraud writes: > Po Lu writes: > >> Now done, and thanks. > > Thanks Po. But could you also commit this one. It is the one and only > usage for all those changes. It is used to set cursor as an arrow. > Thanks. > >>>From 9200d69b49fa57269e5357383d138872a372127a Mon Sep 17 00:00:00 2001 > From: Manuel Giraud > Date: Fri, 6 Oct 2023 14:27:02 +0200 > Subject: [PATCH 2/2] Set non-text mouse cursor on menu bar > > * src/xdisp.c (note_mouse_highlight): Set non-text mouse cursor on > menu bar. > --- > src/xdisp.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/src/xdisp.c b/src/xdisp.c > index 7f9e62f05e8..df3076cf499 100644 > --- a/src/xdisp.c > +++ b/src/xdisp.c > @@ -35537,6 +35537,16 @@ note_mouse_highlight (struct frame *f, int x, int y) > w = XWINDOW (window); > frame_to_window_pixel_xy (w, &x, &y); > > +#if defined (HAVE_WINDOW_SYSTEM) && ! defined (HAVE_EXT_MENU_BAR) > + /* Handle menu-bar window differently since it doesn't display a > + buffer. */ > + if (EQ (window, f->menu_bar_window)) > + { > + cursor = FRAME_OUTPUT_DATA (f)->nontext_cursor; > + goto set_cursor; > + } > +#endif > + > #if defined (HAVE_WINDOW_SYSTEM) > /* Handle tab-bar window differently since it doesn't display a > buffer. */ > -- > 2.40.0 Now done, thanks.