From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: dired-duplicates Date: Wed, 01 Nov 2023 17:57:40 +0000 Message-ID: <87lebhz78r.fsf@posteo.net> References: <875y2nugm8.fsf@posteo.net> <83edha9mlg.fsf@gnu.org> <87h6m5shpf.fsf@gmail.com> <831qd9a7gg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27411"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Visuwesh , h.judt@gmx.at, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 01 18:58:45 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qyFUK-0006th-PU for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Nov 2023 18:58:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qyFTS-0002fl-9o; Wed, 01 Nov 2023 13:57:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qyFTQ-0002fX-3N for emacs-devel@gnu.org; Wed, 01 Nov 2023 13:57:48 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qyFTO-0007pA-4B for emacs-devel@gnu.org; Wed, 01 Nov 2023 13:57:47 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 502E9240101 for ; Wed, 1 Nov 2023 18:57:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1698861463; bh=Nm2dgPwL9wg6Sj7jXxsFyFTZRjbVyxvDYsAUQlj+vos=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=YbXGdwnANL3lwsXsLV0vsb8yG/ZBOITRRgLlNasbt9nSyL20a4OyjavxTgf03l431 Jq1t4uDw+jSEem8Z+OfecgA+t/Tm7vjeibD6GHGps/GOkHH6k628cV5ZMX2hPCMUaH PiBw6ewWvkNenNLTEqDkXjRY3DuiJNWxU2k+4FUgNFKqPN214R8rfjoa1xYG5nz/hA c9zMIg80d7da5F1xPGH2cu2NrGtfWE26JwsCAvABtQA6YXpFVNt8UMY+Bcyfs3RsAW De2y2iTLGzZO8gw0/z4EVSJRWsH3kHv4Psi/A4Fn7TrqywGlvZ3BspZYE648R1jGZj a7RNPmmrOeKRg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SLF8k1WXsz6twx; Wed, 1 Nov 2023 18:57:42 +0100 (CET) In-Reply-To: <831qd9a7gg.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 01 Nov 2023 16:12:15 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312081 Archived-At: Eli Zaretskii writes: >> From: Visuwesh >> Cc: Philip Kaludercic , h.judt@gmx.at, >> emacs-devel@gnu.org >> Date: Wed, 01 Nov 2023 19:23:32 +0530 >>=20 >> [=E0=AE=AA=E0=AF=81=E0=AE=A4=E0=AE=A9=E0=AF=8D =E0=AE=A8=E0=AE=B5=E0=AE= =AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D 01, 2023] Eli Zaretskii wrote: >>=20 >> >> From: Philip Kaludercic >> >> Cc: emacs-devel@gnu.org >> >> Date: Tue, 31 Oct 2023 12:21:51 +0000 >> >>=20 >> > What I would like to ask is whether Harald tried to calculate SHA256 >> > using Emacs's own primitives, instead of relying on an external >> > program, which may or may not be installed. >>=20 >> >From OP, >>=20 >> The only external requirement is a checksum program like md5 or >> sha256sum that generates a hash value from the contents of a file us= ed >> for comparison, because Emacs cannot do that in a performance-effici= ent >> way. >>=20 >> So I guess the answer is no. > > I'd like to see the numbers which led to the conclusion that > performance was prohibitive. > > And even if the performance is indeed much worse, it could be a > fallback in case the program is not available -- which would IMO be > much better than simply failing to provide the functionality in that > case. This is a cheap test on a 1.4GB ISO I had lying around: --8<---------------cut here---------------start------------->8--- (benchmark-run 1 (with-temp-buffer (insert-file-contents-literally "~/Downloads/haiku-r1beta4-x86_64-anybo= ot.iso") (secure-hash 'sha512 (current-buffer)))) ;; (44.389091035 1 1.5836082630000021) (benchmark-run 1 (with-temp-buffer (call-process "sha512sum" nil t nil (expand-file-name "~/Downloads/haik= u-r1beta4-x86_64-anyboot.iso")) (goto-char (point-min)) (and (looking-at (rx bos (+ alnum))) (match-string 0)))) ;; (5.155846791 0 0.0) --8<---------------cut here---------------end--------------->8---