From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.orgmode,gmane.emacs.devel Subject: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point) Date: Mon, 06 Nov 2023 20:11:37 +0000 Message-ID: <87leba3ame.fsf@localhost> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38174"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-orgmode@gnu.org To: Jim Porter , emacs-devel@gnu.org Original-X-From: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Mon Nov 06 21:10:28 2023 Return-path: Envelope-to: geo-emacs-orgmode@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r05vY-0009jD-Bf for geo-emacs-orgmode@m.gmane-mx.org; Mon, 06 Nov 2023 21:10:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r05v1-0003Ba-34; Mon, 06 Nov 2023 15:09:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r05v0-0003BI-6k for emacs-orgmode@gnu.org; Mon, 06 Nov 2023 15:09:54 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r05ux-0001Ea-RR for emacs-orgmode@gnu.org; Mon, 06 Nov 2023 15:09:53 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 932EE240027 for ; Mon, 6 Nov 2023 21:09:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1699301389; bh=L0P5hsrcUbzIvYq02Di+IQwQvudwh2+7NoiPKNPGXGM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=IQReq3BqYyxFAbqpZ/hLVi7exg4yhS3UJ7nI8hZVgbEfZcT3gPACKiNzxL9urskt2 E8KfRn3lB8utOfEUgKZ9OPJYe7+V+KtDXIWEqd+J/JuzWPj+LBFwGmg0K6luHmcrWB g0724ryESxZWj3/M9+K0vaSiOHW0ndJLS+Qcr0h/H94QDpVIDI5TojII+GnkZc40f8 9T5sxmuEJqm2C+32YR9WAJsMVdA9k5/makarAnStagAn61XvCeuWQTq1zDPaUg8heo JIU6STHshKZKSBSg7IVGBo+fQuWLe4aGqRy9mXyC2VbsUjwaE7IXBBj6j+frLNBa9l LxeuMIr1ijmbA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SPMrs0mRRz6tx0; Mon, 6 Nov 2023 21:09:49 +0100 (CET) In-Reply-To: Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Original-Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.orgmode:158114 gmane.emacs.devel:312277 Archived-At: [ Branching to emacs-devel for further input from Emacs devs ] Jim Porter writes: > This is similar to Emacs bug#66752[1]. It would be nice if > "(thing-at-point 'url)" would return the URL when point is over an Org > link. With this, it's easier to write a function that copies (or browses > to) the URL at point without coding so many special cases. > ... > +(defun org--url-at-point () > + "`thing-at-point' provider function." > + (org-element-property :raw-link (org-element-context))) Supporting thingatpt.el is certainly welcome. However, I have some doubts about how mature thingatpt.el is. In particular, I am concerned whether `thing-at-point-provider-alist' is reliable enough in non-trivial scenarios like when given URL string is not matching some generic URL regexp. Looking into the source code of `bounds-of-thing-at-point', I see that for standard "things" (like url), `thing-at-point-bounds-of-url-at-point' is used unconditionally. In the case of Org links, we may have something like [[https://orgmode.org]] that will not match default URL regexp as is. AFAIU, there is no documented way to customize the behaviour of `bounds-of-thing-at-point' and `forward-thing'. I also have concerns about Org-specific part of the patch, but the above is far more important, and we need to discuss it before starting to consider anything for Org mode. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at