From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#67807: 30.0.50; interactive tagging doesn't work for dired-{next,previous}-line Date: Wed, 13 Dec 2023 10:21:02 +0530 Message-ID: <87le9yso21.fsf@gmail.com> References: <874jgm22pg.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24136"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 67807@debbugs.gnu.org To: Brian Leung Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 13 05:52:05 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rDHE4-00067L-Ss for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Dec 2023 05:52:04 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rDHDr-000816-8a; Tue, 12 Dec 2023 23:51:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDHDm-00080s-Jj for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2023 23:51:47 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rDHDm-00060h-C3 for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2023 23:51:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rDHE1-0005hm-V0 for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2023 23:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Dec 2023 04:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67807 X-GNU-PR-Package: emacs Original-Received: via spool by 67807-submit@debbugs.gnu.org id=B67807.170244309121892 (code B ref 67807); Wed, 13 Dec 2023 04:52:01 +0000 Original-Received: (at 67807) by debbugs.gnu.org; 13 Dec 2023 04:51:31 +0000 Original-Received: from localhost ([127.0.0.1]:58053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDHDX-0005h1-DD for submit@debbugs.gnu.org; Tue, 12 Dec 2023 23:51:31 -0500 Original-Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]:56391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDHDW-0005gn-II for 67807@debbugs.gnu.org; Tue, 12 Dec 2023 23:51:30 -0500 Original-Received: by mail-ot1-x342.google.com with SMTP id 46e09a7af769-6d9f7af8918so3596361a34.0 for <67807@debbugs.gnu.org>; Tue, 12 Dec 2023 20:51:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702443069; x=1703047869; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=zhCva6uSCkRDDIrhWh66+BycEZsGLAVfGFTzGdzF2M8=; b=ZwcHJEDiNJGwaIQRm+bjnS9gcThtv6GN6LwD7fCZWfIrxmQltsaXK86Ar1Zgo9/7SN EZUIKPJSbZWIfBgrb3inKqMkgmKg8ovC7JFw+wOFsTDyl6WAODDa7u/M00cts3Zdy23U 2hQxsj1MzxCVySo+7f5wrtAmCTPED3U/pkf5/H7whUYRenHvxLNSwuVwKryL/M6jdooE 97+Cnxze3vC9Mmcsbzvj8atzHCNZ1gzs00K3K16mRDpsRhsv7UtWHerT+5KIl3XtxShn f98x6PGFn0vy87ZOSB4vCOWknyovKwY/6ZjtAvDWgsPAWASCJLtVqcZqVQsWN8ZuIYbj U88A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702443069; x=1703047869; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zhCva6uSCkRDDIrhWh66+BycEZsGLAVfGFTzGdzF2M8=; b=qnug6eFocwuQZ7/VhtI5JTyWiIudtFH6//IkMdw46ilCKT6PEkasvxaep36JwTjak9 qSrCL6KpEcUqiMfP0nmGiEGyaUuADl990kOH2lszUtQGSyVyi8GcZgCdtf1IO913ZpLT 8VSxvqab1bER1y5TXNTPciRt8EnJF40S2qnaYN7n2QQrr244xfnxLi9aCRFnr+juqEJC tva1DWAVxi+mIles9BW/owifCvxleOhT5C4ewQO7Z4RZb1DZidj65T+eLJgT5/lPvRUQ fi+kzwv34Q1XKjI4ZbA7qRwQj7+h2ryGR/hrG2ZjBwI9PvNpg2QMXbpnD+LTZOLyE+he ciLA== X-Gm-Message-State: AOJu0YxWqfHZNlfS8G3HnvZ/7fN0iiyNdAahBrKIeHktodME/ewcpdTy wBotqFpP5nrRQZeR0xDpD/2OwKxpsujvcZog X-Google-Smtp-Source: AGHT+IHasLkaED95rQr//OVJYdBJIpNjeBjSL7eis9fYkSQWwTMLBw9gOxYO/pRXfYS2Y7DY1qowUQ== X-Received: by 2002:a05:6830:1107:b0:6d9:f66e:f557 with SMTP id w7-20020a056830110700b006d9f66ef557mr7183677otq.8.1702443068796; Tue, 12 Dec 2023 20:51:08 -0800 (PST) Original-Received: from localhost ([49.204.139.22]) by smtp.gmail.com with ESMTPSA id o17-20020a656151000000b005c2420fb198sm7798015pgv.37.2023.12.12.20.51.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 20:51:08 -0800 (PST) In-Reply-To: <874jgm22pg.fsf@posteo.net> (Brian Leung's message of "Wed, 13 Dec 2023 03:32:38 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276110 Archived-At: [Wednesday December 13, 2023] Brian Leung wrote: > Repro: > > 1. emacs -q > 2. M-: (require 'dired) > 3. In a non-dired buffer, type M-x dired-next-l TAB. Note that it > autocompletes to dired-next-line in spite of the apparent interactive > tagging added in 1c70458519b324c9403e8a9f57bd695fe39e8d2c. Is there a step that you're missing here? M-x completes all commands unless you set read-extended-command-predicate to a non-nil value, I set it to command-completion-default-include-p. How about other commands such as eww? Do they show up for you in M-x? M-X OTOH is supposed to only show commands that are relevant to the current buffer. > I find that I have to explicitly write > >> (defun dired--command-p (_sym buffer) >> "Return non-nil if BUFFER is in `dired-mode'." >> (with-current-buffer buffer >> (eq major-mode 'dired-mode))) >> >> (put 'dired-previous-line 'completion-predicate #'dired--command-p) >> (put 'dired-next-line 'completion-predicate #'dired--command-p) > > to get the completion-exclusion to work properly. > >