From: Visuwesh <visuweshm@gmail.com>
To: Brian Leung <leungbk@posteo.net>
Cc: 67807@debbugs.gnu.org
Subject: bug#67807: 30.0.50; interactive tagging doesn't work for dired-{next,previous}-line
Date: Wed, 13 Dec 2023 10:21:02 +0530 [thread overview]
Message-ID: <87le9yso21.fsf@gmail.com> (raw)
In-Reply-To: <874jgm22pg.fsf@posteo.net> (Brian Leung's message of "Wed, 13 Dec 2023 03:32:38 +0000")
[Wednesday December 13, 2023] Brian Leung wrote:
> Repro:
>
> 1. emacs -q
> 2. M-: (require 'dired)
> 3. In a non-dired buffer, type M-x dired-next-l TAB. Note that it
> autocompletes to dired-next-line in spite of the apparent interactive
> tagging added in 1c70458519b324c9403e8a9f57bd695fe39e8d2c.
Is there a step that you're missing here? M-x completes all commands
unless you set read-extended-command-predicate to a non-nil value, I set
it to command-completion-default-include-p. How about other commands
such as eww? Do they show up for you in M-x?
M-X OTOH is supposed to only show commands that are relevant to the
current buffer.
> I find that I have to explicitly write
>
>> (defun dired--command-p (_sym buffer)
>> "Return non-nil if BUFFER is in `dired-mode'."
>> (with-current-buffer buffer
>> (eq major-mode 'dired-mode)))
>>
>> (put 'dired-previous-line 'completion-predicate #'dired--command-p)
>> (put 'dired-next-line 'completion-predicate #'dired--command-p)
>
> to get the completion-exclusion to work properly.
>
>
next prev parent reply other threads:[~2023-12-13 4:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 3:32 bug#67807: 30.0.50; interactive tagging doesn't work for dired-{next,previous}-line Brian Leung
2023-12-13 4:51 ` Visuwesh [this message]
2023-12-13 5:49 ` Brian Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le9yso21.fsf@gmail.com \
--to=visuweshm@gmail.com \
--cc=67807@debbugs.gnu.org \
--cc=leungbk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.