From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#69079: [PATCH] Add 'customize-toggle-option' command Date: Mon, 12 Feb 2024 18:56:39 +0000 Message-ID: <87le7p1pg8.fsf@posteo.net> References: <87frxx37wq.fsf@posteo.net> <86plx1r2uq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5518"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69079@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 12 20:11:00 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZbhk-0001FD-Ag for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Feb 2024 20:11:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZbhb-00046e-NB; Mon, 12 Feb 2024 14:10:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZbhX-00046G-MR for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 14:10:47 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZbhV-0002Xi-W0 for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 14:10:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZbhm-0003D4-SS for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 14:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Feb 2024 19:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69079 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69079-submit@debbugs.gnu.org id=B69079.170776502312151 (code B ref 69079); Mon, 12 Feb 2024 19:11:02 +0000 Original-Received: (at 69079) by debbugs.gnu.org; 12 Feb 2024 19:10:23 +0000 Original-Received: from localhost ([127.0.0.1]:50780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZbh7-00039l-H3 for submit@debbugs.gnu.org; Mon, 12 Feb 2024 14:10:23 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:57495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZbUF-00028j-8R for 69079@debbugs.gnu.org; Mon, 12 Feb 2024 13:57:03 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A0EF0240105 for <69079@debbugs.gnu.org>; Mon, 12 Feb 2024 19:56:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1707764200; bh=znO1rKHOn5Q55TUMc4CJ8wUTRxutBiAdRJkNQU0CvgQ=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=sBUxcC33fxseu/TbFOSpQwfFLOZUDhKLkHwq/2TDVknla+pIzt2yLVNAtZUNAZK5c GZKdmbaysPP2Kvgn1uJ9UZO7U7N7y92fU1fpLWq+QgiSNNtidy4djaz93mih9DsIro GQ87QdM1TXCK4HELzCQWkWIKOH/1Y3fjMHD7MYhznqXMnmoBFPtcGBkIUFbTBsdwfd UNm0FKutRdZRVMTRNDvCCo09lMayQpEL5KHMPNp+P9Usgn9lJA0HEgAOeqSMasKw28 G1uRBYmjiXf6SYHx/Iu2L2vqKEGSDcYC0qTPzgqmsbXL8/DhS3+66zaTVyoZP6ssd+ UbYWM+AVYSBDQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TYYbD0Qh4z9rxD; Mon, 12 Feb 2024 19:56:39 +0100 (CET) In-Reply-To: <86plx1r2uq.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Feb 2024 19:47:57 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279920 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Date: Mon, 12 Feb 2024 17:32:37 +0000 >> >> +;;;###autoload >> +(defun customize-toggle-option (opt) >> + "Toggle the value of boolean option OPT for this session." >> + (interactive (let (opts) >> + (mapatoms >> + (lambda (sym) >> + (when (eq (get sym 'custom-type) 'boolean) >> + (push sym opts)))) >> + (list (intern (completing-read "Option: " opts))))) >> + (message "%s user options '%s'." >> + (if (funcall (or (get opt 'custom-set) #'set-default) >> + opt (not (funcall (or (get opt 'custom-get) >> + #'symbol-value) >> + opt))) >> + "Enabled" "Disabled") >> + opt)) > > Shouldn't this have some validation? what if the argument OPT is not a > boolean? My assumption was that the command would only be invoked interactivly, so I can either make that explicit with an `interactive-only' or repeat the check. What do you think would be better? > And the prompt should IMO say "Toggle boolean option: ". Good point.