From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: NonGNU ELPA: Conditions for accepting a potential new package 'rmsbolt' ? Date: Tue, 27 Feb 2024 17:21:55 +0000 Message-ID: <87le75u8jw.fsf@posteo.net> References: <87jzmsmecw.fsf@jeremybryant.net> <877cir8yap.fsf@posteo.net> <877ciqn8wg.fsf@jeremybryant.net> <87y1b6tkk1.fsf@posteo.net> <87msrleuwd.fsf@eve> <87ttltu939.fsf@posteo.net> <87il29esj9.fsf@eve> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8000"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jeremy Bryant , "emacs-devel@gnu.org" , monnier@iro.umontreal.ca To: Jay Kamat Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 27 18:22:48 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rf1AF-0001ok-Qf for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Feb 2024 18:22:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rf19Z-0006iQ-PV; Tue, 27 Feb 2024 12:22:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rf19Y-0006fU-4G for emacs-devel@gnu.org; Tue, 27 Feb 2024 12:22:04 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rf19V-00014B-LY for emacs-devel@gnu.org; Tue, 27 Feb 2024 12:22:03 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E2E51240103 for ; Tue, 27 Feb 2024 18:21:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1709054517; bh=iNoLSZLONj1aCjNd/kmYHcHR78MggP0lhdktmKlyufA=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=LJ+Ypk2UNDOFcx8icNpAq5xioVmFhhLUEJSCIN5/DBYl7u2dgP4U1no5ZpirZv71Y UxQRBvCUK/L9amG0+bez/CUX+vKPxt8VOiaLnY/5cArWiHF00p+XBxx5/jYK8S3f6A 77Gymz7BMyEnvmnCnVl41t9R/AjasyXIu/dQrwvbYG3SN/gjnAUAfoSgfB4I9S1tbj hUY1crSrHqTcpzyLrJH0xLudzSqtwPdbvpFffioIJnfvBf1fzdaOKuLDw2RGLQRwW2 8UM9fJKHtE7/ktP1p6EeZwapFUAgoNDJEn+wYGKU1KGDMxv/rx95Da1IdzazUp6UMI DUloaTcF0hnKg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Tkkn10HcJz9rxP; Tue, 27 Feb 2024 18:21:56 +0100 (CET) In-Reply-To: <87il29esj9.fsf@eve> (Jay Kamat's message of "Tue, 27 Feb 2024 09:14:05 -0800") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316594 Archived-At: Jay Kamat writes: > Philip Kaludercic writes: > >> Jay Kamat writes: >> >>> Philip Kaludercic writes: >>> >>> Might take me a while to fully review and test all the changes, but >>> they look good, so once I do so, I'll include them! >>> >>>> +(defcustom rmsbolt-mode-lighter " RMS=F0=9F=97=B2" ;could the unicode >>>> charachter be removed? it can unnecessarily resize the mode line. >>> >>> Sure - I can remove it. I'll do it after I apply your patch generally. >> >> Just keep in mind that I didn't send a patch. I just find it convenient >> to send comments in form of a diff. > > Ah - I didn't realize. I think most of your code-changes are good, is > it alright if I apply them? I'll make a commit with you as the author > (or I can take authorship/not commit them - whatever your preference > is). Of course, I just wanted to make sure that you don't apply a comment instead of addressing it. Also, some changes might have been opinionated (I don't recall), and I wouldn't want to insinuate that you must apply them. I don't care about authorship, do as you like. >>>> >>>> ;;;;; Starter Definitions >>>> >>>> ;; IIUC, this "starter" business is not a necessary part of >>>> RMSBolt, but is >>>> ;; a way to provide sample files with which users can try out RMSBolt. >>>> >>>> -(defvar rmsbolt-starter-files >>>> +(defvar rmsbolt-starter-files ;should this be part >>>> of a secondary file that isn't loaded by default? >>> >>> Maybe - I think I would load it by default though - as this is the >>> easiest way for someone to try out the package. In my personal usage I >>> almost always start from one of these files and add my changes. I >>> should update the comment above with that information as well. >> >> It shouldn't matter, as long as the command that uses >> `rmsbolt-starter-files' remains auto-loaded, even if the command is >> not defined in the main file. > > Ah - that's true! I'll try to make this change after the others if I > have time. 1+ --=20 Philip Kaludercic on peregrine