Re: URGENT - which-key FSF contributor status

[Philip Kaludercic <philipk@posteo.net>]

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

Stefan Kangas <stefankangas@gmail.com> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> Note these two warnings from package-lint when run on which-key.el:
>>
>> 806:0: error: "evil-state" doesn't start with package's prefix "which-key".
>> 2334:10: error: `next-event' was removed in Emacs version 28.1.
>
> Did you have a chance to look into these warnings?

Sorry, I forgot to respond to your message.

> The first one seems cosmetic, but we might want to fix the second one
> (assuming that it's a valid warning).

The first one is related to evil-support  I am not familiar with the
issue to find a better solution.

The second one is not a valid warning, apparently package-lint doesn't
distinguish between function calls and variable bindings.  If we really
wanted to fix it, then


[-- Attachment #2: Type: text/plain, Size: 698 bytes --]

diff --git a/lisp/which-key.el b/lisp/which-key.el
index 1de599e5497..8a61dd0edce 100644
--- a/lisp/which-key.el
+++ b/lisp/which-key.el
@@ -2336,9 +2336,9 @@ which-key-reload-key-sequence
 `which-key--current-key-list'.  Any prefix arguments that were
 used are reapplied to the new key sequence."
   (let* ((key-seq (or key-seq (which-key--current-key-list)))
-         (next-event (mapcar (lambda (ev) (cons t ev)) key-seq)))
+         (next-evt (mapcar (lambda (ev) (cons t ev)) key-seq)))
     (setq prefix-arg current-prefix-arg
-          unread-command-events next-event)))
+          unread-command-events next-evt)))
 
 (defun which-key-turn-page (delta)
   "Show the next page of keys."

[-- Attachment #3: Type: text/plain, Size: 51 bytes --]


would do it.

-- 
	Philip Kaludercic on peregrine