Reference to non-existent variable `header-arguments-alist'

Reference to non-existent variable `header-arguments-alist'

[Stefan Kangas]

There is a reference to `header-arguments-alist', but I can't find any
such variable in the tree.

./lisp/org/ob-core.el:2517:`header-arguments-alist' see the docstring for

Re: Reference to non-existent variable `header-arguments-alist'

[Ihor Radchenko]

Stefan Kangas <stefankangas@gmail.com> writes:

> There is a reference to `header-arguments-alist', but I can't find any
> such variable in the tree.
>
> ./lisp/org/ob-core.el:2517:`header-arguments-alist' see the docstring for

It is not referring to a variable, but to ARGUMENTS slot in the INFO
list. INFO is expected to have the same format as the return value of
`org-babel-get-src-block-info'.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: Reference to non-existent variable `header-arguments-alist'

[Stefan Kangas]

Ihor Radchenko <yantar92@posteo.net> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> There is a reference to `header-arguments-alist', but I can't find any
>> such variable in the tree.
>>
>> ./lisp/org/ob-core.el:2517:`header-arguments-alist' see the docstring for
>
> It is not referring to a variable, but to ARGUMENTS slot in the INFO
> list. INFO is expected to have the same format as the return value of
> `org-babel-get-src-block-info'.

So would something like the below be appropriate?

diff --git a/lisp/org/ob-core.el b/lisp/org/ob-core.el
index 727ace84463..4b6c3b5e6bd 100644
--- a/lisp/org/ob-core.el
+++ b/lisp/org/ob-core.el
@@ -2514,8 +2514,7 @@ org-babel-insert-result
           allowed for inline source blocks.

 INFO may provide the values of these header arguments (in the
-`header-arguments-alist' see the docstring for
-`org-babel-get-src-block-info'):
+`header-arguments' alist; see `org-babel-get-src-block-info'):

 :file --- the name of the file to which output should be written.

Re: Reference to non-existent variable `header-arguments-alist'

[Ihor Radchenko]

Stefan Kangas <stefankangas@gmail.com> writes:

>>> ./lisp/org/ob-core.el:2517:`header-arguments-alist' see the docstring for
>>
>> It is not referring to a variable, but to ARGUMENTS slot in the INFO
>> list. INFO is expected to have the same format as the return value of
>> `org-babel-get-src-block-info'.
>
> So would something like the below be appropriate?
> ...
>  INFO may provide the values of these header arguments (in the
> -`header-arguments-alist' see the docstring for
> -`org-babel-get-src-block-info'):
> +`header-arguments' alist; see `org-babel-get-src-block-info'):

I do not think so.  `org-babel-get-src-block-info' is not actually
specifying that "arguments" is an alist.  And it never says "header-arguments".
Both this docstring and also `org-babel-get-src-block-info's
need to be updated.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: Reference to non-existent variable `header-arguments-alist'

[Ihor Radchenko]

Ihor Radchenko <yantar92@posteo.net> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> There is a reference to `header-arguments-alist', but I can't find any
>> such variable in the tree.
>>
>> ./lisp/org/ob-core.el:2517:`header-arguments-alist' see the docstring for
>
> It is not referring to a variable, but to ARGUMENTS slot in the INFO
> list. INFO is expected to have the same format as the return value of
> `org-babel-get-src-block-info'.

Fixed, on bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=83fe95d2e

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>