From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: bookmark+: legacy key syntax in Emacs 30? Date: Thu, 17 Oct 2024 09:34:01 +0200 Message-ID: <87ldynrxna.fsf@gmail.com> References: <87bjzqp9dv.fsf@librehacker.com> <87bjzjstsw.fsf_-_@librehacker.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2146"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Drew Adams , Emacs Devel Mailing List To: Christopher Howard Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 17 09:34:59 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t1L2A-0000OM-JP for ged-emacs-devel@m.gmane-mx.org; Thu, 17 Oct 2024 09:34:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1L1S-0000eR-8Z; Thu, 17 Oct 2024 03:34:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1L1M-0000dv-Op for emacs-devel@gnu.org; Thu, 17 Oct 2024 03:34:08 -0400 Original-Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t1L1K-0006yJ-Nz for emacs-devel@gnu.org; Thu, 17 Oct 2024 03:34:08 -0400 Original-Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-37d461162b8so396549f8f.1 for ; Thu, 17 Oct 2024 00:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729150444; x=1729755244; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=T6xu9IYCekB71fZvRlY+XXSyo0MI2TRWw/nqTHMNr+o=; b=icIVHxN+av13sXQI4OO996DgL6oqjbvybx4ZX8lkz4FS2tEXXz4BFfY/psAnBhwkC8 KZyMV2uY6VqRjgObrhwHpLBbn4kG1GU8soRG4GQ6Xck5wWx8g1eqfKK0U5e+zc90QPFq h+dNu7jkZbn9AV6iBEoU7C0OzMtz+QTAzBkCRAq3I3UtpybgpWKLuYRe2Wy4fGOx3p7J LcyZM7ejjoeRDxjkQra+9iVuUjItHnhvBtBvBobBfmpSeoePuyiGK1Pamw4WRafJ59hT O9GFddU4gBZz+SFsxc50yEAmu84pqqWCD1Vy9Fqx6qhl4sYqt9l4IiMKXxzFyfLBH527 OC7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729150444; x=1729755244; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T6xu9IYCekB71fZvRlY+XXSyo0MI2TRWw/nqTHMNr+o=; b=pVhhcjNWWIvqF1SQcmyaqMR5hITh1m9vI0xo2qEBArAidP8CctLOMWJGBvMChUEOb+ ZODVYZBjDXURuTOti9ImrnxScvlRPpMBYgGQ5L30xp8qmLmcY1DbRiJdDknINMYqQYYG Z2bhTJvOaxnGrlTglazPF057rDqWv6laiwpWXLBn+tPReKY9pLW4/pS96KL+qMtcY6FZ zbCDoDN/Xa9wY4AG5dujKsegukcxs3Xh36EXqLx5qtiSsGBYE2pTyHKXAdg0I/5ziyYn G5HhuG4HRoozu3Q5Sle21jF2bjFSUnaxUmGik4ME88XWxmB4OT9CaPukrecKBBd7h7Yb I2pg== X-Forwarded-Encrypted: i=1; AJvYcCW1dgabd0U8tl9a3KZeFDJ0KK8K2dfjI3vBrFh7T//bmOMtTFB2V5547E9RUW0Apdf/r+r6jBurejIptw==@gnu.org X-Gm-Message-State: AOJu0Yzc2P7i64Icyq+wAdM9ODzDTVPAWIPwtGPURcux0fPHP2nahXl9 czcHGwvRj+mHWwagHGVvZ/S2XBw4CB60fAqeRcRzdvBYeEj6N1s9abTfQQ== X-Google-Smtp-Source: AGHT+IEHCogVMvJXa8x/o6WtWxvZhxfnpSWlj+nSpRqMuEvObxMhzHCXXoTJZpf/JZhlrzoTZWruHA== X-Received: by 2002:a5d:4bc7:0:b0:37d:5257:41bd with SMTP id ffacd0b85a97d-37d5fe9563bmr11495109f8f.3.1729150442248; Thu, 17 Oct 2024 00:34:02 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb51:7721:68f:7d73:e6d8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d7fa7a086sm6367581f8f.24.2024.10.17.00.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 00:34:01 -0700 (PDT) In-Reply-To: <87bjzjstsw.fsf_-_@librehacker.com> (Christopher Howard's message of "Wed, 16 Oct 2024 11:59:27 -0800") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=rpluim@gmail.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324620 Archived-At: >>>>> On Wed, 16 Oct 2024 11:59:27 -0800, Christopher Howard said: Christopher> I downloaded the latest files from the wiki but am still g= etting the same error when I require 'bookmark+. Christopher> I do not know much about keymaps at this point, but the of= fending line is in bookmark+-key.el: Christopher> ``` elisp Christopher> (define-key ctl-x-map "rK" 'bmkp-set-desktop-bookmark) = ; `C-x r K' (also `C-x x K', `C-x x c K') Christopher> ``` Christopher> I see in the Emacs 30 documentation at least that define-k= ey is Christopher> considered now a legacy function, and `keymap-set' is reco= mmended Christopher> instead. Perhaps something broke in define-key from 29->30= , so that it Christopher> no longer recognizes correctly the legacy string syntax? That=CA=BCs possible, but in this case I can=CA=BCt reproduce your error. T= hat syntax is perfectly legal, and will remain so. Christopher> I'm CC'ing emacs-devel in hopes that an SME will weigh in = on this. Does this happen when you byte-compile the bookmark+ files? Or only when you use the .el files? Robert --=20