From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: john muhl Newsgroups: gmane.emacs.bugs Subject: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options Date: Thu, 14 Nov 2024 21:54:26 -0600 Message-ID: <87ldxl2lu5.fsf@pub.pink> References: <8734k4xdon.fsf@pub.pink> <87ses4vyzp.fsf@pub.pink> <86y11vr3e5.fsf@gnu.org> <87ldxtn57i.fsf@pub.pink> <86ses1oijv.fsf@gnu.org> <87ikswi0vc.fsf@pub.pink> <86r07jlk3j.fsf@gnu.org> <87y11r87qw.fsf@pub.pink> <8634jukyqt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20118"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.12.1; emacs 31.0.50 Cc: 74235-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 15 04:55:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tBnQa-00056G-FT for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Nov 2024 04:55:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tBnQI-0001CZ-Ec; Thu, 14 Nov 2024 22:55:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBnQF-0001A0-9v for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2024 22:55:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tBnQF-0001Oh-14 for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2024 22:55:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=V45WbuzJ4ARYqyEYYsMqzA/8l7t4Ik0odDOd3Z7SjLA=; b=FXTi8Z7tzyw3QhhWSQ6V0WHL0k4K8Sw3xZJE5laF/RYi3f0sbF+OY5XrLuVJ3FUttRr4kNO4k6cMDz4dzH5WhuJ8L6+ZHZzojeFwK0O41FDxSIHZIoTx1BbeV+GcKQvrYdx82jBFAMnvsZmgwAHXp5EYB0Khg86vfIo1+N9guXc9xHS7PcCoUyHdWUAMfZczTE5h94AWTRsvPC5EuuE0mfCmZyPjdkHgosYFAwtD9VSbXgBDQe6uOX7f/9AC2dvzk56jlsI+a54ur2XH1M0xBVzMiPZ/uXuVm2fbLV/OdZAfgH4HsD5iKND/98ih+RICqAfLGJi5t5Eaag0k5oMiBg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tBnQD-0004lr-Rk for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2024 22:55:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: john muhl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Nov 2024 03:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74235-done@debbugs.gnu.org id=D74235.173164287618299 (code D ref 74235); Fri, 15 Nov 2024 03:55:01 +0000 Original-Received: (at 74235-done) by debbugs.gnu.org; 15 Nov 2024 03:54:36 +0000 Original-Received: from localhost ([127.0.0.1]:48032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBnPo-0004l4-Bc for submit@debbugs.gnu.org; Thu, 14 Nov 2024 22:54:36 -0500 Original-Received: from fhigh-a2-smtp.messagingengine.com ([103.168.172.153]:55709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBnPm-0004kr-Cj for 74235-done@debbugs.gnu.org; Thu, 14 Nov 2024 22:54:35 -0500 Original-Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailfhigh.phl.internal (Postfix) with ESMTP id 8A78A1140132; Thu, 14 Nov 2024 22:54:28 -0500 (EST) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Thu, 14 Nov 2024 22:54:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1731642868; x=1731729268; bh=V45WbuzJ4ARYqyEYYsMqzA/8l7t4Ik0odDOd3Z7SjLA=; b= aW0p6J0b7weS2FSKau6voB03CbNQk8Vj1eNs3zXmsDUxL1+SKkRkwxbdZSCZDJtf X7ONuSYI5d4bLglsbzPijLJLruZZYCI4BJBYjq95/GC6akwyaiWYLHBMSdu64rrz LsJhmtpoVD9tbpYcJlZ/Rsi0qMUL1iK7werjtePS1wC0bMvIQWaA4wgCb+/6HIwt x49VPRRENVyLDq1bjx+V/vYxd5MH4LML+gBwn+tTrPOOJDjzw18uMIo1Eedu/4vP IU6cOxumckx39jMKpz3YqYM3eEqTmraLubWsspNoTvQJa5VouKrw5BwsvwrC2OHq AyuKb4iPs5trg6YxP64MgQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731642868; x= 1731729268; bh=V45WbuzJ4ARYqyEYYsMqzA/8l7t4Ik0odDOd3Z7SjLA=; b=f nlN3f3/tVA5w95DJlZxPj72k8nM20BlYZhsTtpPrM/92tvd5KNRPsxsl21lWEplN gZp1+q3sToTwKPMjDh40dRWGIOgb08p7D5mUC7wDDGXvsPD2LnkXbszlXwdboYrR pE1EFVn0ZtdpBOLQTqYvbBLwV3wg32NOvF4E2LQOc+g/7HiVUKBAqe9f2/42i/Hx tTZ8vlgWOpj/sX+/u2m47NBWb7wl14IP7Gh0+Nlq+TrRogFXESHcUX4GRvGaq9pZ 3+OKI0J82ZwoajK0TmX+U8co4h55NVOiWrIatMWcTY7OoOG1atAiHEgC63gYWK4y rhkT0z/3lJEQKvMTB1xzA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrvdefgdeivdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttderjeen ucfhrhhomhepjhhohhhnuchmuhhhlhcuoehjmhesphhusgdrphhinhhkqeenucggtffrrg htthgvrhhnpeegveehvddttedvkeduvddttdehhfdvgffgvdfgiedtjeduhefhffejtddv veevkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hjmhesphhusgdrphhinhhkpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopeejgedvfeehqdguohhnvgesuggvsggsuhhgshdrghhnuhdrohhrgh dprhgtphhtthhopegvlhhiiiesghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: i74194916:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Nov 2024 22:54:27 -0500 (EST) In-Reply-To: <8634jukyqt.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Nov 2024 10:26:02 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295377 Archived-At: Eli Zaretskii writes: >> From: john muhl >> Cc: 74235@debbugs.gnu.org >> Date: Sun, 10 Nov 2024 08:48:39 -0600 >>=20 >> Eli Zaretskii writes: >>=20 >> >> From: john muhl >> >> Cc: 74235@debbugs.gnu.org >> >> Date: Sat, 09 Nov 2024 14:54:47 -0600 >> >>=20 >> >> + (if (or (not lua-ts-inferior-program) >> >> + (not (executable-find lua-ts-inferior-program))) >> >> + (user-error "You must set `lua-ts-inferior-program' to use this >> >> command") >> > >> > The text of user-error should say something about being unable to find >> > the program, not just about the variable being nil, since you use >> > executable-find. >> > >> > Otherwise, LGTM, thanks. >>=20 >> I guess the executable-find check is redundant anyway since >> comint/process will tell you =E2=80=9CSearching for program: No such file >> or directory, luaz=E2=80=9D if you get it wrong. > > Thanks, installed on the emacs-30 branch, and closing the bug. > > Btw, I noticed that you are marking with ";" the log entries of > changes which should definitely appear in the produced ChangeLog. Is > this on purpose, or did you misunderstand the meaning of the > semi-colon in the first line of the commit log messages? Temporary (hopefully) confusion. I think I had NEWS entries on my mind and conflated the the semicolon with not needing an entry there. I should probably re-read CONTRIBUTING since it=E2=80=99s been awhile and I don=E2=80=99t contribute often enough to have it all ingrained yet. Thanks for your patience.