From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] new package: eglot-inactive-regions Date: Wed, 04 Dec 2024 22:10:54 +0000 Message-ID: <87ldwvjdzl.fsf@posteo.net> References: <874j3nrri7.fsf@posteo.net> <878qswlfty.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33854"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Gerd =?utf-8?Q?M=C3=B6llmann?= , Stefan Kangas , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Filippo Argiolas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 04 23:11:56 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIxb9-0008dx-TL for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Dec 2024 23:11:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIxaO-0002Ya-Up; Wed, 04 Dec 2024 17:11:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIxaM-0002Y6-3L for emacs-devel@gnu.org; Wed, 04 Dec 2024 17:11:06 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIxaI-0003v3-BP for emacs-devel@gnu.org; Wed, 04 Dec 2024 17:11:05 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 53F2A240103 for ; Wed, 4 Dec 2024 23:10:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1733350256; bh=UTvsdEAB3vMxdARr6v/i09prOpDv2C7OtRJTL9lxuCk=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=dKEoTUELHdxpN3DI1d/Rvsz+iQuUwfZkWt0Jk9uIVk0lfx2JTuOhxwNBesCahScjj o8doLoyFwrze2Pa3zEiBf+0TgREeAB8Iu5BKPEnuOLdxLhwm1cz0DjHZMfhrAfTCyP M2HuMcw5EX0uPoWzsxw6Fuf9J3rbgoOhOq8hbj7UGgEGam/dD/uuF8VB3/LvaLrm17 ZLbAxyRubNuGFC8w6iBF7WYkeGygOPxTOIMkAJxuMWOou8e35zexCd62uwuTCcnXwI 0ibOO13oyzTK5x+GiPpSzCSGQGP02+LCHKfea0/hy8AZP5rBvhhrqRcxPL40xUSK4g OczkLG/Cx3Q/w== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Y3Wtk73ZHz6tm8; Wed, 4 Dec 2024 23:10:54 +0100 (CET) In-Reply-To: (Filippo Argiolas's message of "Wed, 04 Dec 2024 21:59:40 +0100") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326052 Archived-At: Filippo Argiolas writes: > Filippo Argiolas writes: > >> Philip Kaludercic writes: >> >>> I would try something of the form like >>> >>> (if (fboundp 'new-function) >>> (new-function ...) >>> (old-function ...)) >>> >>> If on the other hand there has already been a new release of Eglot with >>> these commands, then just depend on that version and the issue would >>> resolve itself. >>> >> >> CC-ing Jo=C3=A3o. >> >> I pushed the suggested change but I still get the compile warnings about >> deprecated functions. I'd like to keep supporting emacs-29, should I >> just disregard the warning? >> >> Sorry for the ignorance, how would the dependency on a specific eglot >> version work now that it's in core? >> Does it require the users to have additional repos enabled? >> >> Sounds strange to me that we have macros to deprecate functions but no >> mechanism to automatically switch to the new one if it's just a >> rename. Am I missing something obvious? >> >> Thanks! >> >> Filippo > > How about something like: > > ;; fallback to deprecated eglot functions > (when (version< emacs-version "30") > (defalias 'eglot-uri-to-path 'eglot--uri-to-path) > (defalias 'eglot-range-region 'eglot--range-region)) > > or even something similar with a check on eglot version? That can be dangerous if other packages do fboundp checks and infer too much from that. I would try to see if adding `declare-function's could help suppress the warnings?