From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: New "make benchmark" target Date: Tue, 31 Dec 2024 14:14:42 +0000 Message-ID: <87ldvwndns.fsf@protonmail.com> References: <87h679kftn.fsf@protonmail.com> <86msgdnqmv.fsf@gnu.org> <87wmfhxjce.fsf@protonmail.com> <86jzbhnmzg.fsf@gnu.org> <87o70txew4.fsf@protonmail.com> <86frm5nii8.fsf@gnu.org> <87jzbgpkon.fsf@protonmail.com> <86r05om29b.fsf@gnu.org> Reply-To: Pip Cet Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19821"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , acorallo@gnu.org, mattiase@acm.org, eggert@cs.ucla.edu, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 31 15:16:03 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tSd2Q-0004wC-NI for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Dec 2024 15:16:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tSd26-0005mL-FJ; Tue, 31 Dec 2024 09:15:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSd1I-0005dO-Md for emacs-devel@gnu.org; Tue, 31 Dec 2024 09:14:52 -0500 Original-Received: from mail-40134.protonmail.ch ([185.70.40.134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSd1G-0001WL-Mn; Tue, 31 Dec 2024 09:14:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1735654487; x=1735913687; bh=C7HYUVFIVuKqqJFh0dMhg5ShMEPBHpX3eT6eR6fetDs=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=LI0uKjZhBXwlwdJgCjGb9dBbGth022IjUIwSkNed5rj7nDJ2zxbyY2KNr4SBHW0E4 Z839eEB4XwlMSDA5V9Zmt1kOrlKs3e+E4MtOlPpYAam7aevOUjGWc2OpgtQLBSr3hd s0gLkvgDBIwOMqpUNS9w/827s/PLiDMG079ArCuLcSyuSYARuhnKX/Z/yJnRaiEjxO 5YXWql/oEEbRtmbH2pqdFO9E2cujAvheIHQVaj/JJURgNOnZcnzZpnYZdznDtCkWBd w2kD+3isoT5nNqKbFYNwrP4Ydl9kHnUG346gZCIyYvSrDdletjkgQAZCcj85N2YveQ xd+12+8Y/672w== In-Reply-To: <86r05om29b.fsf@gnu.org> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: fe6143a146977f8fd6470bb7536347b8ffc3ad3c Received-SPF: pass client-ip=185.70.40.134; envelope-from=pipcet@protonmail.com; helo=mail-40134.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 31 Dec 2024 09:15:19 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327508 Archived-At: "Eli Zaretskii" writes: >> From: Stefan Kangas >> Date: Mon, 30 Dec 2024 23:26:05 -0600 >> Cc: acorallo@gnu.org, mattiase@acm.org, eggert@cs.ucla.edu, >> =09emacs-devel@gnu.org >> >> I'd put this in a directory named "benchmarks" instead. > > I think this name is indeed better. Is this about the directory or the make target? Absolutely no objections on the directory name, as it won't conflict with putting new ERT-based benchmarks in test/. As for the make target, we should decide whether "make benchmark" means "run all benchmarks no matter which framework" or "run the elisp-benchmarks specifically". I don't think benchmark: elisp-benchmarks check-benchmark is a bad rule at all. Pip