From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kevin Ryde Newsgroups: gmane.emacs.devel Subject: Re: customize eshell-alias loading Date: Tue, 06 Apr 2004 08:33:50 +1000 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <87k70ujbqp.fsf@zip.com.au> References: <87fzbt7qbo.fsf@zip.com.au> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: sea.gmane.org 1081204622 3315 80.91.224.253 (5 Apr 2004 22:37:02 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 5 Apr 2004 22:37:02 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Apr 06 00:36:49 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BAci1-0008CC-00 for ; Tue, 06 Apr 2004 00:36:49 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BAci1-0002A0-00 for ; Tue, 06 Apr 2004 00:36:49 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAchB-0002P8-TN for emacs-devel@quimby.gnus.org; Mon, 05 Apr 2004 18:35:57 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BAcgu-0002O4-5y for emacs-devel@gnu.org; Mon, 05 Apr 2004 18:35:40 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BAcfz-0001B9-V5 for emacs-devel@gnu.org; Mon, 05 Apr 2004 18:35:16 -0400 Original-Received: from [61.8.0.85] (helo=mailout2.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAcfg-0000ax-94 for emacs-devel@gnu.org; Mon, 05 Apr 2004 18:34:24 -0400 Original-Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout2.pacific.net.au (8.12.3/8.12.3/Debian-6.6) with ESMTP id i35MYJ5v004165 for ; Tue, 6 Apr 2004 08:34:19 +1000 Original-Received: from localhost (ppp2108.dyn.pacific.net.au [61.8.33.8]) by mailproxy1.pacific.net.au (8.12.3/8.12.3/Debian-6.6) with ESMTP id i35MYHGP002145 for ; Tue, 6 Apr 2004 08:34:18 +1000 Original-Received: from gg by localhost with local (Exim 3.36 #1 (Debian)) id 1BAcfE-0000eG-00; Tue, 06 Apr 2004 08:33:56 +1000 Original-To: emacs-devel@gnu.org In-Reply-To: (Richard Stallman's message of "Sun, 28 Mar 2004 21:35:14 -0500") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:21290 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:21290 --=-=-= Richard Stallman writes: > > Another would be to make em-alias require the other files it needs in > order to load properly. I went through the cus-load lists with a bit of a script and came up with the following. reftex was another I'd noticed before, but it seems to have got better on its own (or maybe I was on the 21.3 code). * eshell/em-alias.el, eshell/em-dirs.el, eshell/em-hist.el, eshell/em-unix.el: Add "(require 'eshell)", to get necessary features when M-x customize-group loads modules before the main eshell.el. I guess this makes some circular require's, but with the provide's are at the top of each file it seems to work. The esh-groups.el scheme confused me a bit. (esh-module.el greps the em-*.el modules for defgroups and generates esh-groups.el, to make the group definitions available before the modules are loaded.) I wondered if cus-load made that redundant. It seems to be harmless at least. --=-=-= Content-Disposition: inline; filename=em-alias.el.require.diff *** em-alias.el.~1.10.~ Sun Mar 28 07:45:10 2004 --- em-alias.el Tue Apr 6 08:20:10 2004 *************** *** 1,6 **** ;;; em-alias.el --- creation and management of command aliases ! ;; Copyright (C) 1999, 2000 Free Software Foundation ;; Author: John Wiegley --- 1,6 ---- ;;; em-alias.el --- creation and management of command aliases ! ;; Copyright (C) 1999, 2000, 2004 Free Software Foundation ;; Author: John Wiegley *************** *** 24,29 **** --- 24,30 ---- (provide 'em-alias) (eval-when-compile (require 'esh-maint)) + (require 'eshell) (defgroup eshell-alias nil "Command aliases allow for easy definition of alternate commands." --=-=-= Content-Disposition: inline; filename=em-dirs.el.require.diff *** em-dirs.el.~1.13.~ Sat Sep 6 08:15:45 2003 --- em-dirs.el Tue Apr 6 08:20:47 2004 *************** *** 1,6 **** ;;; em-dirs.el --- directory navigation commands ! ;; Copyright (C) 1999, 2000 Free Software Foundation ;; Author: John Wiegley --- 1,6 ---- ;;; em-dirs.el --- directory navigation commands ! ;; Copyright (C) 1999, 2000, 2004 Free Software Foundation ;; Author: John Wiegley *************** *** 24,29 **** --- 24,30 ---- (provide 'em-dirs) (eval-when-compile (require 'esh-maint)) + (require 'eshell) (defgroup eshell-dirs nil "Directory navigation involves changing directories, examining the --=-=-= Content-Disposition: inline; filename=em-hist.el.require.diff *** em-hist.el.~1.14.~ Sun Feb 15 10:17:50 2004 --- em-hist.el Wed Mar 31 15:29:53 2004 *************** *** 24,29 **** --- 24,30 ---- (provide 'em-hist) (eval-when-compile (require 'esh-maint)) + (require 'eshell) (defgroup eshell-hist nil "This module provides command history management." --=-=-= Content-Disposition: inline; filename=em-unix.el.require.diff *** em-unix.el.~1.21.~ Sat Sep 6 08:15:46 2003 --- em-unix.el Tue Apr 6 08:21:33 2004 *************** *** 1,6 **** ;;; em-unix.el --- UNIX command aliases ! ;; Copyright (C) 1999, 2000, 2001 Free Software Foundation ;; Author: John Wiegley --- 1,6 ---- ;;; em-unix.el --- UNIX command aliases ! ;; Copyright (C) 1999, 2000, 2001, 2004 Free Software Foundation ;; Author: John Wiegley *************** *** 24,29 **** --- 24,30 ---- (provide 'em-unix) (eval-when-compile (require 'esh-maint)) + (require 'eshell) (defgroup eshell-unix nil "This module defines many of the more common UNIX utilities as --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://mail.gnu.org/mailman/listinfo/emacs-devel --=-=-=--