23.0.50; open-network-stream should return an error when SERVICE is a string number

* 23.0.50; open-network-stream should return an error when SERVICE is a string number
@ 2007-09-18 21:00 Luca Capello
  2007-09-19 15:49 ` Richard Stallman
  0 siblings, 1 reply; 5+ messages in thread
From: Luca Capello @ 2007-09-18 21:00 UTC (permalink / raw)
  To: emacs-pretest-bug; +Cc: rfrancoise

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Please Cc: me, I'm not subscribed to the list.

When I discover the bug in erc-default-port [1], I found that
open-network-stream behaves differently than
socks-open-network-stream WRT the SERVICE parameter:
=====
*** Welcome to IELM ***  Type (describe-mode) for help.
ELISP> (open-network-stream "http-www.gnu.org" nil "www.gnu.org" "80")
#<process http-www.gnu.org>
ELISP> (open-network-stream "http-www.gnu.org" nil "www.gnu.org" 80)
#<process http-www.gnu.org<1>>
ELISP> (open-network-stream "http-www.gnu.org" nil "www.gnu.org" "www")
#<process http-www.gnu.org<2>>

ELISP> (socks-open-network-stream "http-www.gnu.org" nil "www.gnu.org" "80")
*** Eval error ***  Wrong type argument: integerp, nil
ELISP> (socks-open-network-stream "http-www.gnu.org" nil "www.gnu.org" 80)
#<process socks<1>>
ELISP> (socks-open-network-stream "http-www.gnu.org" nil "www.gnu.org" "www")
#<process socks<2>>
ELISP> 
=====

To be consistent, shouldn't open-network-stream return the same error
as socks-open-network-stream when SERVICE is a string number?  This is
at least what it's in (describe-function 'open-network-stream):
=====
open-network-stream is a compiled Lisp function in `subr.el'.
(open-network-stream NAME BUFFER HOST SERVICE)
[...]
SERVICE is name of the service desired, or an integer specifying
 a port number to connect to.
=====

Thx, bye,
Gismo / Luca

Footnotes: 
[1] http://lists.gnu.org/archive/html/emacs-devel/2007-09/msg00087.html

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/23.0.50/etc/DEBUG for instructions.

In GNU Emacs 23.0.50.1 (x86_64-pc-linux-gnu)
 of 2007-09-09 on elegiac, modified by Debian
 (Debian emacs-snapshot package, version 1:20070909-1)
configured using `configure  '--build' 'x86_64-linux-gnu' '--host' 'x86_64-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.50/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.50/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.0.50/leim' '--with-x=no' 'build_alias=x86_64-linux-gnu' 'host_alias=x86_64-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: en_US.UTF-8
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Group

Minor modes in effect:
  erc-truncate-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-spelling-mode: t
  erc-services-mode: t
  erc-ring-mode: t
  erc-netsplit-mode: t
  erc-match-mode: t
  erc-pcomplete-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-autojoin-mode: t
  erc-autoaway-mode: t
  gnus-topic-mode: t
  gnus-undo-mode: t
  display-battery-mode: t
  display-time-mode: t
  show-paren-mode: t
  erc-stamp-mode: t
  erc-log-mode: t
  erc-scrolltobottom-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
ESC [ B C-c C-c d q l L ESC [ A ESC [ A C-u RET RET 
q l g ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B ESC [ 
B ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B ESC 
[ B ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B 
ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B ESC 
[ B ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B 
ESC [ B ESC [ B RET RET B r RET x q l ESC [ A ESC [ 
A ESC [ A ESC [ A ESC [ A ESC [ A ESC [ A ESC [ A ESC 
[ A ESC [ A ESC [ A ESC [ B ESC [ B RET q ESC [ A ESC 
[ A ESC [ A ESC [ A ESC [ A ESC [ A ESC [ A ESC [ A 
ESC [ A ESC [ A ESC [ A ESC [ A ESC [ B ESC [ B ESC 
[ B ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B 
ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B ESC 
[ B ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B 
C-c ESC f i ESC [ B C-c ESC f g ESC x r e p o r t - 
e TAB b u TAB RET

Recent messages:
Exiting summary buffer and applying spam rules
Marking spam as expired without moving it
Auto-saving...done
Retrieving newsgroup: nnimap+pca.it:INBOX...
nnimap: Updating info for nnimap+pca.it:INBOX...done
Fetching headers for nnimap+pca.it:INBOX...done
Generating summary...done
Exiting summary buffer and applying spam rules
Marking spam as expired without moving it
Loading emacsbug...done

^ permalink raw reply	[flat|nested] 5+ messages in thread