show minor-mode menu when you click its mode-line lighter

show minor-mode menu when you click its mode-line lighter

[Drew Adams]

[-- Attachment #1: Type: text/plain, Size: 623 bytes --]

Attached is a patch that makes a `mouse-1' click on a minor-mode lighter in
the mode line raise its menu-bar menu, if any, as a popup.

This is analogous to what `mouse-1' does when you click the major-mode
lighter. Each minor-mode lighter brings up its own menu. If a minor mode has
no menu-bar menu, then `mouse-1' displays a message stating that.

Currently, `mouse-1' does nothing here, so this is an addition.

Example: Minor mode Icicles has lighter "Icy" in the mode line, and it has a
menu-bar menu `Icicles'. Whether or not the menu-bar is showing, if you
click the lighter "Icy" then the `Icicles' menu pops up.


[-- Attachment #2: bindings-2007-09-27.patch --]
[-- Type: application/octet-stream, Size: 7930 bytes --]

*** bindings-CVS-2007-09-27.el	Thu Sep 27 14:43:48 2007
--- bindings-patched-2007-09-27.el	Thu Sep 27 15:07:04 2007
***************
*** 289,294 ****
--- 289,295 ----
  
  (defvar mode-line-minor-mode-keymap
    (let ((map (make-sparse-keymap)))
+     (define-key map [mode-line down-mouse-1] 'mouse-minor-mode-menu)
      (define-key map [mode-line mouse-2] 'mode-line-minor-mode-help)
      (define-key map [mode-line down-mouse-3] 'mode-line-mode-menu-1)
      (define-key map [header-line down-mouse-3] 'mode-line-mode-menu-1)
***************
*** 304,346 ****
  	"mouse-1: select (drag to resize), mouse-2 = C-x 1, mouse-3 = C-x 0")
         (dashes (propertize "--" 'help-echo help-echo))
         (standard-mode-line-format
! 	(list
! 	 "%e"
! 	 (propertize "-" 'help-echo help-echo)
! 	 'mode-line-mule-info
! 	 'mode-line-client
! 	 'mode-line-modified
! 	 'mode-line-remote
! 	 'mode-line-frame-identification
! 	 'mode-line-buffer-identification
! 	 (propertize "   " 'help-echo help-echo)
! 	 'mode-line-position
! 	 '(vc-mode vc-mode)
! 	 (propertize "  " 'help-echo help-echo)
! 	 'mode-line-modes
  	 `(which-func-mode ("" which-func-format ,dashes))
  	 `(global-mode-string (,dashes global-mode-string))
  	 (propertize "-%-" 'help-echo help-echo)))
         (standard-mode-line-modes
! 	(list
! 	 (propertize "%[(" 'help-echo help-echo)
  	 `(:propertize ("" mode-name)
! 		       help-echo "mouse-1: major mode, mouse-2: major mode help, mouse-3: toggle minor modes"
  		       mouse-face mode-line-highlight
  		       local-map ,mode-line-major-mode-keymap)
  	 '("" mode-line-process)
  	 `(:propertize ("" minor-mode-alist)
  		       mouse-face mode-line-highlight
! 		       help-echo "mouse-2: minor mode help, mouse-3: toggle minor modes"
  		       local-map ,mode-line-minor-mode-keymap)
  	 (propertize "%n" 'help-echo "mouse-2: widen"
  		     'mouse-face 'mode-line-highlight
  		     'local-map (make-mode-line-mouse-map
  				 'mouse-2 #'mode-line-widen))
  	 (propertize ")%]--" 'help-echo help-echo)))
! 
!        (standard-mode-line-position
! 	`((-3 ,(propertize "%p" 'help-echo help-echo))
  	  (size-indication-mode
  	   (8 ,(propertize " of %I" 'help-echo help-echo)))
  	  (line-number-mode
--- 305,338 ----
          "mouse-1: select (drag to resize), mouse-2 = C-x 1, mouse-3 = C-x 0")
         (dashes (propertize "--" 'help-echo help-echo))
         (standard-mode-line-format
! 	(list "%e"
!               (propertize "-" 'help-echo help-echo) 'mode-line-mule-info
!               'mode-line-client 'mode-line-modified 'mode-line-remote
!               'mode-line-frame-identification 'mode-line-buffer-identification
!               (propertize "   " 'help-echo help-echo) 'mode-line-position '(vc-mode vc-mode)
!               (propertize "  " 'help-echo help-echo) 'mode-line-modes
                `(which-func-mode ("" which-func-format ,dashes))
                `(global-mode-string (,dashes global-mode-string))
                (propertize "-%-" 'help-echo help-echo)))
         (standard-mode-line-modes
!         (list (propertize "%[(" 'help-echo help-echo)
                `(:propertize ("" mode-name)
!                             help-echo "mouse-1: major-mode menu, mouse-2: major-mode help, \
! mouse-3: toggle minor modes"
                              mouse-face mode-line-highlight
                              local-map ,mode-line-major-mode-keymap)
                '("" mode-line-process)
                `(:propertize ("" minor-mode-alist)
                              mouse-face mode-line-highlight
!                             help-echo "mouse-1: minor-mode menu, mouse-2: minor-mode help, \
! mouse-3: toggle minor modes"
                              local-map ,mode-line-minor-mode-keymap)
                (propertize "%n" 'help-echo "mouse-2: widen"
                            'mouse-face 'mode-line-highlight
                            'local-map (make-mode-line-mouse-map
                                        'mouse-2 #'mode-line-widen))
                (propertize ")%]--" 'help-echo help-echo)))
!        (standard-mode-line-position `((-3 ,(propertize "%p" 'help-echo help-echo))
                                        (size-indication-mode
                                         (8 ,(propertize " of %I" 'help-echo help-echo)))
                                        (line-number-mode
***************
*** 349,366 ****
  	     (6 ,(propertize " L%l" 'help-echo help-echo))))
  	   ((column-number-mode
  	     (5 ,(propertize " C%c" 'help-echo help-echo))))))))
- 
    (setq-default mode-line-format standard-mode-line-format)
!   (put 'mode-line-format 'standard-value
!        (list `(quote ,standard-mode-line-format)))
  
    (setq-default mode-line-modes standard-mode-line-modes)
!   (put 'mode-line-modes 'standard-value
!        (list `(quote ,standard-mode-line-modes)))
  
    (setq-default mode-line-position standard-mode-line-position)
!   (put 'mode-line-position 'standard-value
!        (list `(quote ,standard-mode-line-position))))
  
  (defvar mode-line-buffer-identification-keymap
    ;; Add menu of buffer operations to the buffer identification part
--- 341,354 ----
                                           (6 ,(propertize " L%l" 'help-echo help-echo))))
                                         ((column-number-mode
                                           (5 ,(propertize " C%c" 'help-echo help-echo))))))))
    (setq-default mode-line-format standard-mode-line-format)
!   (put 'mode-line-format 'standard-value (list `(quote ,standard-mode-line-format)))
  
    (setq-default mode-line-modes standard-mode-line-modes)
!   (put 'mode-line-modes 'standard-value (list `(quote ,standard-mode-line-modes)))
  
    (setq-default mode-line-position standard-mode-line-position)
!   (put 'mode-line-position 'standard-value (list `(quote ,standard-mode-line-position))))
  
  (defvar mode-line-buffer-identification-keymap
    ;; Add menu of buffer operations to the buffer identification part
***************
*** 492,499 ****
    (interactive "@e")
    (x-popup-menu event mode-line-mode-menu))
  
  (defun mode-line-minor-mode-help (event)
!   "Describe minor mode for EVENT occurred on minor modes area of the mode line."
    (interactive "@e")
    (let ((indicator (car (nth 4 (car (cdr event))))))
      (describe-minor-mode-from-indicator indicator)))
--- 480,507 ----
    (interactive "@e")
    (x-popup-menu event mode-line-mode-menu))
  
+ (defun mouse-minor-mode-menu (event)
+   "Show minor-mode menu for EVENT on minor modes area of the mode line."
+   (interactive "@e")
+   (let ((indicator (car (nth 4 (car (cdr event))))))
+     (minor-mode-menu-from-indicator indicator)))
+ 
+ (defun minor-mode-menu-from-indicator (indicator) ; " Icy"
+   "Show menu, if any, for minor mode specified by INDICATOR.
+ Interactively, INDICATOR is read using completion."
+   (interactive (list (completing-read "Minor mode indicator: "
+                                       (describe-minor-mode-completion-table-for-indicator))))
+   (let ((minor-mode (lookup-minor-mode-from-indicator indicator)))
+     (if minor-mode
+         (let* ((map (cdr-safe (assq minor-mode minor-mode-map-alist)))
+                (menu (and (keymapp map) (lookup-key map [menu-bar]))))
+           (if menu
+               (popup-menu menu)
+             (message "No menu for minor mode `%s'" minor-mode)))
+       (error "Cannot find minor mode for `%s'" indicator))))
+ 
  (defun mode-line-minor-mode-help (event)
!   "Describe minor mode for EVENT on minor modes area of the mode line."
    (interactive "@e")
    (let ((indicator (car (nth 4 (car (cdr event))))))
      (describe-minor-mode-from-indicator indicator)))

Diff finished.  Thu Sep 27 15:07:29 2007

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: show minor-mode menu when you click its mode-line lighter

[Richard Stallman]

    Example: Minor mode Icicles has lighter "Icy" in the mode line, and it has a
    menu-bar menu `Icicles'. Whether or not the menu-bar is showing, if you
    click the lighter "Icy" then the `Icicles' menu pops up.

It seems like a plausible feature.  What do others think?

RE: show minor-mode menu when you click its mode-line lighter

[Drew Adams]

> From: Richard Stallman Sent: Friday, September 28, 2007 12:04 PM
>
>     Example: Minor mode Icicles has lighter "Icy" in the mode 
>     line, and it has a menu-bar menu `Icicles'. Whether or not
>     the menu-bar is showing, if you click the lighter "Icy" then
>     the `Icicles' menu pops up.
> 
> It seems like a plausible feature.  What do others think?

No response. How about installing this patch?

Re: show minor-mode menu when you click its mode-line lighter

[Richard Stallman]

    >     Example: Minor mode Icicles has lighter "Icy" in the mode 
    >     line, and it has a menu-bar menu `Icicles'. Whether or not
    >     the menu-bar is showing, if you click the lighter "Icy" then
    >     the `Icicles' menu pops up.
    > 
    > It seems like a plausible feature.  What do others think?

    No response. How about installing this patch?

Does anyone else see this as useful?

Re: show minor-mode menu when you click its mode-line lighter

[Michaël Cadilhac]

[-- Attachment #1.1: Type: text/plain, Size: 997 bytes --]

Richard Stallman <rms@gnu.org> writes:

>     >     Example: Minor mode Icicles has lighter "Icy" in the mode 
>     >     line, and it has a menu-bar menu `Icicles'. Whether or not
>     >     the menu-bar is showing, if you click the lighter "Icy" then
>     >     the `Icicles' menu pops up.
>     > 
>     > It seems like a plausible feature.  What do others think?
>
>     No response. How about installing this patch?
>
> Does anyone else see this as useful?

Well, my .2€ : I think this is useful, and I'd use it if I used this
funky thing next to my keyboard called a mouse.

However, this feature has to be described in the doc and NEWS.

-- 
 |   Michaël `Micha' Cadilhac       |  «Tu aimeras ton prochain.»            |
 |   http://michael.cadilhac.name   |    D'abord, Dieu ou pas,               |
 |   JID/MSN:                       |       j'ai horreur qu'on me tutoie.    |
 `----  michael.cadilhac@gmail.com  |           -- P. Desproges         -  --'

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

RE: show minor-mode menu when you click its mode-line lighter

[Drew Adams]

> >     >     Example: Minor mode Icicles has lighter "Icy" in the mode 
> >     >     line, and it has a menu-bar menu `Icicles'. Whether or not
> >     >     the menu-bar is showing, if you click the lighter "Icy" then
> >     >     the `Icicles' menu pops up.
> >     > 
> >     > It seems like a plausible feature.  What do others think?
> >
> >     No response. How about installing this patch?
> >
> > Does anyone else see this as useful?
> 
> Well, my .2€ : I think this is useful, and I'd use it if I used this
> funky thing next to my keyboard called a mouse.
> 
> However, this feature has to be described in the doc and NEWS.

Sure; I will send a doc description and NEWS patch if it is decided to go with this.

[In case it's not clear: This feature just does for minor-mode lighters what is already done for a major-mode lighter. It has nothing to do with Icicles - Richard just quoted a usage example.]

Re: show minor-mode menu when you click its mode-line lighter

[Richard Stallman]

    Well, my .2=E2=82=AC=C2=A0: I think this is useful, and I'd use it if I use=
    d this
    funky thing next to my keyboard called a mouse.

Thus, it would not in fact be useful for you.

Is there anyone for whom this would be useful?  It is not unclean as a
feature, and I would like it installed if it will be useful.  But the
absence of this feature is not a flaw.  I see no reason to install
one more feature if it won't actually be useful.

Re: show minor-mode menu when you click its mode-line lighter

[Dan Nicolaescu]

Richard Stallman <rms@gnu.org> writes:

  >     Well, my .2=E2=82=AC=C2=A0: I think this is useful, and I'd use it if I use=
  >     d this
  >     funky thing next to my keyboard called a mouse.
  > 
  > Thus, it would not in fact be useful for you.
  > 
  > Is there anyone for whom this would be useful?  It is not unclean as a
  > feature, and I would like it installed if it will be useful.  But the
  > absence of this feature is not a flaw.  I see no reason to install
  > one more feature if it won't actually be useful.

I think this would be useful. It provides an easy way for people that
don't know all the key bindings to use the commands provided by a
minor mode, and on top of that it is consistent with what we do for
major modes.

Re: show minor-mode menu when you click its mode-line lighter

[Michaël Cadilhac]

[-- Attachment #1.1: Type: text/plain, Size: 1440 bytes --]

Richard Stallman <rms@gnu.org> writes:

>     Well, my .2=E2=82=AC=C2=A0: I think this is useful, and I'd use it if I use=
>     d this
>     funky thing next to my keyboard called a mouse.
>
> Thus, it would not in fact be useful for you.
>
> Is there anyone for whom this would be useful?  It is not unclean as a
> feature, and I would like it installed if it will be useful.  But the
> absence of this feature is not a flaw.  I see no reason to install
> one more feature if it won't actually be useful.

Well, I believe people around here don't use the mouse on a daily basis,
we pretty much have all years of practice, and learned that the mousy
thing isn't the most efficient way to use Emacs.  This is more a feature
for novice users, and they don't usually take part in devel discussions.

But we seem to agree (at least Dan, Drew and I) that this feature would
be a good thing, as it improves consistency.  A novice user can be
disappointed to see that although the cursor's shape changes when moving
to a minor mode modeline item, nothing can be triggered.

Again, my .2€.

-- 
 |   Michaël `Micha' Cadilhac       |  Si les religions étaient aussi tolé-  |
 |   http://michael.cadilhac.name   |  rantes qu'elles le prétendent, il y   |
 |   JID/MSN:                       |  a longtemps qu'il n'y en aurait plus  |
 `----  michael.cadilhac@gmail.com  |           -- Moustic              -  --'

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

RE: show minor-mode menu when you click its mode-line lighter

[Drew Adams]

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

> From: "Michaël" Cadilhac Sent: Monday, October 08, 2007 8:36 AM
> Well, I believe people around here don't use the mouse on a daily basis,
> we pretty much have all years of practice, and learned that the mousy
> thing isn't the most efficient way to use Emacs.  This is more a feature
> for novice users, and they don't usually take part in devel discussions.
> 
> But we seem to agree (at least Dan, Drew and I) that this feature would
> be a good thing, as it improves consistency.  A novice user can be
> disappointed to see that although the cursor's shape changes when moving
> to a minor mode modeline item, nothing can be triggered.
> 
> Again, my .2€.

Attached are doc (texinfo) patches for this feature. Someone might want to check that I used @samp correctly etc.


[-- Attachment #2: custom-2007-10-08a-texi.patch --]
[-- Type: application/octet-stream, Size: 1624 bytes --]

*** custom-2007-10-08a.texi	Mon Oct  8 09:34:00 2007
--- custom-patched-2007-10-08a.texi	Mon Oct  8 09:36:26 2007
***************
*** 54,62 ****
    Minor modes are optional features which you can turn on or off.  For
  example, Auto Fill mode is a minor mode in which @key{SPC} breaks lines
  between words as you type.  All the minor modes are independent of each
! other and of the selected major mode.  Most minor modes say in the mode
! line when they are enabled; for example, @samp{Fill} in the mode line means
! that Auto Fill mode is enabled.
  
    You should append @code{-mode} to the name of a minor mode to
  produce the name of the command that turns the mode on or off.  Thus,
--- 54,68 ----
    Minor modes are optional features which you can turn on or off.  For
  example, Auto Fill mode is a minor mode in which @key{SPC} breaks lines
  between words as you type.  All the minor modes are independent of each
! other and of the selected major mode.  
! 
!   Many minor modes show an indicator in the mode line when they are
! enabled. For example, @samp{Fill} in the mode line means that Auto Fill
! mode is enabled.  Some minor modes provide a menu for accessing their
! options and commands.  The menu is typically available in the menu bar
! when the minor mode is enabled.  It is also available by clicking
! (@samp{mouse-1}) the minor mode's indicator in the mode line, and this is
! so whether or not the menu bar is enabled.
  
    You should append @code{-mode} to the name of a minor mode to
  produce the name of the command that turns the mode on or off.  Thus,


[-- Attachment #3: screen-2007-10-08-texi.patch --]
[-- Type: application/octet-stream, Size: 721 bytes --]

*** screen-2007-10-08a.texi	Mon Oct  8 09:20:56 2007
--- screen-patched-2007-10-08a.texi	Mon Oct  8 09:24:18 2007
***************
*** 258,263 ****
--- 258,267 ----
  Word Abbrev mode is on.  @samp{Ovwrt} means that Overwrite mode is on.
  @xref{Minor Modes}, for more information. 
  
+   If the major mode or a minor mode has a menu-bar menu, then you can
+ click @samp{mouse-1} on the mode's mode-line indicator to pop up that
+ menu.  This is so, whether or not the menu bar is visible.
+ 
    @samp{Narrow} means that the buffer being displayed has editing
  restricted to only a portion of its text.  (This is not really a minor
  mode, but is like one.)  @xref{Narrowing}.  @samp{Def} means that a


[-- Attachment #4: frames-2007-10-08a-texi.patch --]
[-- Type: application/octet-stream, Size: 1099 bytes --]

*** frames-2007-10-08a.texi	Mon Oct  8 09:38:46 2007
--- frames-patched-2007-10-08a.texi	Mon Oct  8 09:41:28 2007
***************
*** 926,932 ****
  terminals, where this makes one additional line available for text.
  If the menu bar is off, you can still pop up a menu of its contents
  with @kbd{C-Mouse-3} on a display which supports pop-up menus.
! @xref{Menu Mouse Clicks}.
  
    @xref{Menu Bar}, for information on how to invoke commands with the
  menu bar.  @xref{X Resources}, for how to customize the menu bar
--- 926,934 ----
  terminals, where this makes one additional line available for text.
  If the menu bar is off, you can still pop up a menu of its contents
  with @kbd{C-Mouse-3} on a display which supports pop-up menus.
! @xref{Menu Mouse Clicks}.  In addition, if the minor mode is indicated
! in the mode line and it has a menu, you can click @samp{mouse-1} on its
! indicator to pop up the minor-mode menu.
  
    @xref{Menu Bar}, for information on how to invoke commands with the
  menu bar.  @xref{X Resources}, for how to customize the menu bar


[-- Attachment #5: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: show minor-mode menu when you click its mode-line lighter

[Richard Stallman]

    I think this would be useful. It provides an easy way for people that
    don't know all the key bindings to use the commands provided by a
    minor mode, and on top of that it is consistent with what we do for
    major modes.

Ok.  Does anyone else want to argue for it?

Re: show minor-mode menu when you click its mode-line lighter

[Glenn Morris]

Richard Stallman wrote:

>     I think this would be useful. It provides an easy way for people
>     that don't know all the key bindings to use the commands
>     provided by a minor mode, and on top of that it is consistent
>     with what we do for major modes.
>
> Ok.  Does anyone else want to argue for it?

What Dan says makes sense to me.

Re: show minor-mode menu when you click its mode-line lighter

[Richard Stallman]

Ok, let's install that change.  Could you please take care of doing it?

Re: show minor-mode menu when you click its mode-line lighter

[Richard Stallman]

The point of this feature is that people mousing around
will find what they might expect.  It isn't necessary
to document such features.  You'll note that the manual
doesn't explain Mouse-1 on major mode names, either.
GUIs are supposed to be self-explanatory, right?

The only change needed to document this is a tiny one
in the first paragraph of Mode Line Mouse.

RE: show minor-mode menu when you click its mode-line lighter

[Drew Adams]

> The point of this feature is that people mousing around
> will find what they might expect.  It isn't necessary
> to document such features.  You'll note that the manual
> doesn't explain Mouse-1 on major mode names, either.
> GUIs are supposed to be self-explanatory, right?
>
> The only change needed to document this is a tiny one
> in the first paragraph of Mode Line Mouse.

Suit yourself. With that logic, however, there is no need to document the
menu bar, the tool bar, and other GUI features that users can discover by
mousing around (if on by default).

I'm not sure it's obvious that you can get major and minor mode menus
without showing the menu bar. But I agree that this kind of thing is less
important to document in general, for the reason you gave.

Re: show minor-mode menu when you click its mode-line lighter

[Davis Herring]

>     >     Example: Minor mode Icicles has lighter "Icy" in the mode
>     >     line, and it has a menu-bar menu `Icicles'. Whether or not
>     >     the menu-bar is showing, if you click the lighter "Icy" then
>     >     the `Icicles' menu pops up.
>     >
>     > It seems like a plausible feature.  What do others think?
>
>     No response. How about installing this patch?
>
> Does anyone else see this as useful?

Upon further reflection, it occurs to me that this might really be useful.
 I currently have the menu bar enabled, but the majority of its utility is
in presenting commands that are not global (I know C-x C-f, but maybe not
C-c C-d in Outline mode).  With access to the buffer-specific menus from
the mode line, I could perhaps get rid of the menu bar.

Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.

Re: show minor-mode menu when you click its mode-line lighter

[Richard Stallman]

    Suit yourself. With that logic, however, there is no need to document the
    menu bar, the tool bar, and other GUI features that users can discover by
    mousing around (if on by default).

It could well be that we could get by with less documentation
of some of these things than we now have.

Re: show minor-mode menu when you click its mode-line lighter

[Glenn Morris]

I installed this. In future, please do provide a ChangeLog entry, and
please DO NOT include in your patch a bunch of gratuitous formatting
changes to existing code.