From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: rfn-eshadow (Was: [jidanni@jidanni.org: ffap; prompt turns color misleadingly]) Date: Thu, 03 Jan 2008 23:42:07 +0200 Organization: JURTA Message-ID: <87k5mq60y8.fsf@jurta.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1199397028 22580 80.91.229.12 (3 Jan 2008 21:50:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Jan 2008 21:50:28 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 03 22:50:47 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JAXxW-0002fL-Oo for ged-emacs-devel@m.gmane.org; Thu, 03 Jan 2008 22:50:39 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JAXxA-0002yZ-Fq for ged-emacs-devel@m.gmane.org; Thu, 03 Jan 2008 16:50:16 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JAXwM-0001ya-Es for emacs-devel@gnu.org; Thu, 03 Jan 2008 16:49:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JAXwL-0001ws-Gd for emacs-devel@gnu.org; Thu, 03 Jan 2008 16:49:25 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JAXwL-0001wd-8J for emacs-devel@gnu.org; Thu, 03 Jan 2008 16:49:25 -0500 Original-Received: from relay03.kiev.sovam.com ([62.64.120.201]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JAXwH-0000IO-FB; Thu, 03 Jan 2008 16:49:21 -0500 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay03.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1JAXwE-0009fD-5w; Thu, 03 Jan 2008 23:49:19 +0200 In-Reply-To: (Richard Stallman's message of "Thu, 03 Jan 2008 04:51:15 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-Scanner-Signature: 8d26fb09d298f8c1cb325fc86345eca8 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 1976 [Dec 29 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: none X-SpamTest-Rate: 19 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:86013 Archived-At: > I doubt that Michelangelo Grigni is still involved in ffap.el. > Someone else interested in ffap.el might want to work on this. ffap.el mentions FSF as a maintainer, but actually this bug has nothing to do with ffap. The problem is that even if ffap is disabled, when typing an URL in the minibuffer, rfn-eshadow.el threats it as a file name, and puts a shadow over the `http:' part because it contains double slashes //. I think the right way to fix this problem is the following patch that prevents handling of URLs by file-name-shadow-mode: Index: lisp/rfn-eshadow.el =================================================================== RCS file: /sources/emacs/emacs/lisp/rfn-eshadow.el,v retrieving revision 1.26 diff -u -w -b -r1.26 rfn-eshadow.el --- lisp/rfn-eshadow.el 21 Sep 2007 05:24:05 -0000 1.26 +++ lisp/rfn-eshadow.el 3 Jan 2008 21:36:44 -0000 @@ -177,7 +177,10 @@ `file-name-shadow-mode'; the minibuffer should have already been set up by `rfn-eshadow-setup-minibuffer'." (condition-case nil - (let ((goal (substitute-in-file-name (minibuffer-contents))) + (let* ((mc (minibuffer-contents)) + (goal (if (string-match-p "\\`\\(https?\\|ftp\\|file\\)://" mc) + mc + (substitute-in-file-name mc))) (mid (overlay-end rfn-eshadow-overlay)) (start (minibuffer-prompt-end)) (end (point-max))) > From: jidanni@jidanni.org > Subject: ffap; prompt turns color misleadingly > To: Michelangelo Grigni > Cc: bug-gnu-emacs@gnu.org > Date: Mon, 31 Dec 2007 07:45:50 +0800 > > $ emacs -Q file_with_url_in_it > Put the cursor on the URL, do M-x ffap. > Now add some slashes at the end of the URL. The preceding part of the URL > changes color, making us think that we are now just referring to the local > file system as the usual shortcut: /wrong//right, but in fact it is all > appended to the URL anyway! > > Also please use a third color for the "http:/" and "ftp:/", or use the > same color as the rest of the URL. Currently you use the "discarded > text" color, which is not exactly right, as it is indeed part of the URL. -- Juri Linkov http://www.jurta.org/emacs/