all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Glenn Morris <rgm@gnu.org>
Cc: "Frédéric Perrin" <frederic.perrin@resel.fr>,
	emacs-devel@gnu.org, "Andreas Schwab" <schwab@suse.de>
Subject: Re: Woman path : adding l10n man pages
Date: Sun, 17 Feb 2008 02:43:08 +0200	[thread overview]
Message-ID: <87k5l4pg9j.fsf@jurta.org> (raw)
In-Reply-To: <1i63woh1u9.fsf@fencepost.gnu.org> (Glenn Morris's message of "Sat, 16 Feb 2008 19:18:54 -0500")

>> Setting `woman-locale' in mule-cmds.el doesn't seem like the right thing.
>
> Other things like ps-paper-type are already set there. This seems similar.
> Indeed, I think it _has_ to stay there since in principle I'm supposed
> to be able to use `(set-locale-environment locale-name)' to set up all
> my locale-specific stuff.

This doesn't justify leaving the woman-specific logic in mule-cmds.el.
I think set-locale-environment can just set the general locale
variables, and other packages can use them for their purposes
(e.g. woman-manpath-add-locales can have the same code that currently
sets woman-locale in mule-cmds.el).

Also I don't understand why woman-locale is defcustom?  A defcustom
option is supposed to be customized by the user, but the customized
value of woman-locale always gets overridden at startup and on every
call to `set-locale-environment'.  Perhaps the code that uses the locale
in woman.el should prefer the customized value if woman-locale is non-nil?

-- 
Juri Linkov
http://www.jurta.org/emacs/




  reply	other threads:[~2008-02-17  0:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-31 13:47 Woman path : adding l10n man pages Frédéric Perrin
2008-01-08 14:14 ` Frédéric Perrin
2008-01-08 15:38   ` Andreas Schwab
2008-01-09 15:35     ` Frédéric Perrin
2008-01-12 18:01     ` Frédéric Perrin
2008-02-04 19:58     ` Glenn Morris
2008-02-16 20:01       ` Frédéric Perrin
2008-02-16 22:13         ` Glenn Morris
2008-02-16 23:32           ` Juri Linkov
2008-02-17  0:18             ` Glenn Morris
2008-02-17  0:43               ` Juri Linkov [this message]
2008-02-17 23:15                 ` Glenn Morris
2008-02-17 23:35                   ` Juri Linkov
2008-02-18  0:02                     ` Glenn Morris
2008-02-18  0:41                       ` Juri Linkov
2008-02-18  1:14                         ` Miles Bader
2008-02-18 23:35                           ` Juri Linkov
2008-02-19  0:18                             ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k5l4pg9j.fsf@jurta.org \
    --to=juri@jurta.org \
    --cc=emacs-devel@gnu.org \
    --cc=frederic.perrin@resel.fr \
    --cc=rgm@gnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.