From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eric Hanchrow Newsgroups: gmane.emacs.devel Subject: Re: vc-git-show-log-entry Date: Mon, 20 Oct 2008 08:09:54 -0700 Message-ID: <87k5c3l2v1.fsf@offby1.atm01.sea.blarg.net> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1224533572 31009 80.91.229.12 (20 Oct 2008 20:12:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 20 Oct 2008 20:12:52 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 20 22:13:55 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KrwcV-00032e-34 for ged-emacs-devel@m.gmane.org; Mon, 20 Oct 2008 17:24:35 +0200 Original-Received: from localhost ([127.0.0.1]:51450 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KrwbP-0006pE-IE for ged-emacs-devel@m.gmane.org; Mon, 20 Oct 2008 11:23:27 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KrwbL-0006p9-Eh for emacs-devel@gnu.org; Mon, 20 Oct 2008 11:23:23 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KrwbK-0006ot-Jm for emacs-devel@gnu.org; Mon, 20 Oct 2008 11:23:22 -0400 Original-Received: from [199.232.76.173] (port=49525 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KrwbK-0006oq-DH for emacs-devel@gnu.org; Mon, 20 Oct 2008 11:23:22 -0400 Original-Received: from main.gmane.org ([80.91.229.2]:51215 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KrwbK-0003Yo-6e for emacs-devel@gnu.org; Mon, 20 Oct 2008 11:23:22 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1KrwbE-00050z-Or for emacs-devel@gnu.org; Mon, 20 Oct 2008 15:23:16 +0000 Original-Received: from q-static-138-125.avvanta.com ([206.124.138.125]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 20 Oct 2008 15:23:16 +0000 Original-Received: from offby1 by q-static-138-125.avvanta.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 20 Oct 2008 15:23:16 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 23 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: q-static-138-125.avvanta.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:RDfijYsJ1qc38GwuWI5iw9/0xZ4= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104686 Archived-At: Your patch seems to work, but I notice something I don't like: * I typed C-x C-f /usr/local/src/emacs-via-git/lisp/vc-git.el RET, visiting a file that is part of a git working tree (by an astounding coincidence, it's the very file we're hacking!) * I typed C-x v g to annotate the file * I moved point to a more or less random line, and typed "l" I did indeed see point move to that line's commit in the *vc-change-log* buffer ... albeit slowly (presumably since it takes git-log rather a long time to run). What's really bad is that the next time I typed "l" in the same annotated buffer, it _again_ took a long time; I think it re-ran "git log" even though there was already a perfectly good *vc-change-log* buffer. I haven't figured out why this is happening. My version seems to have this problem, too, for what it's worth. -- Asking the Iraqi people to assume Saddam's debts is rather like telling a man who has been shot in the head that he has to pay for the bullet. -- James Surowiecki