all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eric Hanchrow <offby1@blarg.net>
To: emacs-devel@gnu.org
Subject: Re: vc-git-show-log-entry
Date: Mon, 20 Oct 2008 08:09:54 -0700	[thread overview]
Message-ID: <87k5c3l2v1.fsf@offby1.atm01.sea.blarg.net> (raw)
In-Reply-To: quack.20081020T0236.lthtzb7ip51@roar.cs.berkeley.edu

Your patch seems to work, but I notice something I don't like:

* I typed C-x C-f /usr/local/src/emacs-via-git/lisp/vc-git.el RET,
  visiting a file that is part of a git working tree (by an astounding
  coincidence, it's the very file we're hacking!)
* I typed C-x v g to annotate the file
* I moved point to a  more or less random line, and typed "l"

I did indeed see point move to that line's commit in the *vc-change-log*
buffer ... albeit slowly (presumably since it takes git-log rather a
long time to run).  What's really bad is that the next time I typed "l"
in the same annotated buffer, it _again_ took a long time; I think it
re-ran "git log" even though there was already a perfectly good
*vc-change-log* buffer.

I haven't figured out why this is happening.

My version seems to have this problem, too, for what it's worth.
-- 
Asking the Iraqi people to assume Saddam's debts
is rather like telling a man who has been shot in the head
that he has to pay for the bullet.
        -- James Surowiecki





  parent reply	other threads:[~2008-10-20 15:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-20  9:36 vc-git-show-log-entry Karl Chen
2008-10-20 15:01 ` vc-git-show-log-entry Eric Hanchrow
2008-10-20 15:09 ` Eric Hanchrow [this message]
2008-10-20 18:19 ` vc-git-show-log-entry Dan Nicolaescu
2008-10-20 20:20   ` vc-git-show-log-entry Karl Chen
2008-10-20 22:10     ` vc-git-show-log-entry Dan Nicolaescu
2008-10-21  7:23       ` vc-git-show-log-entry Karl Chen
2008-10-21  8:49         ` vc-git-show-log-entry Dan Nicolaescu
2008-10-21 17:52       ` vc-git-show-log-entry Alexandre Julliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k5c3l2v1.fsf@offby1.atm01.sea.blarg.net \
    --to=offby1@blarg.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.