From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: *vc-diff* buffers are read-only, but M-k works Date: Wed, 04 Mar 2009 10:41:46 -0500 Message-ID: <87k575jnwl.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1236181435 13258 80.91.229.12 (4 Mar 2009 15:43:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Mar 2009 15:43:55 +0000 (UTC) Cc: David Reitter , 2553@emacsbugs.donarmstrong.com To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 04 16:45:10 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LetHR-0002hT-Jg for ged-emacs-devel@m.gmane.org; Wed, 04 Mar 2009 16:45:09 +0100 Original-Received: from localhost ([127.0.0.1]:54067 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LetG6-00086V-Fs for ged-emacs-devel@m.gmane.org; Wed, 04 Mar 2009 10:43:46 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LetD8-0006zi-6B for emacs-devel@gnu.org; Wed, 04 Mar 2009 10:40:42 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LetD7-0006zP-1F for emacs-devel@gnu.org; Wed, 04 Mar 2009 10:40:41 -0500 Original-Received: from [199.232.76.173] (port=38438 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LetD6-0006zM-SH for emacs-devel@gnu.org; Wed, 04 Mar 2009 10:40:40 -0500 Original-Received: from cyd.mit.edu ([18.115.2.24]:52247) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LetD6-0007OF-Is for emacs-devel@gnu.org; Wed, 04 Mar 2009 10:40:40 -0500 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 4354257E1FC; Wed, 4 Mar 2009 10:41:46 -0500 (EST) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:109446 Archived-At: David Reitter wrote: > M-k works just fine in read-only *vc-diff* buffers. > > However, undoing an M-k command is impossible, as is cutting, pasting, > or all the other things that I did all the time in *vc-diff* buffers > in Emacs 22. > > The M-k thing is a bug, the read-only (default?) setting is annoying. The purpose of making the vc-diff buffer read-only (2007-11-10 change to vc.el) was so that people can use the read-only diff-mode bindings like "k" and "p". However, it's counter-intuitive that undo does not work. Probably the easiest fix is to define a diff-undo command that lifts the read-only restriction temporarily. Any thoughts?