From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.bugs Subject: bug#2604: 23.0.91; key bindings in vc-annotate incompatible w/ Emacs 22 Date: Mon, 09 Mar 2009 20:57:05 +0100 Message-ID: <87k56ycvvy.fsf@marauder.physik.uni-ulm.de> References: <87wsazehs7.fsf@marauder.physik.uni-ulm.de> <200903091748.n29HmjcZ018979@rodan.ics.uci.edu> Reply-To: Reiner Steib , 2604@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1236635212 17516 80.91.229.12 (9 Mar 2009 21:46:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Mar 2009 21:46:52 +0000 (UTC) Cc: 2604@emacsbugs.donarmstrong.com To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 09 22:48:08 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LgnKR-00035S-TX for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Mar 2009 22:48:08 +0100 Original-Received: from localhost ([127.0.0.1]:46192 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LgnJ6-0007J1-6p for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Mar 2009 17:46:44 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lgm0n-0005GK-AJ for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2009 16:23:45 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lgm0l-0005E4-LO for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2009 16:23:44 -0400 Original-Received: from [199.232.76.173] (port=50107 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lgm0l-0005Ds-EM for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2009 16:23:43 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:46207) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lgm0k-0000n3-S2 for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2009 16:23:43 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n29KNeKL011440; Mon, 9 Mar 2009 13:23:41 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n29K55Vg006453; Mon, 9 Mar 2009 13:05:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Reiner Steib Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 09 Mar 2009 20:05:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2604 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2604-submit@emacsbugs.donarmstrong.com id=B2604.12366286344140 (code B ref 2604); Mon, 09 Mar 2009 20:05:05 +0000 Original-Received: (at 2604) by emacsbugs.donarmstrong.com; 9 Mar 2009 19:57:14 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail.uni-ulm.de (mail.uni-ulm.de [134.60.1.11]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n29Jv9JQ004133 for <2604@emacsbugs.donarmstrong.com>; Mon, 9 Mar 2009 12:57:11 -0700 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.175]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id n29Jv7xt011695; Mon, 9 Mar 2009 20:57:07 +0100 (MET) Original-Received: from localhost (localhost [127.0.0.1]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 29014136B6; Mon, 9 Mar 2009 20:57:07 +0100 (CET) X-Face: 'bg&jY[8V'W&:=~6w"|>}#4/T; w~36ei4NNMyKRR.a$n=$|sWFPF1y]a\>6kc\*#GN]UDM| Ywv, vbL^XF1nIp\:F=$Ei2o&mEe:%N~, :3]vtQ~s9u$9izmX$IF@VgGl7/, ^dbuM<3|AO2}.%|%?kZ 2Y=@\U!~cll^=8Z9ihKq%wmUe1Ky(#kl3T'>Qk0Ia3mCBsTk?E(,X Mail-Followup-To: Dan Nicolaescu , 2604@emacsbugs.donarmstrong.com In-Reply-To: <200903091748.n29HmjcZ018979@rodan.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 9 Mar 2009 10:48:45 -0700 (PDT)") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.1 (gnu/linux) X-DCC-dmv.com-Metrics: poseidon 1181; Body=2 Fuz1=2 Fuz2=2 X-Virus-Scanned: by amavisd-new X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 09 Mar 2009 16:23:44 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26186 Archived-At: On Mon, Mar 09 2009, Dan Nicolaescu wrote: > Reiner Steib writes: > > - D > > > > Instead of showing diff of revision at line (as in Emacs 22), I get: > > > > ,----[ *Messages* ] > > | vc-annotate-show-changeset-diff-revision-at-line: > > | The CVS backend does not support changeset diffs > > `---- > > > > Is this change intended? > > It is. > > > I could understand that `D' should now work > > on change sets, but please at least mention it in NEWS and tell the > > user to try `d' instead or better just display the warning and than > > call `vc-annotate-show-diff-revision-at-line' if no change set > > operation is available. > > I am not sure that is better. But if you can suggest a better wording > for the error message, go for it. How about this? (Same in `log-view-diff-changeset', probably.) --8<---------------cut here---------------start------------->8--- --- vc-annotate.el 09 Jan 2009 09:52:59 +0100 1.7 +++ vc-annotate.el 09 Mar 2009 20:35:28 +0100 @@ -506,7 +506,10 @@ "Visit the diff of the revision at line from its previous revision for all files in the changeset." (interactive) (when (eq 'file (vc-call-backend vc-annotate-backend 'revision-granularity)) - (error "The %s backend does not support changeset diffs" vc-annotate-backend)) + (error + (substitute-command-keys "The %s backend does not support changeset diffs. \ +Use \\[vc-annotate-show-diff-revision-at-line] to diff this file.") + vc-annotate-backend)) (vc-annotate-show-diff-revision-at-line-internal nil)) (defun vc-annotate-warp-revision (revspec) --8<---------------cut here---------------end--------------->8--- > > - L > > > > Instead of showing log of revision at line (as in Emacs 22), nothing > > happens. > > > > If there's no useful binding for `L', why not bind it to > > `vc-annotate-show-log-revision-at-line' or at least tell the user to > > use `l' (lowercase L) and also document it in NEWS. > > That would be a bad idea. Do you also consider the following as bad? If a future version actually has a useful command for `L', this can be removed. --8<---------------cut here---------------start------------->8--- --- vc-annotate.el.~1.7.~ 2009-01-09 09:52:59.000000000 +0100 +++ vc-annotate.el 2009-03-09 20:45:47.000000000 +0100 @@ -124,6 +124,12 @@ (define-key m "f" 'vc-annotate-find-revision-at-line) (define-key m "j" 'vc-annotate-revision-at-line) (define-key m "l" 'vc-annotate-show-log-revision-at-line) + (define-key m "L" + (lambda () + (interactive) + (error + (substitute-command-keys + "Use \\[vc-annotate-show-log-revision-at-line] to view log.")))) (define-key m "n" 'vc-annotate-next-revision) (define-key m "p" 'vc-annotate-prev-revision) (define-key m "w" 'vc-annotate-working-revision) --8<---------------cut here---------------end--------------->8--- > All the bindings for vc-annotate were upper case. And that was only > because vc-annotate was derived from `view-mode' which was binding > almost all lower case keys. With more keys to bind we can add > better functionality to vc-annotate (like the 'd' and 'D' bindings), > so it would be a bad idea to I agree that the lower case binding are better, but the transition should be made as smooth as possible. > Yes, it would take a tiny bit of effort for the users to get used to > the lower case bindings, but given that they are easier to type it > should not be too bad. My first reaction was that I really thought these feature won't work anymore Emacs 23 because of the (partial) rewrite of Emacs' VC system. > I'll make a note in NEWS about the changed bindings. Thanks. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/