* [patch] fix "in file included from" with gcc
@ 2010-01-10 4:52 Daniel Colascione
2010-01-10 22:58 ` Kevin Ryde
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Colascione @ 2010-01-10 4:52 UTC (permalink / raw
To: Emacs development discussions
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
The "in file included from" line is never an error; it's not even a
warning. It's just a pointer to an error.
Also, the original comment notwithstanding, it only seems to work when
we match
"in file included from" *before* we match the gnu style.
*** compile.el 2008-02-09 09:33:51.000000000 -0500
- --- new-compile.el 2010-01-09 23:50:18.000000000 -0500
***************
*** 218,223 ****
- --- 218,229 ----
nil 1 nil 2 0
(2 (compilation-face '(3))))
+ ;; The `gnu' style below can incorrectly match gcc's "In file
+ ;; included from" message, so we process this first.
+ (gcc-include
+ "^\\(?:In file included\\| \\) from \
+ \\(.+\\):\\([0-9]+\\)\\(?:\\(:\\)\\|\\(,\\)\\)?" 1 2 nil 0)
+
(gnu
;; I have no idea what this first line is supposed to match, but it
;; makes things ambiguous with output such as "foo:344:50:blabla"
since
***************
*** 237,248 ****
\[0-9]?\\(?:[^0-9\n]\\|$\\)\\|[0-9][0-9][0-9]\\)"
1 (2 . 5) (4 . 6) (7 . 8))
- - ;; The `gnu' style above can incorrectly match gcc's "In file
- - ;; included from" message, so we process that first. -- cyd
- - (gcc-include
- - "^\\(?:In file included\\| \\) from \
- - \\(.+\\):\\([0-9]+\\)\\(?:\\(:\\)\\|\\(,\\)\\)?" 1 2 nil (3 . 4))
- -
(lcc
"^\\(?:E\\|\\(W\\)\\), \\([^(\n]+\\)(\\([0-9]+\\),[ \t]*\\([0-9]+\\)"
2 3 4 (1))
- --- 243,248 ----
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (Darwin)
iEYEARECAAYFAktJXSQACgkQ17c2LVA10VtItwCdEA69LyVtbol10gu/Mg996SJB
Os0AoL+kcSGM3VhlfNCFtSf1oPYo6irR
=ko6C
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] fix "in file included from" with gcc
2010-01-10 4:52 [patch] fix "in file included from" with gcc Daniel Colascione
@ 2010-01-10 22:58 ` Kevin Ryde
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Ryde @ 2010-01-10 22:58 UTC (permalink / raw
To: Daniel Colascione; +Cc: emacs-devel
Daniel Colascione <daniel@censorshipresearch.org> writes:
>
> Also, the original comment notwithstanding, it only seems to work when
> we match
> "in file included from" *before* we match the gnu style.
This is http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3965
Last time I checked the gcc-include part had got better by itself
somehow.
The basic problem is the omake bit. It really ought to be driven only
by a symbol in compilation-error-regexp-alist, or alternately there
ought to be a cap on how many spaces worth of indentation it matches, as
surely it can't be meant to hit a big indent like the gcc-include.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-10 22:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-10 4:52 [patch] fix "in file included from" with gcc Daniel Colascione
2010-01-10 22:58 ` Kevin Ryde
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.