From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.help Subject: Re: line-move-visual Date: Wed, 16 Jun 2010 20:04:59 +0200 Organization: Organization?!? Message-ID: <87k4pysvjo.fsf@lola.goethe.zz> References: <089883ee-0a63-4cb4-a0ec-d2fe4e71cc03@y18g2000prn.googlegroups.com> <87wruco5yq.fsf@lola.goethe.zz> <87wrubfd8p.fsf@rapttech.com.au> <848w6ndwn0.fsf@cs.bham.ac.uk> <87d3vx5cku.fsf@gmail.com> <87bpbcrdk5.fsf@kuiper.lan.informatimago.com> <87wru0tn4d.fsf@lola.goethe.zz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1291836225 2477 80.91.229.12 (8 Dec 2010 19:23:45 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 8 Dec 2010 19:23:45 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Wed Dec 08 20:23:41 2010 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PQPc3-0007rv-HX for geh-help-gnu-emacs@m.gmane.org; Wed, 08 Dec 2010 20:23:40 +0100 Original-Received: from localhost ([127.0.0.1]:37118 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PQPc2-0006QR-Ud for geh-help-gnu-emacs@m.gmane.org; Wed, 08 Dec 2010 14:23:38 -0500 Original-Path: usenet.stanford.edu!news.tele.dk!news.tele.dk!small.news.tele.dk!newsfeed-0.progon.net!progon.net!newsfeed.ision.net!newsfeed2.easynews.net!ision!newsfeed.arcor.de!newsspool3.arcor-online.net!news.arcor.de.POSTED!not-for-mail Original-Newsgroups: gnu.emacs.help,comp.emacs X-Face: 2FEFf>]>q>2iw=B6, xrUubRI>pR&Ml9=ao@P@i)L:\urd*t9M~y1^:+Y]'C0~{mAl`oQuAl \!3KEIp?*w`|bL5qr,H)LFO6Q=qx~iH4DN; i"; /yuIsqbLLCh/!U#X[S~(5eZ41to5f%E@'ELIi$t^ Vc\LWP@J5p^rst0+('>Er0=^1{]M9!p?&:\z]|;&=NP3AhB!B_bi^]Pfkw User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:md8VuKGwdtdk9EA41roSpu2Gwwc= Original-Lines: 43 Original-NNTP-Posting-Date: 16 Jun 2010 20:05:05 CEST Original-NNTP-Posting-Host: 4ffbb64a.newsspool4.arcor-online.net Original-X-Trace: DXC=G^F0ab8ioVA2:OR3:3gaE@4IUK5MOK`al0oRJ??D6h\]6^?HikaZdhi?m9J Original-X-Complaints-To: usenet-abuse@arcor.de Original-Xref: usenet.stanford.edu gnu.emacs.help:179018 comp.emacs:100074 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:75879 Archived-At: Stefan Monnier writes: >> I should think that changing to logical mode when recording and >> replaying macros would be an improvement. I can't imagine anybody >> wanting visual mode in that case. > > I remember we discussed it and somehow it got rejected. I can't > remember the reason for it, and I personally don't care much either way > (my macros tend to use C-[aefb], and sexp-based movement but not much > C-[np]). > >> There is already one such change: vertical movement does not use vscroll >> in order to go smoothly through vertical material when macro recording >> or playback is active. > > Didn't know about that. Can you point me to the relevant piece of code? See around the ;; But don't vscroll in a keyboard macro. comment in lisp/simple.el: ;; This is like line-move-1 except that it also performs ;; vertical scrolling of tall images if appropriate. ;; That is not really a clean thing to do, since it mixes ;; scrolling with cursor motion. But so far we don't have ;; a cleaner solution to the problem of making C-n do something ;; useful given a tall image. (defun line-move (arg &optional noerror to-end try-vscroll) (unless (and auto-window-vscroll try-vscroll ;; Only vscroll for single line moves (= (abs arg) 1) ;; But don't vscroll in a keyboard macro. (not defining-kbd-macro) (not executing-kbd-macro) (line-move-partial arg noerror to-end)) (set-window-vscroll nil 0 t) (if line-move-visual (line-move-visual arg noerror) (line-move-1 arg noerror to-end)))) -- David Kastrup