From: Wojciech Meyer <wojciech.meyer@googlemail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: Wojciech Meyer <wojciech.meyer@googlemail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>,
Drew Adams <drew.adams@oracle.com>,
'Emacs-Devel devel' <emacs-devel@gnu.org>
Subject: Re: autoload cookies for defcustoms
Date: Mon, 30 Aug 2010 13:30:34 +0100 [thread overview]
Message-ID: <87k4n8z3it.fsf@gmail.com> (raw)
In-Reply-To: <4d7hj99qtc.fsf@fencepost.gnu.org> (Glenn Morris's message of "Sun, 29 Aug 2010 15:11:59 -0400")
Glenn Morris <rgm@gnu.org> writes:
> Wojciech Meyer wrote:
>
>> -;;;###autoload
>> +;; `defcustom' should not be autoloaded ;;;###autoload
>> (defcustom holiday-general-holidays
>
> The remaining calendar autoloaded defcustoms are generally autoloaded
> for a reason, and I imagine the same is true in many other cases. Did
> you just do a blanket replace, or did you check every case?
Did a blanket replace. (however in the example you showed me I see some
toplevel code evaluated). It is up to maintainers what to do with the
patch, it just shows `defcustoms' with `autoload'. I might refine it if
somebody comes up with rules to follow.
This approach was due to:
> > Just curious. Is there a policy, for the Lisp code distributed with
> > Emacs, about using autoload cookies for defcustoms? If so, what is it?
> AFAIK the policy is: "don't do it".
> It all too often introduces all kinds of nasty problems.
> More to the point, I welcome patches that remove tham.
> Stefan
Cheers;
Wojciech
next prev parent reply other threads:[~2010-08-30 12:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 18:31 autoload cookies for defcustoms Drew Adams
2010-01-23 20:24 ` Lennart Borgman
2010-01-23 20:38 ` Drew Adams
2010-01-25 2:56 ` Stefan Monnier
2010-01-25 5:13 ` Drew Adams
2010-01-25 15:31 ` Stefan Monnier
2010-01-25 20:36 ` Drew Adams
2010-01-26 2:05 ` Stefan Monnier
2010-01-26 3:12 ` Drew Adams
2010-01-26 11:51 ` Juanma Barranquero
2010-08-29 9:46 ` Wojciech Meyer
2010-08-29 19:11 ` Glenn Morris
2010-08-30 12:30 ` Wojciech Meyer [this message]
2010-08-30 15:54 ` Stefan Monnier
2010-08-30 23:20 ` Glenn Morris
2010-08-30 23:52 ` Wojciech Meyer
2010-08-31 3:32 ` Andy Wingo
2010-08-31 8:04 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k4n8z3it.fsf@gmail.com \
--to=wojciech.meyer@googlemail.com \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.