From: Rob Browning <rlb@defaultvalue.org>
To: bug-gnu-emacs@gnu.org
Cc: Svante Signell <srs@kth.se>,
debian-hurd@lists.debian.org, 610576@bugs.debian.org,
610576-forwarded@bugs.debian.org
Subject: Bug#610576: Re: Build of emacs_23.2+1-7
Date: Fri, 08 Apr 2011 23:07:59 -0500 [thread overview]
Message-ID: <87k4f42hk0.fsf@raven.defaultvalue.org> (raw)
In-Reply-To: <20110120011724.GF6722@const.famille.thibault.fr> (Samuel Thibault's message of "Thu, 20 Jan 2011 02:17:24 +0100")
[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]
(If possible, please preserve the 610576-forwarded address in any replies.)
It looks like there may be a problem with src/term.c on GNU/Hurd
systems.
Samuel Thibault <sthibault@debian.org> writes:
> Svante Signell, le Wed 19 Jan 2011 14:10:09 +0100, a écrit :
>> After installing emacs23 when trying to start it I get the following
>> error: (Googling did not give any useful.)
>> (Trying both xterm from a ssh login and hurd-console)
>>
>> user@kvm-hurd:~ emacs -nw
>> emacs: Not a tty device: /dev/tty
>
> There's bogus code there indeed:
>
> #ifdef O_IGNORE_CTTY
> if (!ctty)
> /* Open the terminal device. Don't recognize it as our
> controlling terminal, and don't make it the controlling tty
> if we don't have one at the moment. */
> fd = emacs_open (name, O_RDWR | O_IGNORE_CTTY | O_NOCTTY, 0);
> else
> #else
> /* Alas, O_IGNORE_CTTY is a GNU extension that seems to be only
> defined on Hurd. On other systems, we need to explicitly
> dissociate ourselves from the controlling tty when we want to
> open a frame on the same terminal. */
> fd = emacs_open (name, O_RDWR | O_NOCTTY, 0);
> #endif /* O_IGNORE_CTTY */
>
> tty->name = xstrdup (name);
>
> When O_IGNORE_CTTY is defined (which is the case only on GNU/Hurd...),
> the else branch is actually tty->name = xstrdup(name); ... The obvious
> fix is attached.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix-gnu-hurd-o-ignore-ctty.diff --]
[-- Type: text/x-diff, Size: 750 bytes --]
--- src/term.c.orig 2011-01-20 02:14:50.000000000 +0100
+++ src/term.c 2011-01-20 02:15:43.000000000 +0100
@@ -3428,13 +3428,12 @@ init_tty (char *name, char *terminal_typ
if we don't have one at the moment. */
fd = emacs_open (name, O_RDWR | O_IGNORE_CTTY | O_NOCTTY, 0);
else
-#else
+#endif /* O_IGNORE_CTTY */
/* Alas, O_IGNORE_CTTY is a GNU extension that seems to be only
defined on Hurd. On other systems, we need to explicitly
dissociate ourselves from the controlling tty when we want to
open a frame on the same terminal. */
fd = emacs_open (name, O_RDWR | O_NOCTTY, 0);
-#endif /* O_IGNORE_CTTY */
tty->name = xstrdup (name);
terminal->name = xstrdup (name);
[-- Attachment #3: Type: text/plain, Size: 223 bytes --]
See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=610576 for
additional information.
Thanks
--
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4
parent reply other threads:[~2011-04-09 4:07 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20110120011724.GF6722@const.famille.thibault.fr>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k4f42hk0.fsf@raven.defaultvalue.org \
--to=rlb@defaultvalue.org \
--cc=610576-forwarded@bugs.debian.org \
--cc=610576@bugs.debian.org \
--cc=bug-gnu-emacs@gnu.org \
--cc=debian-hurd@lists.debian.org \
--cc=srs@kth.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.