[patch] `org-pop-to-buffer-same-window' working with Emacs24

[patch] `org-pop-to-buffer-same-window' working with Emacs24

[Eric Schulte]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

Hi,

I assume this change was required due to changes in Emacs24, but I had
to remove an argument to pop-to-buffer-same-window in
org-pop-to-buffer-same-window to fix editing of source code snippets.

The patch is attached, although I'm not sure if it would break this
function for all other versions of Emacs.

Best -- Eric


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-remove-extra-argument-in-call-to-pop-to-buffer-same-.patch --]
[-- Type: text/x-diff, Size: 1004 bytes --]

From 6ed9419b73450d6b72392bb040a7ffeacd41f542 Mon Sep 17 00:00:00 2001
From: Eric Schulte <schulte.eric@gmail.com>
Date: Sat, 3 Sep 2011 14:01:49 -0600
Subject: [PATCH] remove extra argument in call to pop-to-buffer-same-window

* lisp/org-compat.el (org-pop-to-buffer-same-window): Remove extra
  argument in call to pop-to-buffer-same-window.
---
 lisp/org-compat.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/org-compat.el b/lisp/org-compat.el
index 3e9c202..3577db6 100644
--- a/lisp/org-compat.el
+++ b/lisp/org-compat.el
@@ -438,7 +438,7 @@ With two arguments, return floor and remainder of their quotient."
   "Pop to buffer specified by BUFFER-OR-NAME in the selected window."
   (if (fboundp 'pop-to-buffer-same-window)
       (funcall
-       'pop-to-buffer-same-window buffer-or-name norecord label)
+       'pop-to-buffer-same-window buffer-or-name norecord)
     (funcall 'switch-to-buffer buffer-or-name norecord)))
 
 (provide 'org-compat)
-- 
1.7.4.1


[-- Attachment #3: Type: text/plain, Size: 47 bytes --]


-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

Re: [patch] `org-pop-to-buffer-same-window' working with Emacs24

[Bastien]

Hi Eric,

Eric Schulte <schulte.eric@gmail.com> writes:

> I assume this change was required due to changes in Emacs24, but I had
> to remove an argument to pop-to-buffer-same-window in
> org-pop-to-buffer-same-window to fix editing of source code snippets.

Yes, I already applied this patch -- see commit 4a8634e1.  So the latest
Org version should work okay for you.

> The patch is attached, although I'm not sure if it would break this
> function for all other versions of Emacs.

I assume most people using latest Org version from git also uses latest
Emacs version...  but yes, we might have to improve compatibility in
this area.

Thanks,

-- 
 Bastien