From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#9438: grep regressions Date: Thu, 08 Sep 2011 23:18:05 +0300 Organization: JURTA Message-ID: <87k49irdoi.fsf@mail.jurta.org> References: <87vct8gmjj.fsf@mail.jurta.org> <87mxeg4kqz.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1315513274 8044 80.91.229.12 (8 Sep 2011 20:21:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 8 Sep 2011 20:21:14 +0000 (UTC) Cc: 9438@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 08 22:21:09 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R1l5v-0001CB-PC for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Sep 2011 22:21:07 +0200 Original-Received: from localhost ([::1]:44484 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1l5v-0003o0-96 for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Sep 2011 16:21:07 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:48527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1l5s-0003nk-CN for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2011 16:21:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R1l5r-0001h4-CA for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2011 16:21:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1l5r-0001h0-Aa for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2011 16:21:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R1l9j-0005Ax-07; Thu, 08 Sep 2011 16:25:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Sep 2011 20:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9438 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9438-submit@debbugs.gnu.org id=B9438.131551345119828 (code B ref 9438); Thu, 08 Sep 2011 20:25:02 +0000 Original-Received: (at 9438) by debbugs.gnu.org; 8 Sep 2011 20:24:11 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R1l8s-00059g-Nv for submit@debbugs.gnu.org; Thu, 08 Sep 2011 16:24:11 -0400 Original-Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R1l8p-00059S-Tz for 9438@debbugs.gnu.org; Thu, 08 Sep 2011 16:24:09 -0400 Original-Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 659C26E8096; Thu, 8 Sep 2011 13:20:07 -0700 (PDT) Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 14B4D451C461; Thu, 8 Sep 2011 13:20:05 -0700 (PDT) In-Reply-To: <87mxeg4kqz.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 07 Sep 2011 15:09:24 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 08 Sep 2011 16:25:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50723 Archived-At: > Beside `grep-error-screen-columns', I discovered two more unused defcustoms > in grep.el: > > (defcustom grep-window-height nil > "*Number of lines in a grep window. If nil, use `compilation-window-height'." > :type '(choice (const :tag "Default" nil) > integer) > :version "22.1" > :group 'grep) > > (defcustom grep-scroll-output nil > "*Non-nil to scroll the *grep* buffer window as output appears. > Setting it causes the grep commands to put point at the end of their > output window so that the end of the output is always visible rather > than the begining." > :type 'boolean > :version "22.1" > :group 'grep) > > IIUC, since the docstring says "If nil, use `compilation-window-height'" > they should be used in `grep-mode' only when the value is non-nil like: > > (when grep-window-height > (set (make-local-variable 'compilation-window-height) > grep-window-height)) > (when grep-scroll-output > (set (make-local-variable 'compilation-scroll-output) > grep-scroll-output)) According to bzr logs, before revno:54335 this used to be: (if grep-window-height (set (make-local-variable 'compilation-window-height) grep-window-height)) (set (make-local-variable 'compilation-scroll-output) grep-scroll-output) So either we should restore this code in `grep-process-setup' to use the customized values of defcustoms, or remove unused defcustoms. I have no settled opinion what would be better to do.