From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#10040: 24.0.91; isearch.el - binding of user options Date: Tue, 15 Nov 2011 21:17:06 +0200 Organization: JURTA Message-ID: <87k471p559.fsf@mail.jurta.org> References: <6857C0631DA84C638B3B9FA7F89B90D6@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1321384832 25457 80.91.229.12 (15 Nov 2011 19:20:32 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 15 Nov 2011 19:20:32 +0000 (UTC) Cc: 10040@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 15 20:20:28 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RQOYV-0001lY-RE for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Nov 2011 20:20:28 +0100 Original-Received: from localhost ([::1]:36563 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQOYV-0003px-DP for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Nov 2011 14:20:27 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:42118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQOYS-0003pr-17 for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2011 14:20:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RQOYQ-00021f-Qi for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2011 14:20:23 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQOYQ-00021b-PE for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2011 14:20:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RQOZ4-0000MO-8k for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2011 14:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Nov 2011 19:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10040 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10040-submit@debbugs.gnu.org id=B10040.13213848201331 (code B ref 10040); Tue, 15 Nov 2011 19:21:02 +0000 Original-Received: (at 10040) by debbugs.gnu.org; 15 Nov 2011 19:20:20 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RQOYN-0000LP-JI for submit@debbugs.gnu.org; Tue, 15 Nov 2011 14:20:20 -0500 Original-Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RQOYL-0000LI-JI for 10040@debbugs.gnu.org; Tue, 15 Nov 2011 14:20:18 -0500 Original-Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id E054F6E805F; Tue, 15 Nov 2011 11:19:35 -0800 (PST) Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id DA6EB451C3DB; Tue, 15 Nov 2011 11:19:27 -0800 (PST) In-Reply-To: <6857C0631DA84C638B3B9FA7F89B90D6@us.oracle.com> (Drew Adams's message of "Sun, 13 Nov 2011 11:26:45 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 15 Nov 2011 14:21:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:53942 Archived-At: > 3. And yet you do it, so perhaps you would like to consider code where > you do it as bugs. Assuming that, let me help by pointing out that you > do it in each of the Isearch help commands: isearch-help-for-help, > isearch-describe-bindings, and isearch-describe-key. The user options > you let-bind are `same-window-names' and `same-window-regexps'. As discussed recently in bug#3419, they should be replaced with `inhibit-same-window': === modified file 'lisp/isearch.el' --- lisp/isearch.el 2011-11-15 14:33:18 +0000 +++ lisp/isearch.el 2011-11-15 19:14:07 +0000 @@ -378,7 +378,7 @@ (make-help-screen isearch-help-for-help- (defun isearch-help-for-help () "Display Isearch help menu." (interactive) - (let (same-window-buffer-names same-window-regexps) + (let ((display-buffer-overriding-action '(nil (inhibit-same-window . t)))) (isearch-help-for-help-internal)) (isearch-update)) @@ -386,7 +386,7 @@ (defun isearch-describe-bindings () "Show a list of all keys defined in Isearch mode, and their definitions. This is like `describe-bindings', but displays only Isearch keys." (interactive) - (let (same-window-buffer-names same-window-regexps) + (let ((display-buffer-overriding-action '(nil (inhibit-same-window . t)))) (with-help-window "*Help*" (with-current-buffer standard-output (princ "Isearch Mode Bindings:\n") @@ -395,14 +395,14 @@ (defun isearch-describe-bindings () (defun isearch-describe-key () "Display documentation of the function invoked by isearch key." (interactive) - (let (same-window-buffer-names same-window-regexps) + (let ((display-buffer-overriding-action '(nil (inhibit-same-window . t)))) (call-interactively 'describe-key)) (isearch-update)) (defun isearch-describe-mode () "Display documentation of Isearch mode." (interactive) - (let (same-window-buffer-names same-window-regexps) + (let ((display-buffer-overriding-action '(nil (inhibit-same-window . t)))) (describe-function 'isearch-forward)) (isearch-update))