bug#10745: 24.0.93; Regression: org-meta-return does not honor vertical spacing in lists

bug#10745: 24.0.93; Regression: org-meta-return does not honor vertical spacing in lists

[Steve Revilak]

[-- Attachment #1.1: Type: text/plain, Size: 8180 bytes --]

This bug report will be sent to the Bug-GNU-Emacs mailing list
and the GNU bug tracker at debbugs.gnu.org.  Please check that
the From: line contains a valid email address.  After a delay of up
to one day, you should receive an acknowledgement at that address.

Please write in English if possible, as the Emacs maintainers
usually do not have translators for other languages.

Please describe exactly what actions triggered the bug, and
the precise symptoms of the bug.  If you can, give a recipe
starting from `emacs -Q':


I've found a case where org-mode fails to honor vertical list spacing
as it has in the past.  I've attached "example.org" for illustration.

Here are steps to reproduce the behavior I'm seeing:

(1) emacs -Q example.org

     After doing this, the major mode should be "Org", and the
     minibuffer should contain the text "OVERVIEW"

(2) Press SHIFT-TAB a few times, until the minibuffer contains the
     text "SHOW ALL".  At this point, example.org is fully expanded.

(3) Position point immediately after the word "bar1", on line 5.

(4) Press M-RET.  Org inserts a "-" on line 6.  The expected behavior
     (from prior versions) is that the "-" should be placed on line 7.

     In other words, pressing M-RET should leave a blank line when a
     list contains blank lines between items.  In emacs 24.0.93, org
     does not leave a blank line.

example-24.0.93.org contains the results of performing these steps
with emacs-24.0.93.

For contrast, example-24.0.92.org contains the results of performing
these steps with emacs-24.0.92.  example-24.0.92.org illustrates the
behavior I'm expecting to see.  Essentially, it's the positioning of
the new list element after "bar1".

I can share one additional observation.  In emacs-24.0.92

     C-h v org-blank-before-new-entry

contains the value 

    ((heading . auto)
     (plain-list-item . auto))

In emacs-24.0.93, "C-h v org-blank-before-new-entry" states:

    org-blank-before-new-entry is a variable defined in `org.el'.
    Its value is nil
    Original value was 
    ((heading . auto)
     (plain-list-item . auto))

Perhaps the value of org-blank-before-new-entry is getting clobbered?



If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
     `bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
/usr/local/emacs-24.0.93/share/emacs/24.0.93/etc/DEBUG.


In GNU Emacs 24.0.93.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.22.1)
  of 2012-02-05 on sunny
Windowing system distributor `The X.Org Foundation', version 11.0.10903000
Configured using:
  `configure '--prefix=/usr/local/emacs-24.0.93' 'CFLAGS=-DUNIV_DEBUG''

Important settings:
   value of $LC_ALL: nil
   value of $LC_COLLATE: C
   value of $LC_CTYPE: nil
   value of $LC_MESSAGES: nil
   value of $LC_MONETARY: nil
   value of $LC_NUMERIC: nil
   value of $LC_TIME: nil
   value of $LANG: en_US.UTF-8
   value of $XMODIFIERS: @im=local
   locale-coding-system: utf-8-unix
   default enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
   diff-auto-refine-mode: t
   shell-dirtrack-mode: t
   display-time-mode: t
   tooltip-mode: t
   mouse-wheel-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   column-number-mode: t
   line-number-mode: t

Recent input:
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
C-x b e m <tab> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> e x n <tab> <backspace> 
<tab> <return> <M-return> <backspace> <backspace> <backspace> 
<backspace> <up> <up> <up> <up> <up> <M-return> <backspace> 
<backspace> <backspace> <backspace> C-x C-s M-x c u 
C-g C-g C-x b <return> C-x b <return> C-h c o r <backspace> 
C-x C-s C-h v o r g - b a <backspace> l <tab> a <tab> 
<return> C-x o <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <return> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> C-x o <help-echo> <help-echo> 
<help-echo> <help-echo> <down-mouse-1> <mouse-movement> 
<mouse-1> <down-mouse-1> <mouse-1> C-x C-s C-x k <return> 
M-x r e o i r <backspace> <backspace> <backspace> p 
o r <tab> <return>

Recent messages:
o runs the command org-self-insert-command
Saving file /home/srevilak/example.org...
Wrote /home/srevilak/example.org
Making completion list...
Type C-x 1 to delete the help window.
Creating customization items...
Creating customization items ...done
Resetting customization items...done
Creating customization setup...done
(No changes need to be saved)

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr message sendmail rfc822 mml mml-sec
mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader
emacsbug cus-edit cus-start cus-load wid-edit pp find-func multi-isearch
tar-mode jka-compr epa epg epg-config help-mode view log-edit pcvs-util
add-log diff-mode vc ediff-merg ediff-diff ediff-wind ediff-help
ediff-util ediff-mult ediff-init ediff vc-dispatcher mule-util cal-move
parse-time reftex-vcr reftex-dcr reftex reftex-vars tex-mode compile
shell latexenc diary-lib diary-loaddefs cal-iso vc-git org-wl org-w3m
org-vm org-rmail org-mhe org-mew org-irc org-jsinfo org-infojs org-html
format-spec org-exp ob-exp org-exp-blocks org-info org-gnus org-docview
org-bibtex bibtex org-bbdb org-agenda org byte-opt warnings bytecomp
byte-compile cconv macroexp advice help-fns advice-preload ob-emacs-lisp
ob-tangle ob-ref ob-lob ob-table org-footnote org-src ob-comint ob-keys
ob ob-eval org-pcomplete pcomplete comint org-list org-faces org-compat
org-entities org-macs noutline outline easy-mmode cal-menu calendar
cal-loaddefs php-mode derived etags ring cc-langs cl cc-mode cc-fonts
cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs
regexp-opt speedbar sb-image ezimage dframe easymenu assoc edmacro
kmacro paren time time-date tooltip ediff-hook vc-hooks lisp-float-type
mwheel x-win x-dnd tool-bar dnd fontset image fringe lisp-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs
button faces cus-face files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process dbusbind dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty emacs)

[-- Attachment #1.2: example-24.0.92.org --]
[-- Type: text/plain, Size: 86 bytes --]

* First Heading

 - foo1

 - bar1

 - 

* Second heading

 - foo2
 - bar2

[-- Attachment #1.3: example-24.0.93.org --]
[-- Type: text/plain, Size: 84 bytes --]

* First Heading

 - foo1

 - bar1
 - 

* Second heading

 - foo2
 - bar2

[-- Attachment #1.4: example.org --]
[-- Type: text/plain, Size: 69 bytes --]

* First Heading

 - foo1

 - bar1

* Second heading

 - foo2
 - bar2

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

bug#10745: 24.0.93; Regression: org-meta-return does not honor vertical spacing in lists

[Glenn Morris]

Steve Revilak wrote:

> Perhaps the value of org-blank-before-new-entry is getting clobbered?

For a start, this:

org-footnote.el:(defvar org-blank-before-new-entry nil) ; silence byte-compiler

is bogus (the relevant syntax is (defvar foo)).

Probably so are these:

org-footnote.el:(defvar org-export-footnotes-seen nil) ; silence byte-compiler
org-footnote.el:(defvar org-export-footnotes-data nil) ; silence byte-compiler

bug#10745: 24.0.93; Regression: org-meta-return does not honor vertical spacing in lists

[Glenn Morris]

Steve Revilak wrote:

> Perhaps the value of org-blank-before-new-entry is getting clobbered?

For a start, this:

org-footnote.el:(defvar org-blank-before-new-entry nil) ; silence byte-compiler

is bogus (the relevant syntax is (defvar foo)).

Probably so are these:

org-footnote.el:(defvar org-export-footnotes-seen nil) ; silence byte-compiler
org-footnote.el:(defvar org-export-footnotes-data nil) ; silence byte-compiler

bug#10745: 24.0.93; Regression: org-meta-return does not honor vertical spacing in lists

[Steve Revilak]

[-- Attachment #1.1: Type: text/plain, Size: 373 bytes --]

>> Perhaps the value of org-blank-before-new-entry is getting clobbered?
>
>For a start, this:
>
>org-footnote.el:(defvar org-blank-before-new-entry nil) ; silence byte-compiler
>
>is bogus (the relevant syntax is (defvar foo)).

Glenn,

I believe you found it.

Applying the change in org-footnote.el.patch (attached) corrects the
vertical spacing issue I noticed.

Steve

[-- Attachment #1.2: org-footnote.el.patch --]
[-- Type: text/x-patch, Size: 499 bytes --]

--- org-footnote.el.ORIG	2012-02-06 21:53:00.068908112 -0500
+++ org-footnote.el	2012-02-06 21:54:01.472540988 -0500
@@ -475,7 +475,7 @@
       (org-footnote-create-definition label)
       (org-footnote-auto-adjust-maybe)))))
 
-(defvar org-blank-before-new-entry nil) ; silence byte-compiler
+(defvar org-blank-before-new-entry) ; silence byte-compiler
 (defun org-footnote-create-definition (label)
   "Start the definition of a footnote with label LABEL."
   (interactive "sLabel: ")

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

bug#10745: 24.0.93; Regression: org-meta-return does not honor vertical spacing in lists

[Steve Revilak]

[-- Attachment #1.1: Type: text/plain, Size: 373 bytes --]

>> Perhaps the value of org-blank-before-new-entry is getting clobbered?
>
>For a start, this:
>
>org-footnote.el:(defvar org-blank-before-new-entry nil) ; silence byte-compiler
>
>is bogus (the relevant syntax is (defvar foo)).

Glenn,

I believe you found it.

Applying the change in org-footnote.el.patch (attached) corrects the
vertical spacing issue I noticed.

Steve

[-- Attachment #1.2: org-footnote.el.patch --]
[-- Type: text/x-patch, Size: 499 bytes --]

--- org-footnote.el.ORIG	2012-02-06 21:53:00.068908112 -0500
+++ org-footnote.el	2012-02-06 21:54:01.472540988 -0500
@@ -475,7 +475,7 @@
       (org-footnote-create-definition label)
       (org-footnote-auto-adjust-maybe)))))
 
-(defvar org-blank-before-new-entry nil) ; silence byte-compiler
+(defvar org-blank-before-new-entry) ; silence byte-compiler
 (defun org-footnote-create-definition (label)
   "Start the definition of a footnote with label LABEL."
   (interactive "sLabel: ")

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

bug#10745: 24.0.93; Regression: org-meta-return does not honor vertical spacing in lists

[Chong Yidong]

Glenn Morris <rgm@gnu.org> writes:

this:
>
> org-footnote.el:(defvar org-blank-before-new-entry nil) ; silence byte-compiler
>
> is bogus (the relevant syntax is (defvar foo)).
>
> Probably so are these:
>
> org-footnote.el:(defvar org-export-footnotes-seen nil) ; silence byte-compiler
> org-footnote.el:(defvar org-export-footnotes-data nil) ; silence byte-compiler

I removed the bogus values.

Bastien, could you merge the fix to Org upstream?  Thanks.

bug#10745: 24.0.93; Regression: org-meta-return does not honor vertical spacing in lists

[Chong Yidong]

Glenn Morris <rgm@gnu.org> writes:

this:
>
> org-footnote.el:(defvar org-blank-before-new-entry nil) ; silence byte-compiler
>
> is bogus (the relevant syntax is (defvar foo)).
>
> Probably so are these:
>
> org-footnote.el:(defvar org-export-footnotes-seen nil) ; silence byte-compiler
> org-footnote.el:(defvar org-export-footnotes-data nil) ; silence byte-compiler

I removed the bogus values.

Bastien, could you merge the fix to Org upstream?  Thanks.