From: Chong Yidong <cyd@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 11348@debbugs.gnu.org
Subject: bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows
Date: Mon, 07 May 2012 16:01:15 +0800 [thread overview]
Message-ID: <87k40ov2r8.fsf@gnu.org> (raw)
In-Reply-To: <83fwbf5e8v.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 May 2012 09:33:04 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> I installed the patch below, which seems to fix this specific problem
>> (according to my testing under Wine ;-)
>
> I'm not sure why it worked for you, because it still doesn't for me.
I also still see the bug, running under Wine.
> IOW, the problem is that shell-parse-pcomplete-arguments removes the
> backslash in "d:\gnu", because the last alternative in the above
> regexp treats backslashes as escape characters, which on MS-DOS and
> MS-Windows is true (for shell commands) only when the backslash
> precedes a quote character (").
How about something like the following? (Works for me on Wine with your
test case, but I don't know if it breaks quoting.)
=== modified file 'lisp/shell.el'
*** lisp/shell.el 2012-05-05 04:18:49 +0000
--- lisp/shell.el 2012-05-07 07:59:33 +0000
***************
*** 397,402 ****
--- 397,408 ----
((null pcomplete-arg-quote-list)
(goto-char (match-beginning 3)) "\\")
((= (match-beginning 3) (match-end 3)) "\\")
+ ;; On Windows, the backslash is an escape
+ ;; character only if it precedes a quote char.
+ ((and (memq system-type
+ '(ms-dos windows-nt darwin cygwin))
+ (not (equal (match-string 3) "\"")))
+ (concat "/" (match-string 3)))
(t (match-string 3)))
arg))
((match-beginning 2) ;Double quote.
next prev parent reply other threads:[~2012-05-07 8:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 11:09 bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows Eli Zaretskii
2012-05-04 7:10 ` Eli Zaretskii
2012-05-04 14:29 ` Chong Yidong
2012-05-04 14:54 ` Eli Zaretskii
2012-05-04 15:07 ` Drew Adams
2012-05-04 15:36 ` Chong Yidong
2012-05-04 15:02 ` Eli Zaretskii
2012-05-04 15:46 ` Chong Yidong
2012-05-04 17:01 ` Eli Zaretskii
2012-05-04 17:59 ` Stefan Monnier
2012-05-04 18:15 ` Eli Zaretskii
2012-05-04 23:32 ` Stefan Monnier
2012-05-05 0:22 ` Drew Adams
2012-05-05 12:47 ` Eli Zaretskii
2012-05-05 4:20 ` Stefan Monnier
2012-05-05 6:33 ` Eli Zaretskii
2012-05-07 8:01 ` Chong Yidong [this message]
2012-05-07 17:40 ` Eli Zaretskii
2012-05-07 15:27 ` Stefan Monnier
2012-05-07 15:44 ` Drew Adams
2012-05-07 16:11 ` Chong Yidong
2012-05-08 0:27 ` Stefan Monnier
2012-05-08 18:56 ` Eli Zaretskii
2012-05-09 17:22 ` Stefan Monnier
2012-05-09 18:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k40ov2r8.fsf@gnu.org \
--to=cyd@gnu.org \
--cc=11348@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.