From: Chong Yidong <cyd@gnu.org>
To: Juri Linkov <juri@jurta.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: Interpretation of a space in regexp isearch?
Date: Fri, 31 Aug 2012 13:40:23 +0800 [thread overview]
Message-ID: <87k3wfipq0.fsf@gnu.org> (raw)
In-Reply-To: <87ehmnew8r.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 31 Aug 2012 03:07:08 +0300")
Juri Linkov <juri@jurta.org> writes:
> The following patch just echoes what was being said
> in this discussion so far. Please review it and decide
> what to do next.
Thanks, this mostly looks good. Some comments:
- search-whitespace should not be a defcustom, since it is altered by
commands like isearch-toggle-whitespace. Users can customize whether
to enable the feature by default setting search-whitespace-regexp to
either nil or a regexp. I think search-whitespace should be renamed
to something more accurate like isearch-lax-space-match, and made into
a defvar.
- Don't call the functions whitespace-search-forward; the whitespace-
prefix should be reserved for whitespace.el. Call it something like
isearch-forward-lax-space-match.
- Instead of [whitespace matching enabled/disabled], I suggest the
messages [strict space matching] and [lax space matching].
Also, I guess it won't be difficult to make M-s SPC work for regexp
search too, by making it change search-spaces-regexp. This can be left
for later.
next prev parent reply other threads:[~2012-08-31 5:40 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 4:40 Interpretation of a space in regexp isearch? Dmitry Gutov
2012-08-15 5:27 ` Bastien
2012-08-15 9:11 ` Dani Moncayo
2012-08-15 9:13 ` Dani Moncayo
2012-08-15 9:19 ` Dani Moncayo
2012-08-15 13:59 ` Drew Adams
2012-08-15 14:31 ` Davis Herring
2012-08-15 16:43 ` Drew Adams
2012-08-15 17:54 ` Davis Herring
2012-08-15 22:53 ` Dmitry Gutov
2012-08-15 23:21 ` Drew Adams
2012-08-16 2:25 ` Dmitry Gutov
2012-08-16 5:37 ` Drew Adams
2012-08-26 4:06 ` Chong Yidong
2012-08-26 6:59 ` Bastien
2012-08-26 15:19 ` Dani Moncayo
2012-08-26 17:31 ` Dani Moncayo
2012-08-28 8:28 ` Juri Linkov
2012-08-28 9:07 ` Dani Moncayo
2012-08-28 23:01 ` Juri Linkov
2012-08-27 18:34 ` Johan Bockgård
2012-08-28 8:30 ` Juri Linkov
2012-08-28 12:53 ` Stefan Monnier
2012-08-28 22:54 ` Juri Linkov
2012-08-28 23:52 ` Drew Adams
2012-08-29 8:38 ` Juri Linkov
2012-08-29 16:01 ` Drew Adams
2012-08-29 23:49 ` Juri Linkov
2012-08-30 8:19 ` Chong Yidong
2012-08-30 8:31 ` Chong Yidong
2012-08-30 8:54 ` Juri Linkov
2012-08-30 14:47 ` Stefan Monnier
2012-08-31 0:02 ` Juri Linkov
2012-08-31 0:07 ` Juri Linkov
2012-08-31 5:40 ` Chong Yidong [this message]
2012-08-31 9:31 ` Juri Linkov
2012-08-31 14:55 ` Chong Yidong
2012-09-01 0:47 ` Juri Linkov
2012-09-01 3:15 ` Chong Yidong
2012-09-01 11:50 ` Juri Linkov
2012-09-01 16:02 ` Chong Yidong
2012-08-29 6:46 ` Chong Yidong
2012-08-29 8:28 ` Juri Linkov
2012-08-29 13:55 ` Stefan Monnier
2012-08-29 15:11 ` Dani Moncayo
2012-08-29 23:51 ` Juri Linkov
2012-08-28 8:27 ` Juri Linkov
2012-08-29 6:59 ` Chong Yidong
2012-08-29 8:34 ` Juri Linkov
2012-08-30 9:01 ` Chong Yidong
2012-08-30 9:18 ` Juri Linkov
-- strict thread matches above, loose matches on Subject: below --
2012-08-14 23:45 Dmitry Gutov
2012-08-14 23:03 Bastien
2012-08-14 23:45 ` Davis Herring
2012-08-14 23:53 ` Bastien
2012-08-15 3:42 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3wfipq0.fsf@gnu.org \
--to=cyd@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=juri@jurta.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.