From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#11964: describe-char causes a fatal error (abort trap: 6) in non-windowed mode Date: Mon, 26 Nov 2012 11:55:32 +0800 Message-ID: <87k3t92f2j.fsf@gnu.org> References: <87bofcuo12.fsf@gnu.org> <87haogkf76.fsf@gnu.org> <97BC8D6C-F53B-4E18-9089-B4F8D7E39372@swipnet.se> <83k3tazwx2.fsf@gnu.org> <87fw3yb661.fsf@gnu.org> <3BA11CAB-DDBC-4F9A-9DBA-7BDA5F2182E2@swipnet.se> <83ehjhznft.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1353902184 32470 80.91.229.3 (26 Nov 2012 03:56:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 26 Nov 2012 03:56:24 +0000 (UTC) Cc: ninestraycats@gmail.com, 11964@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 26 04:56:36 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TcpoB-0003PW-UD for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Nov 2012 04:56:36 +0100 Original-Received: from localhost ([::1]:57787 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tcpo1-0004KF-3K for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Nov 2012 22:56:25 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:46554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tcpny-0004KA-Vq for bug-gnu-emacs@gnu.org; Sun, 25 Nov 2012 22:56:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tcpny-0002X7-1H for bug-gnu-emacs@gnu.org; Sun, 25 Nov 2012 22:56:22 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56887) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tcpnx-0002X2-U8 for bug-gnu-emacs@gnu.org; Sun, 25 Nov 2012 22:56:21 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TcppZ-00041X-UP for bug-gnu-emacs@gnu.org; Sun, 25 Nov 2012 22:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Nov 2012 03:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11964-submit@debbugs.gnu.org id=B11964.135390224615426 (code B ref 11964); Mon, 26 Nov 2012 03:58:01 +0000 Original-Received: (at 11964) by debbugs.gnu.org; 26 Nov 2012 03:57:26 +0000 Original-Received: from localhost ([127.0.0.1]:38905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tcpoy-00040j-Op for submit@debbugs.gnu.org; Sun, 25 Nov 2012 22:57:26 -0500 Original-Received: from mail-da0-f44.google.com ([209.85.210.44]:36355) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tcpou-00040Z-Nc for 11964@debbugs.gnu.org; Sun, 25 Nov 2012 22:57:22 -0500 Original-Received: by mail-da0-f44.google.com with SMTP id z20so1900382dae.3 for <11964@debbugs.gnu.org>; Sun, 25 Nov 2012 19:55:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=9Ntnn1J/IjB63z3Jj/1S+8Cbj0mTT2/AG14clQ1+WTY=; b=XzJopVEJjYedYkoj5z6CjlLuXWQh8kIXjYYz2YBAQkVDpGYtk6v93RHGGrkIHB01W/ EQ1/LeheQm3OT9r3M9R8QvreUxfcSyEi9dmhyu+s/wwWekQJnRutG2lxGm/XmW2vuI0l 11/V2fhfx794LsnKwr/7z1sMlAzmFD7YBUUxcQv9NPgDrcae3Hxg2Ryxvt07yUNyO7ng 5ltXwPS4dce0QSw9zfWjHymZJg0NvZA8lk8DYLTd3uNWZYg68lnCtu39WX8oh0xrf2Sd S9i+XYBHC4ny+Xaks97Ue6FASiRgYx5STZOyhetkZlHXr+0Y1dWQl19bPmsm2kdOAm80 zZsg== Original-Received: by 10.66.83.201 with SMTP id s9mr29038784pay.74.1353902139118; Sun, 25 Nov 2012 19:55:39 -0800 (PST) Original-Received: from ulysses ([155.69.17.27]) by mx.google.com with ESMTPS id uk9sm8000243pbc.63.2012.11.25.19.55.35 (version=SSLv3 cipher=OTHER); Sun, 25 Nov 2012 19:55:37 -0800 (PST) In-Reply-To: <83ehjhznft.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 25 Nov 2012 17:56:06 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67477 Archived-At: Eli Zaretskii writes: > It is wrong to call internal-char-font on a non-GUI frame; for > starters, that function might not be compiled in, e.g. if Emacs was > configured --without-x. All the other callers of that function are > careful not to do that. Does the patch below fix the problem? > > I also think internal-char-font should not blindly call the font > driver without checking that it isn't NULL first. Thanks for the patch. But I'm not sure this is 100% fixed yet: calling internal-char-font on a tty should not crash Emacs, since Lisp calls should never cause a crash. So I think internal-char-font should return nil if the seleced frame is non-graphical.