From: Stephen Berman <stephen.berman@gmx.net>
To: 13072@debbugs.gnu.org
Subject: bug#13072: 24.3.50; Fancy Diary display fontification failures
Date: Tue, 04 Dec 2012 01:01:15 +0100 [thread overview]
Message-ID: <87k3sybs8k.fsf@rosalinde.fritz.box> (raw)
In GNU Emacs 24.3.50.6 (x86_64-suse-linux-gnu, GTK+ Version 3.4.4)
of 2012-12-03 on rosalinde
Bzr revision: 111073 dmantipov@yandex.ru-20121203080602-hwv4fug7bvt2red7
Windowing system distributor `The X.Org Foundation', version 11.0.11203000
System Description: openSUSE 12.2 (x86_64)
Configured using:
`configure '--without-toolkit-scroll-bars' 'CFLAGS=-g3 -O0''
Important settings:
value of $LANG: en_US.UTF-8
value of $XMODIFIERS: @im=local
locale-coding-system: utf-8-unix
default enable-multibyte-characters: t
The doc string of calendar-date-display-form says:
For example, a typical American form would be
'(month "/" day "/" (substring year -2))
whereas
'((format "%9s, %9s %2s, %4s" dayname monthname day year))
would give the usual American style in fixed-length fields.
But if you set calendar-date-display-form to either of these values
(either via setq in your user-init-file or via the Custom interface),
then in the Fancy Diary display the date header line is not fontified.
To reproduce:
0. Let the file ~/diary consist of entries dated today, like these:
+------------------
| Dec 3, 2012 test1
| 12/3/2012 test2
| 12/3/12 test3
+------------------
1. emacs -Q
2. M-x calendar
3. In the *Calendar* buffer type `d' to get the Fancy Diary display, and
note the fontified date header:
+------------------
| Monday, December 3, 2012
| ========================
| test2
| test3
| test1
+------------------
4. Kill the *Fancy Diary Entries* buffer.
5. Type `M-x customize-option RET calendar-date-display-form RET',
change the value from the default `((if dayname (concat dayname ", "))
monthname " " day ", " year)' to `(month "/" day "/" (substring year
-2))', then repeat steps 2 and 3.
=> The date header in the Fancy Diary display is not fontified.
Now repeat steps 4 and 5, this time changing the value to `((format
"%9s, %9s %2s, %4s" dayname monthname day year))', then repeat steps 2
and 3 again.
=> Again, the date header in the Fancy Diary display is not fontified.
If you restore the default value and repeat steps 2 and 3, now the date
header is fontified again. (Note, too, the all the entries in the
~/diary have correctly fontified headers, regardless of the value of
calendar-date-display-form.)
I think these two cases (using `substring' and using `format' in the
value of calendar-date-display-form) fail to fontify for different
reasons:
- In the substring case, the problem is that in
diary-fancy-date-pattern, the form `(substring year -2)' is evaluated
with `year' let-bound to "3", which raises an args-out-of-range error,
short-circuiting fontification.
- In contrast, the `format' form returns a string with the variables
replaced by their let-bound values, which evaluates to itself and is
passed to replace-regexp-in-string, so diary-fancy-date-pattern
returns a valid regexp for the Fancy Diary header, so fontification
should occur AFAICT, yet it doesn't. However, this appears to depend
on the pattern and values of the width specifiers in the format
string, in a way I don't understand. From testing lots of
combinations, I found the following generalization appears to hold: if
the second `%s' sequence (corresponding to `monthname') has a width
specifier not greater than 8 (note that `monthname' evaluates to
"December", a string of 9 characters; I haven't tested other month
names yet) and the fourth `%s' sequence (corresponding to `year') has
a width specifier not greater than 1, then in the Fancy Diary display,
the date header is correctly fontified, regardless of the values (or
presence) of the first and third width specifiers (corresponding to
`dayname' and `day'); otherwise, fontification fails. (I haven't yet
tested different numbers of `%s' sequences.)
I have no idea what's going on with the `format' cases; but if an
explanation can be found for the behavior I described, which is
independent of how diary-fancy-date-pattern builds the regexp -- in
other words, if we assume that the regexp resulting from `format' in
general is valid for fontification, then the following patch, which
fixes the fontification failure in the `substring' case (and generalizes
it to all non-atomic sexps aside from `format' sexps) is one possible
half of the solution.
=== modified file 'lisp/calendar/diary-lib.el'
*** lisp/calendar/diary-lib.el 2012-11-27 15:40:49 +0000
--- lisp/calendar/diary-lib.el 2012-12-03 23:48:18 +0000
***************
*** 2461,2469 ****
;; string form"; eg the iso version calls string-to-number on some.
;; Therefore we cannot eg just let day = "[0-9]+". (Bug#8583).
;; Assumes no integers in c-day/month-name-array.
! (replace-regexp-in-string "[0-9]+" "[0-9]+"
! (mapconcat 'eval calendar-date-display-form "")
! nil t))
;; Optional ": holiday name" after the date.
"\\(: .*\\)?"))
--- 2461,2478 ----
;; string form"; eg the iso version calls string-to-number on some.
;; Therefore we cannot eg just let day = "[0-9]+". (Bug#8583).
;; Assumes no integers in c-day/month-name-array.
! (replace-regexp-in-string
! "[0-9]+" "[0-9]+"
! (mapconcat (lambda (x) (if (or (atom x) (eq (car x) 'format))
! (eval x)
! (catch 'end
! (while (consp x)
! (let ((y (pop x)))
! (when (or (eq y 'year) (eq y 'month)
! (eq y 'day))
! (throw 'end (eval y))))))))
! calendar-date-display-form "")
! nil t))
;; Optional ": holiday name" after the date.
"\\(: .*\\)?"))
next reply other threads:[~2012-12-04 0:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 0:01 Stephen Berman [this message]
2020-08-21 12:35 ` bug#13072: 24.3.50; Fancy Diary display fontification failures Lars Ingebrigtsen
2020-08-21 14:46 ` Stephen Berman
2020-08-22 13:26 ` Lars Ingebrigtsen
2020-08-25 18:02 ` Stephen Berman
2020-08-25 19:02 ` Lars Ingebrigtsen
2020-10-13 2:11 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3sybs8k.fsf@rosalinde.fritz.box \
--to=stephen.berman@gmx.net \
--cc=13072@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.