From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 13831@debbugs.gnu.org
Subject: bug#13831: 24.3.50; [PATCH] net-utils-mode have no revert-buffer function
Date: Wed, 27 Feb 2013 17:36:12 +0100 [thread overview]
Message-ID: <87k3ptbtoj.fsf@gmail.com> (raw)
In-Reply-To: <jwv38wh93wk.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 27 Feb 2013 10:25:42 -0500")
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>> Thanks Stefan, it is what I understood and it was fixed.
>
> Good. Do you still need help installing it (if so, please resend the
> patch because I haven't seen the updated version)?
Yes please, I only have a git repo of Emacs now.
Here the patch modified again, tested with netstat.
Let me know if you find something wrong.
You will find a (format "%s" program-name), it was here I don't know
why, I leave it, but it can probably be removed.
Also `net-utils-run-simple' was interactive with no arguments provided
interactively, which was wrong, I removed it.
Many functions are actually using `net-utils-run-program' and will not
have `revert-buffer' enabled, I corrected only `trace-route', but others
could be modified, that can be done later, it will be easy.
Thanks.
diff --git a/lisp/net/net-utils.el b/lisp/net/net-utils.el
index 28fd5c6..db5637b 100644
--- a/lisp/net/net-utils.el
+++ b/lisp/net/net-utils.el
@@ -285,7 +285,10 @@ This variable is only used if the variable
(define-derived-mode net-utils-mode special-mode "NetworkUtil"
"Major mode for interacting with an external network utility."
(set (make-local-variable 'font-lock-defaults)
- '((net-utils-font-lock-keywords))))
+ '((net-utils-font-lock-keywords)))
+ (set (make-local-variable 'revert-buffer-function)
+ 'net-utils-revert-function)
+ (define-key net-utils-mode-map (kbd "g") 'revert-buffer))
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Utility functions
@@ -354,21 +357,56 @@ This variable is only used if the variable
;; General network utilities (diagnostic)
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+(defvar net-utils-program-name nil)
+(defvar net-utils-program-args nil)
+(defvar net-utils-mode-process nil)
(defun net-utils-run-simple (buffer-name program-name args)
"Run a network utility for diagnostic output only."
- (interactive)
(when (get-buffer buffer-name)
(kill-buffer buffer-name))
(get-buffer-create buffer-name)
(with-current-buffer buffer-name
(net-utils-mode)
- (set-process-filter
- (apply 'start-process (format "%s" program-name)
- buffer-name program-name args)
- 'net-utils-remove-ctrl-m-filter)
+ (set (make-local-variable 'net-utils-program-name) program-name)
+ (set (make-local-variable 'net-utils-program-args) args)
+ (set (make-local-variable 'net-utils-mode-process)
+ (apply 'start-process (format "%s" program-name)
+ buffer-name program-name args))
+ (set-process-filter net-utils-mode-process
+ 'net-utils-remove-ctrl-m-filter)
(goto-char (point-min)))
(display-buffer buffer-name))
+(defun net-utils-revert-function (&optional ignore-auto noconfirm)
+ (message "Reverting `%s'..." (buffer-name))
+ (when net-utils-mode-process
+ (set-process-filter net-utils-mode-process t)
+ (delete-process net-utils-mode-process))
+ (let ((inhibit-read-only t))
+ (erase-buffer)
+ (setq net-utils-mode-process (apply 'start-process net-utils-program-name
+ (buffer-name) net-utils-program-name
+ net-utils-program-args))
+ (set-process-filter
+ net-utils-mode-process
+ #'(lambda (process output-string)
+ (let ((filtered-string output-string))
+ (set-buffer (process-buffer process))
+ (let ((inhibit-read-only t))
+ (while (string-match "\r" filtered-string)
+ (setq filtered-string
+ (replace-match "" nil nil filtered-string)))
+ (save-excursion
+ ;; Insert the text, moving the process-marker.
+ (goto-char (process-mark process))
+ (insert filtered-string)
+ (set-marker (process-mark process) (point)))))))
+ (set-process-sentinel
+ net-utils-mode-process
+ #'(lambda (process event)
+ (when (string= event "finished\n")
+ (message "Reverting `%s' done" (process-buffer process))))))))
+
;;;###autoload
(defun ifconfig ()
"Run ifconfig and display diagnostic output."
@@ -428,9 +466,8 @@ This variable is only used if the variable
(if traceroute-program-options
(append traceroute-program-options (list target))
(list target))))
- (net-utils-run-program
+ (net-utils-run-simple
(concat "Traceroute" " " target)
- (concat "** Traceroute ** " traceroute-program " ** " target)
traceroute-program
options)))
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
next prev parent reply other threads:[~2013-02-27 16:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 9:30 bug#13831: 24.3.50; [PATCH] net-utils-mode have no revert-buffer function Thierry Volpiatto
2013-02-27 9:48 ` Thierry Volpiatto
2013-02-27 10:11 ` Andreas Schwab
2013-02-27 10:50 ` Thierry Volpiatto
2013-02-27 11:57 ` Andreas Schwab
2013-02-27 12:03 ` Thierry Volpiatto
2013-02-27 14:08 ` Stefan Monnier
2013-02-27 14:35 ` Thierry Volpiatto
2013-02-27 15:25 ` Stefan Monnier
2013-02-27 16:36 ` Thierry Volpiatto [this message]
2013-02-28 4:51 ` Stefan Monnier
2013-02-28 6:18 ` Thierry Volpiatto
2013-02-28 14:04 ` Stefan Monnier
2013-02-28 19:45 ` Thierry Volpiatto
2013-03-01 3:05 ` Stefan Monnier
2013-03-01 7:02 ` Thierry Volpiatto
2013-03-01 14:29 ` Stefan Monnier
2013-03-01 15:22 ` Thierry Volpiatto
2013-03-01 17:28 ` Stefan Monnier
2013-03-01 19:07 ` Thierry Volpiatto
2013-03-11 18:31 ` Stefan Monnier
2013-03-13 14:43 ` Thierry Volpiatto
2013-03-13 17:52 ` Stefan Monnier
2013-03-13 20:12 ` Thierry Volpiatto
2013-03-03 6:16 ` Thierry Volpiatto
2013-03-01 14:30 ` Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3ptbtoj.fsf@gmail.com \
--to=thierry.volpiatto@gmail.com \
--cc=13831@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.