From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Engster Newsgroups: gmane.emacs.devel Subject: EIEIO split (was: A unified project root interface) Date: Sat, 23 Mar 2013 12:04:04 +0100 Message-ID: <87k3oyxtqz.fsf_-_@engster.org> References: <20130309174419.6e1cadb4@forcix.kollektiv-hamburg.de> <87sj3vv35h.fsf@engster.org> <20130316160203.6b889aba@forcix.kollektiv-hamburg.de> <87ehffuf1g.fsf@engster.org> <20130317001630.125e1987@forcix.kollektiv-hamburg.de> <87y5dmsz5u.fsf@engster.org> <20130317191817.764a44f5@forcix.kollektiv-hamburg.de> <87ppywtj9s.fsf@engster.org> <87li9juabi.fsf@engster.org> <87d2uvtdeb.fsf@engster.org> <874ng6tugb.fsf@engster.org> <87ppyurpxa.fsf@engster.org> <514A5A68.3070907@siege-engine.com> <514A8771.6080900@siege-engine.com> <514BBE19.9080008@siege-engine.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1364036656 9332 80.91.229.3 (23 Mar 2013 11:04:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 23 Mar 2013 11:04:16 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: "Eric M. Ludlam" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 23 12:04:40 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UJMFZ-0000Xs-Jg for ged-emacs-devel@m.gmane.org; Sat, 23 Mar 2013 12:04:37 +0100 Original-Received: from localhost ([::1]:59129 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJMFC-0002jE-38 for ged-emacs-devel@m.gmane.org; Sat, 23 Mar 2013 07:04:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJMF8-0002fs-49 for emacs-devel@gnu.org; Sat, 23 Mar 2013 07:04:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UJMF6-0001W0-TO for emacs-devel@gnu.org; Sat, 23 Mar 2013 07:04:09 -0400 Original-Received: from randomsample.de ([83.169.19.17]:39286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJMF6-0001Vi-Hg for emacs-devel@gnu.org; Sat, 23 Mar 2013 07:04:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=yGy3mcilU/N8Slgl7qqGC+TElAAeKxj/AAaffUCNHsk=; b=Foacbg2dwasRltGLMhaOhG/wL0/RSDXoWO/n/AMzkoe+0FIa0QOXhoPHCW7vjD0Xqd8eSNo26ULyMfabwyGwd5jlsayhdR/J5omxoGQLNyuYdYRn+KQlbMQ1Wh1yhSx3; Original-Received: from dslc-082-083-045-077.pools.arcor-ip.net ([82.83.45.77] helo=spaten) by randomsample.de with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1UJMF3-0007sD-HP; Sat, 23 Mar 2013 12:04:05 +0100 In-Reply-To: <514BBE19.9080008@siege-engine.com> (Eric M. Ludlam's message of "Thu, 21 Mar 2013 22:12:41 -0400") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3 (gnu/linux) Mail-Followup-To: "Eric M. Ludlam" , Stefan Monnier , emacs-devel@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 83.169.19.17 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158075 Archived-At: Eric M. Ludlam writes: > On 03/21/2013 12:07 AM, Eric M. Ludlam wrote: >> Hmmm, well, I managed to split EIEIO to no longer use eval-and-compile, >> and it is passing my unit tests, but not my integration tests. I made >> CEDET branch with this change in it in case someone wants to play with it. >> >> http://cedet.bzr.sourceforge.net/bzr/cedet/code/eieiosplit/files/head%3A/lisp/eieio/ >> >> >> Getting the integration tests to pass is more than I have time for >> tonight though. > > I found the fix for the integration tests, and have been running on > this branch this evening. I also removed the eval-and-compile from > the defclass macro. All builds and tests seem to run fine. > > I did some basic dev with it, and seems to be working fine. > > If anyone has comments on this branch, or thoughts that will make it > better, let me know. I think this is a very good change and should be merged, since this will also fix bug #13813 on our side. -David