From: Sergio Durigan Junior <sergiodj@riseup.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 14847@debbugs.gnu.org
Subject: bug#14847: 24.1; gdb-mi.el does not handle backslashes as quotes
Date: Fri, 12 Jul 2013 12:51:24 -0300 [thread overview]
Message-ID: <87k3kvzshv.fsf@riseup.net> (raw)
In-Reply-To: <83hag05fhi.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Jul 2013 11:50:33 +0300")
On Friday, July 12 2013, Eli Zaretskii wrote:
> Your patch doesn't seem to work for me. I tried on GNU/Linux and on
> MS-Windows, and in both cases I get the same error. Here's the recipe
> I tried (after applying your latest patch and rebuilding Emacs):
>
> emacs -Q
> M-x gdb RET
> gdb -i=mi ./src/emacs RET
> (gdb) break main
> (gdb) run \
> -Q
>
> When I type RET after "-Q", I get an error:
>
> Undefined MI command: Q
>
> What am I doing wrong?
Hi Eli,
Thanks for testing! You're doing nothing wrong, the patch is the
culprit. `gdb-send' checks for commands starting with "-", but this
check should be disabled when a command is being continued.
Could you please try the following version?
Thanks,
--
Sergio
diff --git a/lisp/progmodes/gdb-mi.el b/lisp/progmodes/gdb-mi.el
index 2c4d6a0..10472ec 100644
--- a/lisp/progmodes/gdb-mi.el
+++ b/lisp/progmodes/gdb-mi.el
@@ -1759,6 +1759,9 @@ static char *magick[] = {
As long as GDB is in the recursive reading loop, it does not expect
commands to be prefixed by \"-interpreter-exec console\".")
+(defun gdb-strip-string-backslash (string)
+ (replace-regexp-in-string "\\\\$" "" string))
+
(defun gdb-send (proc string)
"A comint send filter for gdb."
(with-current-buffer gud-comint-buffer
@@ -1766,10 +1769,15 @@ commands to be prefixed by \"-interpreter-exec console\".")
(remove-text-properties (point-min) (point-max) '(face))))
;; mimic <RET> key to repeat previous command in GDB
(if (not (string= "" string))
- (setq gdb-last-command string)
- (if gdb-last-command (setq string gdb-last-command)))
- (if (or (string-match "^-" string)
- (> gdb-control-level 0))
+ (if gdb-continuation
+ (setq gdb-last-command (concat gdb-continuation
+ (gdb-strip-string-backslash string)
+ " "))
+ (setq gdb-last-command (gdb-strip-string-backslash string)))
+ (if gdb-last-command (setq string gdb-last-command))
+ (setq gdb-continuation nil))
+ (if (and (not gdb-continuation) (or (string-match "^-" string)
+ (> gdb-control-level 0)))
;; Either MI command or we are feeding GDB's recursive reading loop.
(progn
(setq gdb-first-done-or-error t)
@@ -1779,10 +1787,13 @@ commands to be prefixed by \"-interpreter-exec console\".")
(setq gdb-control-level (1- gdb-control-level))))
;; CLI command
(if (string-match "\\\\$" string)
- (setq gdb-continuation (concat gdb-continuation string "\n"))
+ (setq gdb-continuation
+ (concat gdb-continuation (gdb-strip-string-backslash
+ string)
+ " "))
(setq gdb-first-done-or-error t)
(let ((to-send (concat "-interpreter-exec console "
- (gdb-mi-quote string)
+ (gdb-mi-quote (concat gdb-continuation string " "))
"\n")))
(if gdb-enable-debug
(push (cons 'mi-send to-send) gdb-debug-log))
next prev parent reply other threads:[~2013-07-12 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 3:51 bug#14847: 24.1; gdb-mi.el does not handle backslashes as quotes Sergio Durigan Junior
2013-07-12 8:50 ` Eli Zaretskii
2013-07-12 15:51 ` Sergio Durigan Junior [this message]
2013-07-12 18:20 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3kvzshv.fsf@riseup.net \
--to=sergiodj@riseup.net \
--cc=14847@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.