From: Christopher Schmidt <christopher@ch.ristopher.com>
To: 14744@debbugs.gnu.org
Subject: bug#14744: 24.3.50; Flickering mouse-face on process output
Date: Sat, 3 Aug 2013 13:25:39 +0100 (BST) [thread overview]
Message-ID: <87k3k37yg6@ch.ristopher.com> (raw)
In-Reply-To: <83ioznxdq2.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 03 Aug 2013 13:36:53 +0300")
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
> In the absence of a solution for all of them, fixing some of them
> would be good nevertheless. comint is a widely used infrastructure,
> so modifying it is likely to solve quite a few of those cases.
How about this:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff, Size: 3401 bytes --]
--- lisp/comint.el
+++ lisp/comint.el
@@ -636,7 +636,7 @@
(setq-local comint-last-input-start (point-min-marker))
(setq-local comint-last-input-end (point-min-marker))
(setq-local comint-last-output-start (make-marker))
- (make-local-variable 'comint-last-prompt-overlay)
+ (make-local-variable 'comint-last-prompt)
(make-local-variable 'comint-prompt-regexp) ; Don't set; default
(make-local-variable 'comint-input-ring-size) ; ...to global val.
(make-local-variable 'comint-input-ring)
@@ -1902,21 +1902,24 @@
"If nil, Comint will interpret `carriage control' characters in output.
See `comint-carriage-motion' for details.")
-;; When non-nil, this is an overlay over the last recognized prompt in
-;; the buffer; it is used when highlighting the prompt.
-(defvar comint-last-prompt-overlay nil)
+(defvar comint-last-prompt nil
+ "Markers pointing to the last prompt.
+If non-nil, a cons cell containing markers. The car points to
+the start, the cdr to the end of the last prompt recognized.")
(defun comint-snapshot-last-prompt ()
- "`snapshot' any current `comint-last-prompt-overlay'.
-Freeze its attributes in place, even when more input comes along
-and moves the prompt overlay."
- (when comint-last-prompt-overlay
- (let ((inhibit-read-only t))
- (with-silent-modifications
- (add-text-properties
- (overlay-start comint-last-prompt-overlay)
- (overlay-end comint-last-prompt-overlay)
- (overlay-properties comint-last-prompt-overlay))))))
+ "Snapshot the current `comint-last-prompt'.
+Freezes the `font-lock-face' text property in place."
+ (when comint-last-prompt
+ (with-silent-modifications
+ (add-text-properties
+ (car comint-last-prompt)
+ (cdr comint-last-prompt)
+ '(font-lock-face comint-highlight-prompt)))
+ ;; Reset comint-last-prompt so later on comint-output-filter does
+ ;; not remove the font-lock-face text property of the previous
+ ;; (this) prompt.
+ (setq comint-last-prompt nil)))
(defun comint-carriage-motion (start end)
"Interpret carriage control characters in the region from START to END.
@@ -2063,20 +2066,15 @@
(add-text-properties
prompt-start (point)
'(read-only t rear-nonsticky t front-sticky (read-only)))))
- (unless (and (bolp) (null comint-last-prompt-overlay))
- ;; Need to create or move the prompt overlay (in the case
- ;; where there is no prompt ((bolp) == t), we still do
- ;; this if there's already an existing overlay).
- (if comint-last-prompt-overlay
- ;; Just move an existing overlay
- (move-overlay comint-last-prompt-overlay
- prompt-start (point))
- ;; Need to create the overlay
- (setq comint-last-prompt-overlay
- (make-overlay prompt-start (point)))
- (overlay-put comint-last-prompt-overlay
- 'font-lock-face 'comint-highlight-prompt))))
-
+ (when comint-last-prompt
+ (remove-text-properties (car comint-last-prompt)
+ (cdr comint-last-prompt)
+ '(font-lock-face)))
+ (setq comint-last-prompt
+ (cons (copy-marker prompt-start) (point-marker)))
+ (add-text-properties (car comint-last-prompt)
+ (cdr comint-last-prompt)
+ '(font-lock-face comint-highlight-prompt)))
(goto-char saved-point)))))))
(defun comint-preinput-scroll-to-bottom ()
[-- Attachment #3: Type: text/plain, Size: 21 bytes --]
Christopher
next prev parent reply other threads:[~2013-08-03 12:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-29 0:10 bug#14744: 24.3.50; Flickering mouse-face on process output Christopher Schmidt
2013-06-29 7:46 ` Eli Zaretskii
2013-06-29 9:47 ` Christopher Schmidt
2013-06-29 10:35 ` Stephen Berman
2013-06-29 11:41 ` Eli Zaretskii
2013-06-29 12:56 ` Christopher Schmidt
2013-06-29 14:45 ` Eli Zaretskii
2013-08-03 9:41 ` Christopher Schmidt
2013-08-03 10:36 ` Eli Zaretskii
2013-08-03 12:25 ` Christopher Schmidt [this message]
2013-08-03 12:41 ` Eli Zaretskii
2013-08-03 12:56 ` Christopher Schmidt
2013-08-03 13:12 ` Eli Zaretskii
2020-08-25 11:01 ` Lars Ingebrigtsen
2013-06-29 15:08 ` Stefan Monnier
2013-06-29 15:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3k37yg6@ch.ristopher.com \
--to=christopher@ch.ristopher.com \
--cc=14744@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.