From: Nathan Trapuzzano <nbtrap@nbtrap.com>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 15778@debbugs.gnu.org
Subject: bug#15778: 24.3; cperl-mode causes emacs to lock up
Date: Sun, 03 Nov 2013 08:59:02 -0500 [thread overview]
Message-ID: <87k3gpsi1l.fsf@nbtrap.com> (raw)
In-Reply-To: <87a9hlwqkq.fsf@rosalinde.fritz.box> (Stephen Berman's message of "Sun, 03 Nov 2013 14:41:09 +0100")
[-- Attachment #1: Type: text/plain, Size: 829 bytes --]
Stephen Berman <stephen.berman@gmx.net> writes:
> I also tried and failed to get Edebug to kick in here, but I did make an
> observation that surprised me but I assume is somehow relevant: if I
> start Emacs with -Q, insert your sample perl code in a new buffer,
> invoke cperl-mode, go to line 44 and type C-k, Emacs hangs, as you
> discovered -- but if, after starting with -Q and inserting the sample
> code I first invoke perl-mode and after the buffer fontifies invoke
> cperl-mode, now when I go to line 44, C-k kills the line as it should
> and there is no other problem, even if I then change the buffer to some
> other mode and then back to cperl-mode again.
Since there seems to be inconsistend behavior, would you mind trying my
patch and making sure none of the scenarios you've tried so far causes
Emacs to hang?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: cperl-mode.patch --]
[-- Type: text/x-diff, Size: 1593 bytes --]
From 0b73932e90496e0477eddce6ba7e87d2137cb730 Mon Sep 17 00:00:00 2001
From: Nathan Trapuzzano <nbtrap@nbtrap.com>
Date: Sun, 3 Nov 2013 08:44:36 -0500
Subject: [PATCH] * progmodes/cperl-mode.el
(cperl-font-lock-fontify-region-function): Don't infloop when expanding
region over `multiline' syntax-type that begins a line. (Bug#15778)
---
lisp/ChangeLog | 7 +++++++
lisp/progmodes/cperl-mode.el | 5 +++--
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 6a91465..b047b57 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,10 @@
+2013-11-03 Nathan Trapuzzano <nbtrap@nbtrap.com>
+
+ * progmodes/cperl-mode.el
+ (cperl-font-lock-fontify-region-function): Don't infloop when
+ expanding region over `multiline' syntax-type that begins a line.
+ (Bug#15778)
+
2013-11-02 Glenn Morris <rgm@gnu.org>
* Makefile.in (EMACS): Use a relative filename.
diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el
index 8a7d1e7..36b05c8 100644
--- a/lisp/progmodes/cperl-mode.el
+++ b/lisp/progmodes/cperl-mode.el
@@ -8900,8 +8900,9 @@ do extra unwind via `cperl-unwind-to-safe'."
(beginning-of-line)
(eq (get-text-property (setq beg (point)) 'syntax-type)
'multiline)))
- (if (setq beg (cperl-beginning-of-property beg 'syntax-type))
- (goto-char beg)))
+ (let ((new-beg (cperl-beginning-of-property beg 'syntax-type)))
+ (setq beg (if (= new-beg beg) nil new-beg))
+ (goto-char new-beg)))
(setq beg (point))
(goto-char end)
(while (and end
--
1.8.4.2
next prev parent reply other threads:[~2013-11-03 13:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 11:19 bug#15778: 24.3; cperl-mode causes emacs to lock up Nathan Trapuzzano
2013-11-01 11:46 ` Eli Zaretskii
2013-11-01 12:16 ` Nathan Trapuzzano
2013-11-01 14:41 ` Eli Zaretskii
2013-11-01 14:59 ` Nathan Trapuzzano
2013-11-01 16:26 ` Eli Zaretskii
2013-11-01 17:21 ` Nathan Trapuzzano
2013-11-01 20:23 ` Stephen Berman
2013-11-03 0:00 ` Stephen Berman
2013-11-03 12:00 ` Nathan Trapuzzano
2013-11-03 13:41 ` Stephen Berman
2013-11-03 13:59 ` Nathan Trapuzzano [this message]
2013-11-03 19:39 ` Stephen Berman
2013-11-03 19:48 ` Nathan Trapuzzano
2013-11-03 22:22 ` Stephen Berman
2013-11-03 22:50 ` Nathan Trapuzzano
2013-11-04 1:48 ` Stefan Monnier
2013-11-04 2:29 ` Nathan Trapuzzano
2013-11-04 3:52 ` Stefan Monnier
2013-11-03 14:15 ` Stefan Monnier
2013-11-03 14:23 ` Nathan Trapuzzano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3gpsi1l.fsf@nbtrap.com \
--to=nbtrap@nbtrap.com \
--cc=15778@debbugs.gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.