all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 16090@debbugs.gnu.org, Andreas Politz <politza@hochschule-trier.de>
Subject: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark
Date: Tue, 10 Dec 2013 08:53:38 +0100	[thread overview]
Message-ID: <87k3fdcfb1.fsf@tsdh.uni-koblenz.de> (raw)
In-Reply-To: <jwvmwk9ctet.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Mon, 09 Dec 2013 21:51:48 -0500")

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> The reason is that the buffer is not yet displayed, when
>> doc-view-bookmark-jump tries to change the page.  This results in,
>> for obscure reasons, trying to change the page in which ever window
>> is currently selected.  Solution: Defer changing the page after
>> bookmark--jump-via has displayed the page.
>
> Thanks for the report.  And thanks for the patch, tho it shouldn't be
> installed as is: using a timer is not a good solution.  The code is
> already equipped to handle non-displayed buffers (it keeps track of
> the "default current page" which is later used when/if the buffer gets
> displayed in a window).

Yes, but I think that doesn't suffice.  The problem with bookmarks is
that the display window function is run after the bookmark handler, so
we have no clue in which window the bookmarked page is going to be
shown.  It may be the current window, an existing other window (which
might already show another page of the doc and thus already has an entry
in `image-mode-winprops-alist'), or a completely new window.

Bye,
Tassilo





  reply	other threads:[~2013-12-10  7:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-08 16:54 bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark Andreas Politz
2013-12-09  9:13 ` Tassilo Horn
2013-12-09 12:33   ` Andreas Politz
2013-12-09 14:56     ` Tassilo Horn
2013-12-09 16:55   ` Glenn Morris
2013-12-10  7:28     ` Tassilo Horn
2013-12-10  2:51 ` Stefan Monnier
2013-12-10  7:53   ` Tassilo Horn [this message]
2013-12-10 10:02     ` Andreas Politz
2013-12-10 11:58       ` Andreas Politz
2013-12-10 16:56     ` Andreas Politz
2013-12-10 20:07       ` Tassilo Horn
2013-12-10 22:16         ` Andreas Politz
2013-12-11  4:43     ` Stefan Monnier
2013-12-11 19:08       ` Tassilo Horn
2013-12-20  8:00 ` Tassilo Horn
2013-12-20  8:28   ` Andreas Politz
2013-12-20 13:02     ` Tassilo Horn
2014-04-02 14:43       ` Stefan Monnier
2014-04-04 13:43         ` Tassilo Horn
2014-04-04 15:14           ` Stefan Monnier
2014-04-04 15:53             ` Tassilo Horn
2014-04-04 16:04               ` Glenn Morris
2014-04-04 17:44                 ` Tassilo Horn
2013-12-20 14:33   ` Stefan Monnier
2013-12-20 14:36     ` Tassilo Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k3fdcfb1.fsf@tsdh.uni-koblenz.de \
    --to=tsdh@gnu.org \
    --cc=16090@debbugs.gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    --cc=politza@hochschule-trier.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.