* bug#12931: a bug in Emacs for Windows (win32fns.c: x-file-dialog)
@ 2012-11-19 13:53 Du Yanning
2012-11-19 19:08 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Du Yanning @ 2012-11-19 13:53 UTC (permalink / raw)
To: 12931
[-- Attachment #1: Type: text/plain, Size: 584 bytes --]
x-file-dialog uses GetOpenFileName to get a file name.
If you have a buffer that is not visiting any file, when you call
save-buffer through a tool-bar button, x-file-dialog gets called.
However, with GetOpenFileName, you must select an existing file.
We can fix this bug by minimum change.
in x-file-dialog (defined in win32fns.c)
change the line:
file_opened = GetOpenFileName (file_details);
to
if (!NILP (mustmatch))
{
file_opened = GetOpenFileName (file_details);
}
else
{
file_opened = GetSaveFileName (file_details);
}
[-- Attachment #2: Type: text/html, Size: 664 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#12931: a bug in Emacs for Windows (win32fns.c: x-file-dialog)
2012-11-19 13:53 bug#12931: a bug in Emacs for Windows (win32fns.c: x-file-dialog) Du Yanning
@ 2012-11-19 19:08 ` Eli Zaretskii
[not found] ` <CALr_ej2asGEUoTkBRPyryMMm7dFVtmYuixPt+nuXoPV+gYs0sw@mail.gmail.com>
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2012-11-19 19:08 UTC (permalink / raw)
To: Du Yanning; +Cc: 12931
> Date: Mon, 19 Nov 2012 21:53:02 +0800
> From: Du Yanning <duyanning@gmail.com>
>
> x-file-dialog uses GetOpenFileName to get a file name.
> If you have a buffer that is not visiting any file, when you call
> save-buffer through a tool-bar button, x-file-dialog gets called.
> However, with GetOpenFileName, you must select an existing file.
>
> We can fix this bug by minimum change.
>
> in x-file-dialog (defined in win32fns.c)
>
> change the line:
>
> file_opened = GetOpenFileName (file_details);
>
> to
>
> if (!NILP (mustmatch))
> {
> file_opened = GetOpenFileName (file_details);
> }
> else
> {
> file_opened = GetSaveFileName (file_details);
> }
Thanks. However, looking at the current code, I see this:
file_details->Flags = (OFN_HIDEREADONLY | OFN_NOCHANGEDIR
| OFN_EXPLORER | OFN_ENABLEHOOK);
if (!NILP (mustmatch))
{
/* Require that the path to the parent directory exists. */
file_details->Flags |= OFN_PATHMUSTEXIST;
/* If we are looking for a file, require that it exists. */
if (NILP (only_dir_p))
file_details->Flags |= OFN_FILEMUSTEXIST;
}
which means that the OFN_FILEMUSTEXIST and OFN_PATHMUSTEXIST flags are
_not_ set if mustmatch is nil. Are you saying that GetOpenFileName
requires the file to exist, even though these flags are not set? This
seems to contradict the MSDN documentation at
http://msdn.microsoft.com/en-us/library/windows/desktop/ms646839%28v=vs.85%29.aspx
Or are you saying that the mustmatch flag is set incorrectly when the
buffer is not visiting a file?
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-06 6:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-19 13:53 bug#12931: a bug in Emacs for Windows (win32fns.c: x-file-dialog) Du Yanning
2012-11-19 19:08 ` Eli Zaretskii
[not found] ` <CALr_ej2asGEUoTkBRPyryMMm7dFVtmYuixPt+nuXoPV+gYs0sw@mail.gmail.com>
2012-11-20 16:18 ` Eli Zaretskii
2014-02-06 1:38 ` Lars Ingebrigtsen
2014-02-06 6:16 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.