From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-orgmode@gnu.org
Cc: Bastien <bzg@gnu.org>, Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: One broken property drawer prevents setting of any property
Date: Fri, 23 May 2014 16:55:26 +0800 [thread overview]
Message-ID: <87k39cnabl.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87k39df36v.fsf@bzg.ath.cx> (Bastien's message of "Fri, 23 May 2014 07:56:40 +0200")
[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]
Bastien <bzg@gnu.org> writes:
> Hi Eric,
>
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> By passing the FORCE argument to `org-get-property-block', the broken
>> block ends up getting silently repaired, and everything works as normal.
>
> Can you show this as a patch?
>
>> I'm not sure, however, that silently repairing things without the user's
>> knowledge is the right thing to do...
>
> We can warn the user with a temporary message, or ask him for
> confirmation. Or provide a helper command to repair drawers and
> advertize it instead of throwing an error.
>
> I'll look into this after you send me the patch.
The more I thought about it, the more it seemed the silent repair is a
bad idea: it's not really repair, it's just sticking a new :END: in, and
will very likely result in cruft in the buffer. This patch wraps the
scan in catch/throw and asks users if they want to repair broken
drawers. Since the y-or-no-p stops at the broken drawer, it should be
useful for manual fixing.
E
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Warn-users-of-malformed-property-drawers.patch --]
[-- Type: text/x-diff, Size: 1443 bytes --]
From 3995f4816ba400f5c7645f84b5dcf7e84698d604 Mon Sep 17 00:00:00 2001
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Date: Fri, 23 May 2014 16:52:58 +0800
Subject: [PATCH] Warn users of malformed property drawers
org.el (org-buffer-property-keys): When scanning the buffer for valid
property keys, give users a chance to repair any malformed property
drawers.
---
lisp/org.el | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index b16515e..a3f0cba 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -15712,12 +15712,17 @@ formats in the current buffer."
(widen)
(goto-char (point-min))
(while (re-search-forward org-property-start-re nil t)
- (setq range (org-get-property-block))
- (goto-char (car range))
- (while (re-search-forward org-property-re
- (cdr range) t)
- (add-to-list 'rtn (org-match-string-no-properties 2)))
- (outline-next-heading))))
+ (catch 'cont
+ (setq range (or (org-get-property-block)
+ (if (y-or-n-p
+ (format "Malformed drawer at %d, repair?" (point)))
+ (org-get-property-block nil nil t)
+ (throw 'cont nil))))
+ (goto-char (car range))
+ (while (re-search-forward org-property-re
+ (cdr range) t)
+ (add-to-list 'rtn (org-match-string-no-properties 2)))
+ (outline-next-heading)))))
(when include-specials
(setq rtn (append org-special-properties rtn)))
--
1.9.3
next prev parent reply other threads:[~2014-05-23 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 5:07 One broken property drawer prevents setting of any property Eric Abrahamsen
2014-05-23 5:56 ` Bastien
2014-05-23 8:55 ` Eric Abrahamsen [this message]
2014-05-23 9:07 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k39cnabl.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=n.goaziou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.